From 85f71639b0f2b91e58f2ebd4b9cb5a5ba8b5e13c Mon Sep 17 00:00:00 2001
From: John Cass <john.cass77@gmail.com>
Date: Sun, 6 May 2018 09:09:44 +0200
Subject: [PATCH] Don't allow browsing tracks by album if album URI is not
 available.

Fixes #250.
---
 README.rst                                           | 6 ++++--
 mopidy_musicbox_webclient/static/js/functionsvars.js | 6 +++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/README.rst b/README.rst
index 00b7699..fadb6ff 100644
--- a/README.rst
+++ b/README.rst
@@ -108,11 +108,13 @@ Changelog
 (UNRELEASED)
 ------------
 
+- Detect additional stream formats (rtmp, rtmps, rtsp).
+- Include details of currently selected page in HTML title tag. (Addresses: `#243 <https://github.com/pimusicbox/mopidy-musicbox-webclient/issues/243>`_).
+
 **Fixes**
 
-- Detect additional stream formats (rtmp, rtmps, rtsp).
 - Prevent excessive calls to the Mopidy server while buffering. (Fixes: `#237 <https://github.com/pimusicbox/mopidy-musicbox-webclient/issues/237>`_).
-- Include details of currently selected page in HTML title tag. (Addresses: `#243 <https://github.com/pimusicbox/mopidy-musicbox-webclient/issues/243>`_).
+- Only allow browsing tracks by album if a URI is available for that album.  (Fixes: `#250 <https://github.com/pimusicbox/mopidy-musicbox-webclient/issues/250>`_).
 
 v2.4.0 (2017-03-15)
 -------------------
diff --git a/mopidy_musicbox_webclient/static/js/functionsvars.js b/mopidy_musicbox_webclient/static/js/functionsvars.js
index aae009d..774f20e 100644
--- a/mopidy_musicbox_webclient/static/js/functionsvars.js
+++ b/mopidy_musicbox_webclient/static/js/functionsvars.js
@@ -306,8 +306,12 @@ function renderSongLiDivider (previousTrack, track, nextTrack, target) {
     // Render differently if part of an album.
     if (!hasSameAlbum(previousTrack, track) && hasSameAlbum(track, nextTrack)) {
         // Large divider with album cover.
+        showAlbum = ''
+        if (typeof track.album.uri !== 'undefined') {
+            showAlbum = 'onclick="return library.showAlbum(\'' + track.album.uri + '\', mopidy);'
+        }
         html +=
-            '<li class="albumdivider"><a href="#" onclick="return library.showAlbum(\'' + track.album.uri + '\', mopidy);">' +
+            '<li class="albumdivider"><a href="#" ' + showAlbum +
             '<img id="' + getjQueryID(target + '-cover', track.uri) + '" class="artistcover" width="30" height="30"/>' +
             '<h1>' + track.album.name + '</h1><p>' +
             renderSongLiTrackArtists(track) + '</p></a></li>'