Make all threads daemon threads per default

mopidy/backends/libspotify/session_manager.py

@@ -21,10 +21,6 @@ class LibspotifySessionManager(SpotifySessionManager, BaseThread):
         SpotifySessionManager.__init__(self, username, password)
         BaseThread.__init__(self, core_queue)
         self.name = 'LibspotifySMThread'
-        # Run as a daemon thread, so Mopidy won't wait for this thread to exit
-        # before Mopidy exits.
-        self.daemon = True
-        self.core_queue = core_queue
         self.output = output
         self.connected = threading.Event()
         self.session = None

mopidy/frontends/lastfm.py

@@ -61,7 +61,6 @@ class LastfmFrontendThread(BaseThread):
     def __init__(self, core_queue, connection):
         super(LastfmFrontendThread, self).__init__(core_queue)
         self.name = u'LastfmFrontendThread'
-        self.daemon = True
         self.connection = connection
         self.lastfm = None
         self.scrobbler = None

mopidy/frontends/mpd/thread.py

@@ -10,8 +10,6 @@ class MpdThread(BaseThread):
     def __init__(self, core_queue):
         super(MpdThread, self).__init__(core_queue)
         self.name = u'MpdThread'
-        self.daemon = True
-        self.core_queue = core_queue
 
     def run_inside_try(self):
         logger.debug(u'Starting MPD server thread')

mopidy/outputs/gstreamer.py

@@ -94,7 +94,6 @@ class GStreamerMessagesThread(BaseThread):
     def __init__(self, core_queue):
         super(GStreamerMessagesThread, self).__init__(core_queue)
         self.name = u'GStreamerMessagesThread'
-        self.daemon = True
 
     def run_inside_try(self):
         gobject.MainLoop().run()
@@ -115,8 +114,6 @@ class GStreamerPlayerThread(BaseThread):
     def __init__(self, core_queue, output_queue):
         super(GStreamerPlayerThread, self).__init__(core_queue)
         self.name = u'GStreamerPlayerThread'
-        self.daemon = True
-        self.core_queue = core_queue
         self.output_queue = output_queue
         self.gst_pipeline = None
 

mopidy/utils/process.py

@@ -56,6 +56,8 @@ class BaseThread(multiprocessing.dummy.Process):
     def __init__(self, core_queue):
         super(BaseThread, self).__init__()
         self.core_queue = core_queue
+        # No thread should block process from exiting
+        self.daemon = True
 
     def run(self):
         logger.debug(u'%s: Starting thread', self.name)