From 0f6176a3b471d931fa2d2449ffb179c591cd065c Mon Sep 17 00:00:00 2001 From: Thomas Adamcik Date: Sun, 20 Oct 2013 13:26:38 +0200 Subject: [PATCH] local: Temporary workaround for issue #527 Adds a fallback to `Track(uri=uri` when track lookup fails for playlists. This means we can at least load metadata less tracks giving users functioning playlists, instead of only supporting `local:track:...` style URIs. Issue is not fixed, but this is sufficient to reduce priority until we get to the larger planed refactor for this and other core API issues. --- mopidy/backends/local/playlists.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mopidy/backends/local/playlists.py b/mopidy/backends/local/playlists.py index af3814ae..5206718e 100644 --- a/mopidy/backends/local/playlists.py +++ b/mopidy/backends/local/playlists.py @@ -6,7 +6,7 @@ import os import shutil from mopidy.backends import base, listener -from mopidy.models import Playlist +from mopidy.models import Playlist, Track from mopidy.utils import formatting, path from .translator import parse_m3u @@ -52,11 +52,12 @@ class LocalPlaylistsProvider(base.BasePlaylistsProvider): tracks = [] for track_uri in parse_m3u(m3u, self._media_dir): try: - # TODO We must use core.library.lookup() to support tracks + # TODO: We must use core.library.lookup() to support tracks # from other backends tracks += self.backend.library.lookup(track_uri) except LookupError as ex: - logger.warning('Playlist item could not be added: %s', ex) + # TODO: this is just a quick workaround for issue #527. + tracks.append(Track(uri=track_uri)) playlist = Playlist(uri=uri, name=name, tracks=tracks) playlists.append(playlist)