andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

gst1: Fix datetime tag conversion

Browse Source
This commit is contained in:
Stein Magnus Jodal 2015-12-18 01:37:04 +01:00
parent df62997186
commit 0fa78b8e39
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mopidy/audio/tags.py
View File

@ -101,8 +101,7 @@ def convert_tags_to_track(tags):
album_kwargs['num_discs'] = tags.get(Gst.TAG_ALBUM_VOLUME_COUNT, [None])[0]
album_kwargs['musicbrainz_id'] = tags.get('musicbrainz-albumid', [None])[0]
if tags.get(Gst.TAG_DATE) and tags.get(Gst.TAG_DATE)[0]:
track_kwargs['date'] = tags[Gst.TAG_DATE][0].isoformat()
track_kwargs['date'] = tags.get(Gst.TAG_DATE, [None])[0]
# Clear out any empty values we found
track_kwargs = {k: v for k, v in track_kwargs.items() if v}

8
tests/audio/test_tags.py
View File

@ -41,13 +41,13 @@ class TestConvertTaglist(object):
def test_date_time_tag(self):
taglist = self.make_taglist(Gst.TAG_DATE_TIME, [
Gst.DateTime.new_from_iso8601_string(b'2014-01-07')
Gst.DateTime.new_from_iso8601_string(b'2014-01-07 14:13:12')
])
result = tags.convert_taglist(taglist)
assert isinstance(result[Gst.TAG_DATE_TIME][0], compat.text_type)
assert result[Gst.TAG_DATE_TIME][0] == '2014-01-07'
assert result[Gst.TAG_DATE_TIME][0] == '2014-01-07T14:13:12Z'
def test_string_tag(self):
taglist = self.make_taglist(Gst.TAG_ARTIST, [b'ABBA', b'ACDC'])
@ -84,7 +84,7 @@ class TagsToTrackTest(unittest.TestCase):
'track-count': [2],
'album-disc-number': [2],
'album-disc-count': [3],
'date': [datetime.date(2006, 1, 1,)],
'date': ['2006-01-01'],
'container-format': ['ID3 tag'],
'genre': ['genre'],
'comment': ['comment'],
@ -172,7 +172,7 @@ class TagsToTrackTest(unittest.TestCase):
self.check(self.track.replace(date=None))
def test_multiple_track_date(self):
self.tags['date'].append(datetime.date(2030, 1, 1))
self.tags['date'].append('2030-01-01')
self.check(self.track)
def test_missing_track_comment(self):