andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ext: Replace validate_config() with get_config_schema()

Browse Source
This commit is contained in:
Stein Magnus Jodal 2013-04-02 11:34:33 +02:00
parent 28096ce259
commit 12ff51ceba
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
mopidy/ext.py
View File

@ -1,5 +1,7 @@
from __future__ import unicode_literals
from mopidy.utils import config
class Extension(object):
@ -10,9 +12,8 @@ class Extension(object):
raise NotImplementedError(
'Add at least a config section with "enabled = true"')
def validate_config(self, config):
raise NotImplementedError(
'You must explicitly pass config validation if not needed')
def get_config_schema(self):
return config.ExtensionConfigSchema()
def validate_environment(self):
pass

7
tests/ext_test.py
View File

@ -1,6 +1,7 @@
from __future__ import unicode_literals
from mopidy.ext import Extension
from mopidy.utils import config
from tests import unittest
@ -18,8 +19,10 @@ class ExtensionTest(unittest.TestCase):
def test_get_default_config_raises_not_implemented(self):
self.assertRaises(NotImplementedError, self.ext.get_default_config)
def test_validate_config_raises_not_implemented(self):
self.assertRaises(NotImplementedError, self.ext.validate_config, None)
def test_get_config_schema_returns_extension_schema(self):
schema = self.ext.get_config_schema()
self.assertIsInstance(schema, config.ExtensionConfigSchema)
self.assertIsInstance(schema['enabled'], config.Boolean)
def test_validate_environment_does_nothing_by_default(self):
self.assertIsNone(self.ext.validate_environment())