From 190abc3513e5af7d9d9cf0746d6595e94c48aab2 Mon Sep 17 00:00:00 2001 From: Thomas Adamcik Date: Wed, 13 Jan 2016 23:29:24 +0100 Subject: [PATCH] gst1: Use default queue settings Removing this queue seems to break appsrc about to finish. --- mopidy/audio/actor.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mopidy/audio/actor.py b/mopidy/audio/actor.py index 160dc8a8..92ccb44a 100644 --- a/mopidy/audio/actor.py +++ b/mopidy/audio/actor.py @@ -464,12 +464,10 @@ class Audio(pykka.ThreadingActor): # Queue element to buy us time between the about-to-finish event and # the actual switch, i.e. about to switch can block for longer thanks # to this queue. - # TODO: make the min-max values a setting? + # TODO: See if settings should be set to minimize latency. Previous + # setting breaks appsrc, and settings before that broke on a few + # systems. So leave the default to play it safe. queue = Gst.ElementFactory.make('queue') - queue.set_property('max-size-buffers', 0) - queue.set_property('max-size-bytes', 0) - queue.set_property('max-size-time', 3 * Gst.SECOND) - queue.set_property('min-threshold-time', 1 * Gst.SECOND) audio_sink.add(queue) audio_sink.add(self._outputs)