util/path: Expose errors to callers of find helper

mopidy/local/commands.py

@@ -74,9 +74,11 @@ class ScanCommand(commands.Command):
         uris_to_update = set()
         uris_to_remove = set()
 
-        file_mtimes = path.find_mtimes(media_dir)
+        file_mtimes, file_errors = path.find_mtimes(media_dir)
         logger.info('Found %d files in media_dir.', len(file_mtimes))
 
+        # TODO: log file errors
+
         num_tracks = library.load()
         logger.info('Checking %d tracks from library.', num_tracks)
 

mopidy/utils/path.py

@@ -184,7 +184,8 @@ def _find(root, thread_count=10, hidden=True, relative=False):
 
 def find_mtimes(root):
     results, errors = _find(root, hidden=False, relative=False)
-    return dict((f, int(st.st_mtime)) for f, st in results.iteritems())
+    mtimes = dict((f, int(st.st_mtime)) for f, st in results.iteritems())
+    return mtimes, errors
 
 
 def check_file_path_is_inside_base_dir(file_path, base_path):

tests/audio/test_scan.py

@@ -295,7 +295,8 @@ class ScannerTest(unittest.TestCase):
 
     def find(self, path):
         media_dir = path_to_data_dir(path)
-        for path in path_lib.find_mtimes(media_dir):
+        result, errors = path_lib.find_mtimes(media_dir)
+        for path in result:
             yield os.path.join(media_dir, path)
 
     def scan(self, paths):

tests/utils/test_path.py

@@ -215,7 +215,8 @@ class FindMTimesTest(unittest.TestCase):
     maxDiff = None
 
     def find(self, value):
-        return path.find_mtimes(path_to_data_dir(value))
+        result, errors = path.find_mtimes(path_to_data_dir(value))
+        return result
 
     def test_basic_dir(self):
         self.assert_(self.find(''))