Merge pull request #992 from adamcik/feature/default-get-images-fallback

backend: Add a default get_images impl.

mopidy/backend.py

@@ -2,7 +2,7 @@ from __future__ import absolute_import, unicode_literals
 
 import copy
 
-from mopidy import listener
+from mopidy import listener, models
 
 
 class Backend(object):
@@ -97,8 +97,19 @@ class LibraryProvider(object):
         See :meth:`mopidy.core.LibraryController.get_images`.
 
         *MAY be implemented by subclass.*
+
+        Default implementation will simply call lookup and try and use the
+        album art for any tracks returned. Most extensions should replace this
+        with something smarter or simply return an empty dictionary.
         """
-        return {}
+        result = {}
+        for uri in uris:
+            for track in self.lookup(uri):
+                if track.album and track.album.images:
+                    for image_uri in track.album.images:
+                        image = models.Image(uri=image_uri)
+                        result.setdefault(uri, []).append(image)
+        return result
 
     # TODO: replace with search(query, exact=True, ...)
     def find_exact(self, query=None, uris=None):

tests/backend/test_backend.py

@@ -0,0 +1,19 @@
+from __future__ import absolute_import, unicode_literals
+
+import unittest
+
+from mopidy import models
+
+from tests import dummy_backend
+
+
+class LibraryTest(unittest.TestCase):
+    def test_default_get_images_impl_falls_back_to_album_image(self):
+        album = models.Album(images=['imageuri'])
+        track = models.Track(uri='trackuri', album=album)
+
+        library = dummy_backend.DummyLibraryProvider(backend=None)
+        library.dummy_library.append(track)
+
+        expected = {'trackuri': [models.Image(uri='imageuri')]}
+        self.assertEqual(library.get_images(['trackuri']), expected)