From 9d931adf4a02b75cf6cd9b7ff32d8f9dcacc7e9f Mon Sep 17 00:00:00 2001 From: jcass Date: Tue, 3 Feb 2015 18:30:56 +0200 Subject: [PATCH 1/2] Re-set volume explicitly to the current level whenever changing tracks. Workaround for issue #886. --- mopidy/audio/actor.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mopidy/audio/actor.py b/mopidy/audio/actor.py index 0d90394d..9059cf89 100644 --- a/mopidy/audio/actor.py +++ b/mopidy/audio/actor.py @@ -320,7 +320,9 @@ class Audio(pykka.ThreadingActor): :param uri: the URI to play :type uri: string """ + current_volume = self.get_volume() self._playbin.set_property('uri', uri) + self.set_volume(current_volume) def set_appsrc( self, caps, need_data=None, enough_data=None, seek_data=None): From 090518b96dd35c4bbe8284a701b4279bf394e7a6 Mon Sep 17 00:00:00 2001 From: jcass Date: Wed, 4 Feb 2015 07:46:31 +0200 Subject: [PATCH 2/2] Add comment for Mac OS X volume reset workaround. --- mopidy/audio/actor.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mopidy/audio/actor.py b/mopidy/audio/actor.py index 9059cf89..8f374257 100644 --- a/mopidy/audio/actor.py +++ b/mopidy/audio/actor.py @@ -320,6 +320,9 @@ class Audio(pykka.ThreadingActor): :param uri: the URI to play :type uri: string """ + # Note: Hack to workaround issue on Mac OS X where volume level + # does not persist between track changes. + # https://github.com/mopidy/mopidy/issues/886 current_volume = self.get_volume() self._playbin.set_property('uri', uri) self.set_volume(current_volume)