andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

local: Fix get_images() for local libraries returning single track from lookup().

Browse Source
This commit is contained in:
Thomas Kemmer 2015-03-14 16:12:46 +01:00
parent abe9b7aea7
commit 29b4a2075a
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mopidy/local/__init__.py
View File

@ -116,7 +116,11 @@ class Library(object):
result = {}
for uri in uris:
image_uris = set()
for track in self.lookup(uri):
tracks = self.lookup(uri)
# local libraries may return single track
if isinstance(tracks, models.Track):
tracks = [tracks]
for track in tracks:
if track.album and track.album.images:
image_uris.update(track.album.images)
result[uri] = [models.Image(uri=u) for u in image_uris]

12
tests/local/test_library.py
View File

@ -597,6 +597,18 @@ class LocalLibraryProviderTest(unittest.TestCase):
result = library.get_images([track.uri])
self.assertEqual(result, {track.uri: [image]})
@mock.patch.object(json.JsonLibrary, 'lookup')
def test_default_get_images_impl_single_track(self, mock_lookup):
library = actor.LocalBackend(config=self.config, audio=None).library
image = Image(uri='imageuri')
album = Album(images=[image.uri])
track = Track(uri='trackuri', album=album)
mock_lookup.return_value = track
result = library.get_images([track.uri])
self.assertEqual(result, {track.uri: [image]})
@mock.patch.object(json.JsonLibrary, 'get_images')
def test_local_library_get_images(self, mock_get_images):
library = actor.LocalBackend(config=self.config, audio=None).library