andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dummy: Make it obvious that method is test-only

Browse Source
This commit is contained in:
Stein Magnus Jodal 2015-03-25 13:14:51 +01:00
parent c9f60170f8
commit 2c11344434
3 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/dummy_backend.py
View File

@ -97,7 +97,7 @@ class DummyPlaylistsProvider(backend.PlaylistsProvider):
super(DummyPlaylistsProvider, self).__init__(backend)
self._playlists = []
def set_playlists(self, playlists):
def set_dummy_playlists(self, playlists):
"""For tests using the dummy provider through an actor proxy."""
self._playlists = playlists

8
tests/mpd/protocol/test_music_db.py
View File

@ -277,7 +277,7 @@ class MusicDatabaseHandlerTest(protocol.BaseTestCase):
def test_lsinfo_without_path_returns_same_as_for_root(self):
last_modified = 1390942873222
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a', uri='dummy:/a', last_modified=last_modified)])
response1 = self.send_request('lsinfo')
@ -286,7 +286,7 @@ class MusicDatabaseHandlerTest(protocol.BaseTestCase):
def test_lsinfo_with_empty_path_returns_same_as_for_root(self):
last_modified = 1390942873222
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a', uri='dummy:/a', last_modified=last_modified)])
response1 = self.send_request('lsinfo ""')
@ -295,7 +295,7 @@ class MusicDatabaseHandlerTest(protocol.BaseTestCase):
def test_lsinfo_for_root_includes_playlists(self):
last_modified = 1390942873222
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a', uri='dummy:/a', last_modified=last_modified)])
self.send_request('lsinfo "/"')
@ -384,7 +384,7 @@ class MusicDatabaseHandlerTest(protocol.BaseTestCase):
self.backend.library.dummy_browse_result = {
'dummy:/': [Ref.track(uri='dummy:/a', name='a'),
Ref.directory(uri='dummy:/foo', name='foo')]}
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a', uri='dummy:/a', last_modified=last_modified)])
response = self.send_request('lsinfo "/"')

30
tests/mpd/protocol/test_stored_playlists.py
View File

@ -7,7 +7,7 @@ from tests.mpd import protocol
class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_listplaylist(self):
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(
name='name', uri='dummy:name', tracks=[Track(uri='dummy:a')])])
@ -16,7 +16,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
self.assertInResponse('OK')
def test_listplaylist_without_quotes(self):
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(
name='name', uri='dummy:name', tracks=[Track(uri='dummy:a')])])
@ -31,14 +31,14 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_listplaylist_duplicate(self):
playlist1 = Playlist(name='a', uri='dummy:a1', tracks=[Track(uri='b')])
playlist2 = Playlist(name='a', uri='dummy:a2', tracks=[Track(uri='c')])
self.backend.playlists.set_playlists([playlist1, playlist2])
self.backend.playlists.set_dummy_playlists([playlist1, playlist2])
self.send_request('listplaylist "a [2]"')
self.assertInResponse('file: c')
self.assertInResponse('OK')
def test_listplaylistinfo(self):
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(
name='name', uri='dummy:name', tracks=[Track(uri='dummy:a')])])
@ -49,7 +49,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
self.assertInResponse('OK')
def test_listplaylistinfo_without_quotes(self):
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(
name='name', uri='dummy:name', tracks=[Track(uri='dummy:a')])])
@ -67,7 +67,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_listplaylistinfo_duplicate(self):
playlist1 = Playlist(name='a', uri='dummy:a1', tracks=[Track(uri='b')])
playlist2 = Playlist(name='a', uri='dummy:a2', tracks=[Track(uri='c')])
self.backend.playlists.set_playlists([playlist1, playlist2])
self.backend.playlists.set_dummy_playlists([playlist1, playlist2])
self.send_request('listplaylistinfo "a [2]"')
self.assertInResponse('file: c')
@ -77,7 +77,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_listplaylists(self):
last_modified = 1390942873222
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a', uri='dummy:a', last_modified=last_modified)])
self.send_request('listplaylists')
@ -89,7 +89,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_listplaylists_duplicate(self):
playlist1 = Playlist(name='a', uri='dummy:a1')
playlist2 = Playlist(name='a', uri='dummy:a2')
self.backend.playlists.set_playlists([playlist1, playlist2])
self.backend.playlists.set_dummy_playlists([playlist1, playlist2])
self.send_request('listplaylists')
self.assertInResponse('playlist: a')
@ -98,7 +98,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_listplaylists_ignores_playlists_without_name(self):
last_modified = 1390942873222
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='', uri='dummy:', last_modified=last_modified)])
self.send_request('listplaylists')
@ -106,7 +106,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
self.assertInResponse('OK')
def test_listplaylists_replaces_newline_with_space(self):
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a\n', uri='dummy:')])
self.send_request('listplaylists')
self.assertInResponse('playlist: a ')
@ -114,7 +114,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
self.assertInResponse('OK')
def test_listplaylists_replaces_carriage_return_with_space(self):
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a\r', uri='dummy:')])
self.send_request('listplaylists')
self.assertInResponse('playlist: a ')
@ -122,7 +122,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
self.assertInResponse('OK')
def test_listplaylists_replaces_forward_slash_with_pipe(self):
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='a/b', uri='dummy:')])
self.send_request('listplaylists')
self.assertInResponse('playlist: a|b')
@ -132,7 +132,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_load_appends_to_tracklist(self):
self.core.tracklist.add([Track(uri='a'), Track(uri='b')])
self.assertEqual(len(self.core.tracklist.tracks.get()), 2)
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='A-list', uri='dummy:A-list', tracks=[
Track(uri='c'), Track(uri='d'), Track(uri='e')])])
@ -150,7 +150,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_load_with_range_loads_part_of_playlist(self):
self.core.tracklist.add([Track(uri='a'), Track(uri='b')])
self.assertEqual(len(self.core.tracklist.tracks.get()), 2)
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='A-list', uri='dummy:A-list', tracks=[
Track(uri='c'), Track(uri='d'), Track(uri='e')])])
@ -166,7 +166,7 @@ class PlaylistsHandlerTest(protocol.BaseTestCase):
def test_load_with_range_without_end_loads_rest_of_playlist(self):
self.core.tracklist.add([Track(uri='a'), Track(uri='b')])
self.assertEqual(len(self.core.tracklist.tracks.get()), 2)
self.backend.playlists.set_playlists([
self.backend.playlists.set_dummy_playlists([
Playlist(name='A-list', uri='dummy:A-list', tracks=[
Track(uri='c'), Track(uri='d'), Track(uri='e')])])