From 37cd2965521586403b42f25c6643f6111711dbad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Chr=C3=A9tien?= Date: Tue, 31 May 2016 15:13:55 +0200 Subject: [PATCH] mpd: fix protocol for replay_gain_status --- docs/changelog.rst | 3 +++ mopidy/mpd/protocol/playback.py | 2 +- tests/mpd/protocol/test_playback.py | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 18eaea9f..e47ba9af 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -38,6 +38,9 @@ Bug fix release. where a :confval:`file/media_dirs` path contained non-ASCII characters. (Fixes: :issue:`1345`, PR: :issue:`1493`) +- MPD: Fix MPD protocol for ``replay_gain_status`` command. The actual command + remains unimplemented. (PR: :issue:`1520`) + v2.0.0 (2016-02-15) =================== diff --git a/mopidy/mpd/protocol/playback.py b/mopidy/mpd/protocol/playback.py index 7b943930..08e7cded 100644 --- a/mopidy/mpd/protocol/playback.py +++ b/mopidy/mpd/protocol/playback.py @@ -325,7 +325,7 @@ def replay_gain_status(context): Prints replay gain options. Currently, only the variable ``replay_gain_mode`` is returned. """ - return 'off' # TODO + return 'replay_gain_mode: off' # TODO @protocol.commands.add('seek', songpos=protocol.UINT, seconds=protocol.UINT) diff --git a/tests/mpd/protocol/test_playback.py b/tests/mpd/protocol/test_playback.py index 9f13fc22..07ece3b0 100644 --- a/tests/mpd/protocol/test_playback.py +++ b/tests/mpd/protocol/test_playback.py @@ -115,7 +115,7 @@ class PlaybackOptionsHandlerTest(protocol.BaseTestCase): def test_replay_gain_status_default(self): self.send_request('replay_gain_status') self.assertInResponse('OK') - self.assertInResponse('off') + self.assertInResponse('replay_gain_mode: off') def test_mixrampdb(self): self.send_request('mixrampdb "10"')