andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve default get_images() implementation with album/artist URIs.

Browse Source
This commit is contained in:
Thomas Kemmer 2015-02-27 22:22:28 +01:00
parent 7520b13aa1
commit 301f732047
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mopidy/backend.py
View File

@ -104,11 +104,11 @@ class LibraryProvider(object):
"""
result = {}
for uri in uris:
image_uris = set()
for track in self.lookup(uri):
if track.album and track.album.images:
for image_uri in track.album.images:
image = models.Image(uri=image_uri)
result.setdefault(uri, []).append(image)
image_uris.update(track.album.images)
result[uri] = list(map(lambda u: models.Image(uri=u), image_uris))
return result
# TODO: replace with search(query, exact=True, ...)

11
tests/backend/test_backend.py
View File

@ -17,3 +17,14 @@ class LibraryTest(unittest.TestCase):
expected = {'trackuri': [models.Image(uri='imageuri')]}
self.assertEqual(library.get_images(['trackuri']), expected)
def test_default_get_images_impl_no_album_image(self):
# default implementation now returns an empty list if no
# images are found, though it's not required to
track = models.Track(uri='trackuri')
library = dummy_backend.DummyLibraryProvider(backend=None)
library.dummy_library.append(track)
expected = {'trackuri': []}
self.assertEqual(library.get_images(['trackuri']), expected)