From 40c1547c156f74c31888d6b7ed85f789ccaf00c3 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 25 Oct 2010 22:03:40 +0200 Subject: [PATCH] Fix/ignore remaining pylint warnings --- mopidy/backends/base/playback.py | 6 ++++++ mopidy/backends/libspotify/session_manager.py | 5 +++++ mopidy/outputs/dummy.py | 3 +++ pylintrc | 3 ++- 4 files changed, 16 insertions(+), 1 deletion(-) diff --git a/mopidy/backends/base/playback.py b/mopidy/backends/base/playback.py index 1faa5adf..b7ceeee2 100644 --- a/mopidy/backends/base/playback.py +++ b/mopidy/backends/base/playback.py @@ -10,6 +10,9 @@ class BasePlaybackController(object): :type backend: :class:`BaseBackend` """ + # pylint: disable = R0902 + # Too many instance attributes + #: Constant representing the paused state. PAUSED = u'paused' @@ -130,6 +133,9 @@ class BasePlaybackController(object): Not necessarily the same track as :attr:`cp_track_at_next`. """ + # pylint: disable = R0911 + # Too many return statements + cp_tracks = self.backend.current_playlist.cp_tracks if not cp_tracks: diff --git a/mopidy/backends/libspotify/session_manager.py b/mopidy/backends/libspotify/session_manager.py index 7f541236..45841350 100644 --- a/mopidy/backends/libspotify/session_manager.py +++ b/mopidy/backends/libspotify/session_manager.py @@ -11,6 +11,9 @@ from mopidy.utils.process import BaseThread logger = logging.getLogger('mopidy.backends.libspotify.session_manager') +# pylint: disable = R0901 +# LibspotifySessionManager: Too many ancestors (9/7) + class LibspotifySessionManager(SpotifySessionManager, BaseThread): cache_location = os.path.expanduser(settings.SPOTIFY_LIB_CACHE) settings_location = os.path.expanduser(settings.SPOTIFY_LIB_CACHE) @@ -65,6 +68,8 @@ class LibspotifySessionManager(SpotifySessionManager, BaseThread): def music_delivery(self, session, frames, frame_size, num_frames, sample_type, sample_rate, channels): """Callback used by pyspotify""" + # pylint: disable = R0913 + # Too many arguments (8/5) assert sample_type == 0, u'Expects 16-bit signed integer samples' capabilites = """ audio/x-raw-int, diff --git a/mopidy/outputs/dummy.py b/mopidy/outputs/dummy.py index fd42b38b..060ee02f 100644 --- a/mopidy/outputs/dummy.py +++ b/mopidy/outputs/dummy.py @@ -5,6 +5,9 @@ class DummyOutput(BaseOutput): Audio output used for testing. """ + # pylint: disable = R0902 + # Too many instance attributes (9/7) + #: For testing. :class:`True` if :meth:`start` has been called. start_called = False diff --git a/pylintrc b/pylintrc index 3b89651f..9fed307c 100644 --- a/pylintrc +++ b/pylintrc @@ -14,9 +14,10 @@ # R0903 - Too few public methods (%s/%s) # R0904 - Too many public methods (%s/%s) # W0141 - Used builtin function %r +# R0921 - Abstract class not referenced # W0142 - Used * or ** magic # W0401 - Wildcard import %s # W0511 - TODO, FIXME and XXX in the code # W0613 - Unused argument %r # -disable = C0103,C0111,C0112,E0102,E0202,E1101,R0201,R0801,R0903,R0904,W0141,W0142,W0401,W0511,W0613 +disable = C0103,C0111,C0112,E0102,E0202,E1101,R0201,R0801,R0903,R0904,R0921,W0141,W0142,W0401,W0511,W0613