From 48acbf701c10d847621e82879dc6703784f1576b Mon Sep 17 00:00:00 2001
From: Thomas Adamcik <adamcik@samfundet.no>
Date: Tue, 6 Apr 2010 15:02:15 +0200
Subject: [PATCH] Add FIXMEs

---
 mopidy/backends/__init__.py      | 2 ++
 mopidy/backends/gstreamer.py     | 3 +++
 tests/backends/gstreamer_test.py | 1 +
 3 files changed, 6 insertions(+)

diff --git a/mopidy/backends/__init__.py b/mopidy/backends/__init__.py
index 97c047fb..da554e3b 100644
--- a/mopidy/backends/__init__.py
+++ b/mopidy/backends/__init__.py
@@ -349,6 +349,8 @@ class BasePlaybackController(object):
     def state(self, new_state):
         (old_state, self._state) = (self.state, new_state)
         logger.debug(u'Changing state: %s -> %s', old_state, new_state)
+        # FIXME _play_time stuff assumes backend does not have a better way of
+        # handeling this stuff :/
         if (old_state in (self.PLAYING, self.STOPPED)
                 and new_state == self.PLAYING):
             self._play_time_start()
diff --git a/mopidy/backends/gstreamer.py b/mopidy/backends/gstreamer.py
index 20ee892f..c594c305 100644
--- a/mopidy/backends/gstreamer.py
+++ b/mopidy/backends/gstreamer.py
@@ -34,6 +34,8 @@ class GStreamerPlaybackController(BasePlaybackController):
         self._bus = self._bin.get_bus()
         sink = gst.element_factory_make("fakesink", "fakesink")
 
+        # FIXME cleanup fakesink?
+
         self._bin.set_property("video-sink", sink)
         self._bus.add_signal_watch()
         self._bus_id = self._bus.connect('message', self._message)
@@ -91,6 +93,7 @@ class GStreamerPlaybackController(BasePlaybackController):
         else:
             self._set_state(gst.STATE_PLAYING)
 
+    # FIXME refactor to _seek ?
     def seek(self, time_position):
         if self.state == self.STOPPED:
             self.play()
diff --git a/tests/backends/gstreamer_test.py b/tests/backends/gstreamer_test.py
index 0883a34b..2a390fb3 100644
--- a/tests/backends/gstreamer_test.py
+++ b/tests/backends/gstreamer_test.py
@@ -13,6 +13,7 @@ folder = os.path.abspath(folder)
 song = os.path.join(folder, 'song%s.mp3')
 song = 'file://' + song
 
+# FIXME can be switched to generic test
 class GStreamerCurrentPlaylistHandlerTest(BaseCurrentPlaylistControllerTest, unittest.TestCase):
     tracks = [Track(uri=song % i, id=i, length=4464) for i in range(1, 4)]