andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add FIXME's to 'commands' and 'notcommands', as they currently do not care if the client is authenticated or not

Browse Source
This commit is contained in:
Stein Magnus Jodal 2011-01-21 02:20:07 +01:00
parent 775ec64976
commit 4953a80cce
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
mopidy/frontends/mpd/protocol/reflection.py
View File

@ -9,9 +9,12 @@ def commands(frontend):
``commands``
Shows which commands the current user has access to.
As permissions is not implemented, any user has access to all commands.
"""
# FIXME When password auth is turned on and the client is not
# authenticated, 'commands' should list only the commands the client does
# have access to. To implement this we need access to the session object to
# check if the client is authenticated or not.
sorted_commands = sorted(list(mpd_commands))
# Not shown by MPD in its command list
@ -51,9 +54,11 @@ def notcommands(frontend):
``notcommands``
Shows which commands the current user does not have access to.
As permissions is not implemented, any user has access to all commands.
"""
# FIXME When password auth is turned on and the client is not
# authenticated, 'notcommands' should list all the commands the client does
# not have access to. To implement this we need access to the session
# object to check if the client is authenticated or not.
pass
@handle_pattern(r'^tagtypes$')