From 5317834baf62d04e3a844a1804af1ea5782ddbf1 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Tue, 23 Sep 2014 18:47:54 +0200 Subject: [PATCH] history: Change size property to get_length() method For consistency with tracklist.get_length() and our goal of aligning Python and JS APIs by using less properties in the core API. --- mopidy/core/history.py | 3 +-- tests/core/test_history.py | 8 ++++++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/mopidy/core/history.py b/mopidy/core/history.py index 021ee34d..6711bcf4 100644 --- a/mopidy/core/history.py +++ b/mopidy/core/history.py @@ -37,8 +37,7 @@ class HistoryController(object): self._history.insert(0, (timestamp, ref)) - @property - def size(self): + def get_length(self): """Get the number of tracks in the history. :returns: the history length diff --git a/tests/core/test_history.py b/tests/core/test_history.py index e0f607f9..75b4dc76 100644 --- a/tests/core/test_history.py +++ b/tests/core/test_history.py @@ -19,15 +19,19 @@ class PlaybackHistoryTest(unittest.TestCase): def test_add_track(self): self.history.add(self.tracks[0]) + self.assertEqual(self.history.get_length(), 1) + self.history.add(self.tracks[1]) + self.assertEqual(self.history.get_length(), 2) + self.history.add(self.tracks[2]) - self.assertEqual(self.history.size, 3) + self.assertEqual(self.history.get_length(), 3) def test_non_tracks_are_rejected(self): with self.assertRaises(TypeError): self.history.add(object()) - self.assertEqual(self.history.size, 0) + self.assertEqual(self.history.get_length(), 0) def test_history_entry_contents(self): track = self.tracks[0]