From 541412dbfc33d80727db5dbba067fdcc9d922470 Mon Sep 17 00:00:00 2001 From: Thomas Adamcik Date: Sun, 14 Dec 2014 14:35:13 +0100 Subject: [PATCH] mpd: Remove newline escaping code. This was added for #881, where the correct fix turned out to be to remove comments from the responses. We should still add some sanity checks for verifying that our responses at the very least only contain printable chars. --- mopidy/mpd/dispatcher.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/mopidy/mpd/dispatcher.py b/mopidy/mpd/dispatcher.py index 8167a774..5d9cecd9 100644 --- a/mopidy/mpd/dispatcher.py +++ b/mopidy/mpd/dispatcher.py @@ -196,17 +196,12 @@ class MpdDispatcher(object): def _format_lines(self, line): if isinstance(line, dict): - return [self._escape_newlines('%s: %s' % (key, value)) - for (key, value) - in line.items()] + return ['%s: %s' % (key, value) for (key, value) in line.items()] if isinstance(line, tuple): (key, value) = line - return [self._escape_newlines('%s: %s' % (key, value))] + return ['%s: %s' % (key, value)] return [line] - def _escape_newlines(self, text): - return text.replace('\n', '\\n') - class MpdContext(object): """