From 55e50ae5d2d9fdd7967f4dbb9e5e5d7168dc7adb Mon Sep 17 00:00:00 2001 From: Thomas Adamcik Date: Mon, 27 Apr 2015 22:55:21 +0200 Subject: [PATCH] audio: Switch to time based buffering in tee branches --- docs/changelog.rst | 4 ++++ mopidy/audio/actor.py | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 369900e4..904e938c 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -11,6 +11,10 @@ v1.0.3 (unreleased) for 2.3 we didn't catch that our previous fix wasn't sufficient. (Fixes: :issue:`1153`) +- Audio: Follow-up fix for :issue:`1097` still exhibits issues for certain + setups. We are giving this get an other go by setting the buffer size to + maximum 100ms instead of a fixed number of buffers. (Fixes: :issue:`1147`) + v1.0.2 (2015-04-27) =================== diff --git a/mopidy/audio/actor.py b/mopidy/audio/actor.py index 45ad73ff..7cca954a 100644 --- a/mopidy/audio/actor.py +++ b/mopidy/audio/actor.py @@ -164,7 +164,8 @@ class _Outputs(gst.Bin): # All tee branches need a queue in front of them. # But keep the queue short so the volume change isn't to slow: queue = gst.element_factory_make('queue') - queue.set_property('max-size-buffers', 15) + queue.set_property('max-size-time', 100 * gst.MSECOND) + self.add(element) self.add(queue) queue.link(element)