diff --git a/tests/backends/base.py b/tests/backends/base.py index 2f322edd..1e850768 100644 --- a/tests/backends/base.py +++ b/tests/backends/base.py @@ -736,24 +736,6 @@ class BasePlaybackControllerTest(object): self.assertEqual(first, second) -# FIXME move to mixer tests -# def test_volume(self): -# if not self.supports_volume: -# self.assertEqual(self.playback.volume, None) -# else: -# self.assertEqual(self.playback.volume, 100) -# self.playback.volume = 50 -# self.assertEqual(self.playback.volume, 50) -# self.playback.volume = 0 -# self.assertEqual(self.playback.volume, 0) -# -# def test_volume_is_not_float(self): -# if not self.supports_volume: -# return -# -# self.playback.volume = 1.0 / 3 * 100 -# self.assertEqual(self.playback.volume, 33) - @populate_playlist def test_play_with_consume(self): self.playback.consume = True diff --git a/tests/mixers/dummy_test.py b/tests/mixers/dummy_test.py index 35944e14..0659a12e 100644 --- a/tests/mixers/dummy_test.py +++ b/tests/mixers/dummy_test.py @@ -32,3 +32,7 @@ class BaseMixerTest(unittest.TestCase): def test_volume_set_to_above_max_results_in_max(self): self.mixer.volume = self.MAX + 10 self.assertEqual(self.mixer.volume, self.ACTUAL_MAX) + + def test_volume_is_not_float(self): + self.mixer.volume = 1.0 / 3 * 100 + self.assertEqual(self.mixer.volume, 33)