andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

audio: Address my own comments on PR#1538

Browse Source
This commit is contained in:
Stein Magnus Jodal 2016-08-07 09:24:45 +02:00
parent 3e12ed1f69
commit 5e8682cc51
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/changelog.rst
View File

@ -36,7 +36,8 @@ Bug fix release.
- Audio: Ensure audio tags are never ``None``. (Fixes: :issue:`1449`) - Audio: Ensure audio tags are never ``None``. (Fixes: :issue:`1449`)
- Audio: Update :meth:`mopidy.audio.Audio.set_metadata` to postpone sending - Audio: Update :meth:`mopidy.audio.Audio.set_metadata` to postpone sending
tags if there is a pending track change. (Fixes: :issue:`1357`) tags if there is a pending track change. (Fixes: :issue:`1357`, PR:
:issue:`1538`)
- Core: Avoid endless loop if all tracks in the tracklist are unplayable and - Core: Avoid endless loop if all tracks in the tracklist are unplayable and
consume mode is off. (Fixes: :issue:`1221`, :issue:`1454`, PR: :issue:`1455`) consume mode is off. (Fixes: :issue:`1221`, :issue:`1454`, PR: :issue:`1455`)

9
mopidy/audio/actor.py
View File

@ -805,11 +805,14 @@ class Audio(pykka.ThreadingActor):
if track.album and track.album.name: if track.album and track.album.name:
set_value(Gst.TAG_ALBUM, track.album.name) set_value(Gst.TAG_ALBUM, track.album.name)
gst_logger.debug(
'Sending TAG event for track %r: %r',
track.uri, taglist.to_string())
event = Gst.Event.new_tag(taglist) event = Gst.Event.new_tag(taglist)
if not self._pending_uri: if self._pending_uri:
self._playbin.send_event(event)
else:
self._pending_metadata = event self._pending_metadata = event
else:
self._playbin.send_event(event)
def get_current_tags(self): def get_current_tags(self):
""" """