From 660e21971c362cbc446b34815a261604c1f0acb9 Mon Sep 17 00:00:00 2001 From: Thomas Adamcik Date: Wed, 7 Apr 2010 02:52:35 +0200 Subject: [PATCH] Clean BaseMixerTest --- tests/mixers/dummy_test.py | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/tests/mixers/dummy_test.py b/tests/mixers/dummy_test.py index 00d748fe..742bccf3 100644 --- a/tests/mixers/dummy_test.py +++ b/tests/mixers/dummy_test.py @@ -3,24 +3,30 @@ import unittest from mopidy.mixers.dummy import DummyMixer class BaseMixerTest(unittest.TestCase): + MIN = 0 + MAX = 100 + + ACTUAL_MIN = MIN + ACTUAL_MAX = MAX + def setUp(self): - self.m = DummyMixer() + self.mixer = DummyMixer() def test_volume_is_None_initially(self): - self.assertEqual(self.m.volume, None) + self.assertEqual(self.mixer.volume, None) def test_volume_set_to_min(self): - self.m.volume = 0 - self.assertEqual(self.m.volume, 0) + self.mixer.volume = self.MIN + self.assertEqual(self.mixer.volume, self.ACTUAL_MIN) def test_volume_set_to_max(self): - self.m.volume = 100 - self.assertEqual(self.m.volume, 100) + self.mixer.volume = self.MAX + self.assertEqual(self.mixer.volume, self.ACTUAL_MAX) def test_volume_set_to_below_min_results_in_min(self): - self.m.volume = -10 - self.assertEqual(self.m.volume, 0) + self.mixer.volume = -10 + self.assertEqual(self.mixer.volume, self.ACTUAL_MIN) def test_volume_set_to_above_max_results_in_max(self): - self.m.volume = 110 - self.assertEqual(self.m.volume, 100) + self.mixer.volume = self.MAX + 10 + self.assertEqual(self.mixer.volume, self.ACTUAL_MAX)