local: Review fixes.

mopidy/backends/base.py

@@ -155,10 +155,9 @@ class BasePlaybackProvider(object):
         :type track: :class:`mopidy.models.Track`
         :rtype: :class:`True` if successful, else :class:`False`
         """
-        self.audio.prepare_change()  # TODO: add .get() to this?
+        self.audio.prepare_change()
         self.change_track(track)
-        self.audio.start_playback().get()
+        return self.audio.start_playback().get()
-        return True
 
     def change_track(self, track):
         """

mopidy/backends/local/playback.py

@@ -6,7 +6,7 @@ import os
 from mopidy.backends import base
 from mopidy.utils import path
 
-logger = logging.getLogger('mopidy.backends.spotify')
+logger = logging.getLogger('mopidy.backends.local')
 
 
 class LocalPlaybackProvider(base.BasePlaybackProvider):

mopidy/ext.py

@@ -80,6 +80,11 @@ class Extension(object):
         return []
 
     def get_library_updaters(self):
+        """List of library updater classes
+
+        :returns: list of :class:`~mopidy.backends.base.BaseLibraryUpdateProvider`
+        subclasses
+        """
         return []
 
     def register_gstreamer_elements(self):

mopidy/scanner.py

@@ -62,11 +62,11 @@ def main():
                 updaters[e.ext_name] = updater_class
 
     if not updaters:
-        logging.error('No usable updaters found.')
+        logging.error('No usable library updaters found.')
         return
     elif len(updaters) > 1:
-        names = ', '.join(updaters.keys())
+        logging.error('More than one library updater found. '
-        logging.error('More than one updater found. Provided by: %s', names)
+                      'Provided by: %s', ', '.join(updaters.keys()))
         return
 
     local_updater = updaters.values()[0](config)  # TODO: switch to actor?

tests/backends/local/__init__.py

@@ -1,6 +1,4 @@
 from __future__ import unicode_literals
 
-from mopidy.utils.path import path_to_uri
-
 
 generate_song = lambda i: 'local:track:song%s.wav' % i

tests/backends/local/playback_test.py

@@ -6,9 +6,9 @@ from mopidy.backends.local import actor
 from mopidy.core import PlaybackState
 from mopidy.models import Track
 
+from tests import path_to_data_dir
 from tests.backends.base.playback import PlaybackControllerTest
 from tests.backends.local import generate_song
-from tests import path_to_data_dir
 
 
 class LocalPlaybackControllerTest(PlaybackControllerTest, unittest.TestCase):