From 70dbf81191ee4a1f8c9136f1d5f1ed64f048855e Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Tue, 20 Nov 2012 11:53:08 +0100 Subject: [PATCH] mpd: Simplify 'addid' implementation using improved tracklist.add() --- mopidy/frontends/mpd/protocol/current_playlist.py | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/current_playlist.py b/mopidy/frontends/mpd/protocol/current_playlist.py index 69e04d4b..81df2827 100644 --- a/mopidy/frontends/mpd/protocol/current_playlist.py +++ b/mopidy/frontends/mpd/protocol/current_playlist.py @@ -57,14 +57,8 @@ def addid(context, uri, songpos=None): raise MpdNoExistError('No such song', command='addid') if songpos and songpos > context.core.tracklist.length.get(): raise MpdArgError('Bad song index', command='addid') - first_tl_track = None - for track in tracks: - tl_track = context.core.tracklist.add(track, at_position=songpos).get() - if songpos is not None: - songpos += 1 - if first_tl_track is None: - first_tl_track = tl_track - return ('Id', first_tl_track.tlid) + tl_tracks = context.core.tracklist.add(tracks, at_position=songpos).get() + return ('Id', tl_tracks[0].tlid) @handle_request(r'^delete "(?P\d+):(?P\d+)*"$')