diff --git a/mopidy/mpd/protocol/current_playlist.py b/mopidy/mpd/protocol/current_playlist.py index ea815c6a..e406f2ca 100644 --- a/mopidy/mpd/protocol/current_playlist.py +++ b/mopidy/mpd/protocol/current_playlist.py @@ -90,7 +90,7 @@ def delete(context, position): if not tl_tracks: raise exceptions.MpdArgError('Bad song index', command='delete') for (tlid, _) in tl_tracks: - context.core.tracklist.remove(tlid=[tlid]) + context.core.tracklist.remove({'tlid': [tlid]}) @protocol.commands.add('deleteid', tlid=protocol.UINT) @@ -102,7 +102,7 @@ def deleteid(context, tlid): Deletes the song ``SONGID`` from the playlist """ - tl_tracks = context.core.tracklist.remove(tlid=[tlid]).get() + tl_tracks = context.core.tracklist.remove({'tlid': [tlid]}).get() if not tl_tracks: raise exceptions.MpdNoExistError('No such song') @@ -147,7 +147,7 @@ def moveid(context, tlid, to): the playlist. If ``TO`` is negative, it is relative to the current song in the playlist (if there is one). """ - tl_tracks = context.core.tracklist.filter(tlid=[tlid]).get() + tl_tracks = context.core.tracklist.filter({'tlid': [tlid]}).get() if not tl_tracks: raise exceptions.MpdNoExistError('No such song') position = context.core.tracklist.index(tl_tracks[0]).get() @@ -185,7 +185,7 @@ def playlistfind(context, tag, needle): - does not add quotes around the tag. """ if tag == 'filename': - tl_tracks = context.core.tracklist.filter(uri=[needle]).get() + tl_tracks = context.core.tracklist.filter({'uri': [needle]}).get() if not tl_tracks: return None position = context.core.tracklist.index(tl_tracks[0]).get() @@ -204,7 +204,7 @@ def playlistid(context, tlid=None): and specifies a single song to display info for. """ if tlid is not None: - tl_tracks = context.core.tracklist.filter(tlid=[tlid]).get() + tl_tracks = context.core.tracklist.filter({'tlid': [tlid]}).get() if not tl_tracks: raise exceptions.MpdNoExistError('No such song') position = context.core.tracklist.index(tl_tracks[0]).get() @@ -370,8 +370,8 @@ def swapid(context, tlid1, tlid2): Swaps the positions of ``SONG1`` and ``SONG2`` (both song ids). """ - tl_tracks1 = context.core.tracklist.filter(tlid=[tlid1]).get() - tl_tracks2 = context.core.tracklist.filter(tlid=[tlid2]).get() + tl_tracks1 = context.core.tracklist.filter({'tlid': [tlid1]}).get() + tl_tracks2 = context.core.tracklist.filter({'tlid': [tlid2]}).get() if not tl_tracks1 or not tl_tracks2: raise exceptions.MpdNoExistError('No such song') position1 = context.core.tracklist.index(tl_tracks1[0]).get() diff --git a/mopidy/mpd/protocol/music_db.py b/mopidy/mpd/protocol/music_db.py index 83dab871..0e59706f 100644 --- a/mopidy/mpd/protocol/music_db.py +++ b/mopidy/mpd/protocol/music_db.py @@ -6,6 +6,7 @@ import warnings from mopidy.models import Track from mopidy.mpd import exceptions, protocol, translator +from mopidy.utils import deprecation _SEARCH_MAPPING = { 'album': 'album', @@ -142,7 +143,8 @@ def find(context, *args): except ValueError: return - results = context.core.library.search(query=query, exact=True).get() + with deprecation.ignore('core.library.search:empty_query'): + results = context.core.library.search(query=query, exact=True).get() result_tracks = [] if ('artist' not in query and 'albumartist' not in query and @@ -422,7 +424,8 @@ def search(context, *args): query = _query_from_mpd_search_parameters(args, _SEARCH_MAPPING) except ValueError: return - results = context.core.library.search(query).get() + with deprecation.ignore('core.library.search:empty_query'): + results = context.core.library.search(query).get() artists = [_artist_as_track(a) for a in _get_artists(results)] albums = [_album_as_track(a) for a in _get_albums(results)] tracks = _get_tracks(results) diff --git a/mopidy/mpd/protocol/playback.py b/mopidy/mpd/protocol/playback.py index 6beb4277..a537819c 100644 --- a/mopidy/mpd/protocol/playback.py +++ b/mopidy/mpd/protocol/playback.py @@ -217,7 +217,7 @@ def playid(context, tlid): """ if tlid == -1: return _play_minus_one(context) - tl_tracks = context.core.tracklist.filter(tlid=[tlid]).get() + tl_tracks = context.core.tracklist.filter({'tlid': [tlid]}).get() if not tl_tracks: raise exceptions.MpdNoExistError('No such song') return context.core.playback.play(tl_tracks[0]).get()