andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Test and implement mpris.CanSeek property

Browse Source
This commit is contained in:
Stein Magnus Jodal 2011-06-20 14:26:10 +03:00
parent c8bc52b4c6
commit 7c2d3cd541
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
mopidy/frontends/mpris.py
View File

@ -155,8 +155,7 @@ class MprisObject(dbus.service.Object):
'CanPlay': (False, None), 'CanPlay': (False, None),
# TODO True if CanControl and backend.playback.current_track # TODO True if CanControl and backend.playback.current_track
'CanPause': (False, None), 'CanPause': (False, None),
# TODO Set to True when the rest is implemented 'CanSeek': (self.get_CanSeek, None),
'CanSeek': (False, None),
'CanControl': (self.get_CanControl, None), 'CanControl': (self.get_CanControl, None),
} }
@ -398,6 +397,13 @@ class MprisObject(dbus.service.Object):
def get_Position(self): def get_Position(self):
return self.backend.playback.time_position.get() * 1000 return self.backend.playback.time_position.get() * 1000
def get_CanSeek(self):
if not self.get_CanControl():
return False
# XXX Should be changed to vary based on capabilities of the current
# track if Mopidy starts supporting non-seekable media, like streams.
return True
def get_CanControl(self): def get_CanControl(self):
# TODO This could be a setting for the end user to change. # TODO This could be a setting for the end user to change.
return True return True

10
tests/frontends/mpris/player_interface_test.py
View File

@ -177,6 +177,16 @@ class PlayerInterfaceTest(unittest.TestCase):
result = self.mpris.Get(mpris.PLAYER_IFACE, 'MaximumRate') result = self.mpris.Get(mpris.PLAYER_IFACE, 'MaximumRate')
self.assert_(result >= 1.0) self.assert_(result >= 1.0)
def test_can_seek_is_true_if_can_control_is_true(self):
self.mpris.get_CanControl = lambda *_: True
result = self.mpris.Get(mpris.PLAYER_IFACE, 'CanSeek')
self.assertTrue(result)
def test_can_seek_is_false_if_can_control_is_false(self):
self.mpris.get_CanControl = lambda *_: False
result = self.mpris.Get(mpris.PLAYER_IFACE, 'CanSeek')
self.assertFalse(result)
def test_can_control_is_true(self): def test_can_control_is_true(self):
result = self.mpris.Get(mpris.PLAYER_IFACE, 'CanControl') result = self.mpris.Get(mpris.PLAYER_IFACE, 'CanControl')
self.assertTrue(result) self.assertTrue(result)