ext: Add both dist_name and ext_name to Extension class

This commit is contained in:
Stein Magnus Jodal 2013-04-02 12:04:03 +02:00
parent f80f9d878e
commit 7d78d02d59
11 changed files with 32 additions and 13 deletions

View File

@ -234,7 +234,8 @@ meaningful defaults blank, like ``username`` and ``password``.
class Extension(ext.Extension):
name = 'Mopidy-Soundspot'
dist_name = 'Mopidy-Soundspot'
ext_name = 'soundspot'
version = __version__
def get_default_config(self):

View File

@ -145,18 +145,25 @@ def load_extensions():
extension = extension_class()
if entry_point.name != extension.ext_name:
logger.warning(
'Disabled extension %(ep)s: entry point name (%(ep)s) '
'does not match extension name (%(ext)s)',
{'ep': entry_point.name, 'ext': extension.ext_name})
continue
# TODO Validate configuration
try:
extension.validate_environment()
except exceptions.ExtensionError as ex:
logger.info(
'Disabled extension: %s (%s)', extension.name, ex.message)
'Disabled extension %s: %s', entry_point.name, ex.message)
continue
logger.info(
'Loaded extension %s: %s %s',
entry_point.name, extension.name, extension.version)
entry_point.name, extension.dist_name, extension.version)
extensions.append(extension)
return extensions

View File

@ -46,7 +46,8 @@ None
class Extension(ext.Extension):
name = 'Mopidy-Local'
dist_name = 'Mopidy-Local'
ext_name = 'local'
version = mopidy.__version__
def get_default_config(self):

View File

@ -67,7 +67,8 @@ https://github.com/mopidy/mopidy/issues?labels=Spotify+backend
class Extension(ext.Extension):
name = 'Mopidy-Spotify'
dist_name = 'Mopidy-Spotify'
ext_name = 'spotify'
version = mopidy.__version__
def get_default_config(self):

View File

@ -45,7 +45,8 @@ None
class Extension(ext.Extension):
name = 'Mopidy-Stream'
dist_name = 'Mopidy-Stream'
ext_name = 'stream'
version = mopidy.__version__
def get_default_config(self):

View File

@ -5,7 +5,8 @@ from mopidy.utils import config
class Extension(object):
name = None
dist_name = None
ext_name = None
version = None
def get_default_config(self):

View File

@ -519,7 +519,8 @@ Example to get started with
class Extension(ext.Extension):
name = 'Mopidy-HTTP'
dist_name = 'Mopidy-HTTP'
ext_name = 'http'
version = mopidy.__version__
def get_default_config(self):

View File

@ -44,7 +44,8 @@ The frontend is enabled by default if all dependencies are available.
class Extension(ext.Extension):
name = 'Mopidy-Lastfm'
dist_name = 'Mopidy-Lastfm'
ext_name = 'lastfm'
version = mopidy.__version__
def get_default_config(self):

View File

@ -88,7 +88,8 @@ near future:
class Extension(ext.Extension):
name = 'Mopidy-MPD'
dist_name = 'Mopidy-MPD'
ext_name = 'mpd'
version = mopidy.__version__
def get_default_config(self):

View File

@ -70,7 +70,8 @@ Now you can control Mopidy through the player object. Examples:
class Extension(ext.Extension):
name = 'Mopidy-MPRIS'
dist_name = 'Mopidy-MPRIS'
ext_name = 'mpris'
version = mopidy.__version__
def get_default_config(self):

View File

@ -10,8 +10,11 @@ class ExtensionTest(unittest.TestCase):
def setUp(self):
self.ext = Extension()
def test_name_is_none(self):
self.assertIsNone(self.ext.name)
def test_dist_name_is_none(self):
self.assertIsNone(self.ext.dist_name)
def test_ext_name_is_none(self):
self.assertIsNone(self.ext.ext_name)
def test_version_is_none(self):
self.assertIsNone(self.ext.version)