From 80852f38543c876457ffa9af79055be8c2bd88e7 Mon Sep 17 00:00:00 2001 From: Thomas Adamcik Date: Sun, 14 Feb 2010 15:45:17 +0100 Subject: [PATCH] Ensure that volume returned is int --- mopidy/backends/gstreamer.py | 2 +- tests/backends/basetests.py | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/mopidy/backends/gstreamer.py b/mopidy/backends/gstreamer.py index 00d140fd..77dbc306 100644 --- a/mopidy/backends/gstreamer.py +++ b/mopidy/backends/gstreamer.py @@ -98,7 +98,7 @@ class GStreamerPlaybackController(BasePlaybackController): @property def volume(self): - return self.bin.get_property('volume') * 100 + return int(self.bin.get_property('volume') * 100) @volume.setter def volume(self, value): diff --git a/tests/backends/basetests.py b/tests/backends/basetests.py index 60e9f328..6c1f4bc2 100644 --- a/tests/backends/basetests.py +++ b/tests/backends/basetests.py @@ -431,6 +431,13 @@ class BasePlaybackControllerTest(object): self.playback.volume = 0 self.assertEqual(self.playback.volume, 0) + def test_volume_is_not_float(self): + if not self.supports_volume: + return + + self.playback.volume = 1.0 / 3 * 100 + self.assertEqual(self.playback.volume, 33) + def test_play_with_consume(self): raise NotImplementedError