Review cleanup.

This commit is contained in:
Thomas Adamcik 2012-09-05 20:48:00 +02:00
parent 562c25043a
commit 8c038bbae6
5 changed files with 8 additions and 8 deletions

View File

@ -43,7 +43,7 @@ class SpotifyPlaybackProvider(BasePlaybackProvider):
return result
def get_volume(self):
return self.backend.gstreamer.get_volume()
return self.backend.gstreamer.get_volume().get()
def set_volume(self, volume):
self.backend.gstreamer.set_volume(volume)

View File

@ -44,8 +44,8 @@ class GStreamer(ThreadingActor):
self._setup_pipeline()
self._setup_output(output or settings.OUTPUT)
self._setup_mixer(mixer or settings.MIXER,
mixer_track or settings.MIXER_TRACK)
self._setup_mixer(
mixer or settings.MIXER, mixer_track or settings.MIXER_TRACK)
self._setup_message_processor()
def _setup_pipeline(self):

View File

@ -31,10 +31,10 @@ class AutoAudioMixer(gst.Bin):
factories.sort(key=lambda f: (-f.get_rank(), f.get_name()))
for factory in factories:
# Avoid sink/srcs that implment mixing.
# Avoid sink/srcs that implement mixing.
if factory.get_klass() != 'Generic/Audio':
continue
# Avoid anything that doesn't implment mixing.
# Avoid anything that doesn't implement mixing.
elif not factory.has_interface('GstMixer'):
continue
@ -69,4 +69,4 @@ class AutoAudioMixer(gst.Bin):
gobject.type_register(AutoAudioMixer)
gst.element_register (AutoAudioMixer, 'autoaudiomixer', gst.RANK_MARGINAL)
gst.element_register(AutoAudioMixer, 'autoaudiomixer', gst.RANK_MARGINAL)

View File

@ -77,4 +77,4 @@ class FakeMixer(gst.Element, gst.ImplementsInterface, gst.interfaces.Mixer):
gobject.type_register(FakeMixer)
gst.element_register (FakeMixer, 'fakemixer', gst.RANK_MARGINAL)
gst.element_register(FakeMixer, 'fakemixer', gst.RANK_MARGINAL)

View File

@ -152,7 +152,7 @@ def validate_settings(defaults, settings):
elif setting == 'OUTPUTS':
errors[setting] = (
u'Deprecated setting, please change to OUTPUT. OUTPUT expectes '
u'Deprecated setting, please change to OUTPUT. OUTPUT expects '
u'a GStreamer bin description string for your desired output.')
elif setting == 'SPOTIFY_BITRATE':