From 8f1b98b30652ee1a764d14473f159a07d052e139 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Tue, 20 Nov 2012 22:36:39 +0100 Subject: [PATCH] core: Don't fail when adding tracks after end of tracklist --- mopidy/core/tracklist.py | 3 --- tests/backends/base/tracklist.py | 8 +++++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/mopidy/core/tracklist.py b/mopidy/core/tracklist.py index 0337828c..656e15b1 100644 --- a/mopidy/core/tracklist.py +++ b/mopidy/core/tracklist.py @@ -78,9 +78,6 @@ class TracklistController(object): :type at_position: int or :class:`None` :rtype: list of :class:`mopidy.models.TlTrack` """ - assert at_position is None or at_position <= len(self._tl_tracks), \ - 'at_position can not be greater than tracklist length' - tl_tracks = [] for track in tracks: tl_track = TlTrack(self._next_tlid, track) diff --git a/tests/backends/base/tracklist.py b/tests/backends/base/tracklist.py index 09b2b6a6..71f44018 100644 --- a/tests/backends/base/tracklist.py +++ b/tests/backends/base/tracklist.py @@ -50,9 +50,11 @@ class TracklistControllerTest(object): @populate_tracklist def test_add_at_position_outside_of_playlist(self): - test = lambda: self.controller.add( - self.tracks[0], len(self.tracks) + 2) - self.assertRaises(AssertionError, test) + for track in self.tracks: + tl_tracks = self.controller.add([track], len(self.tracks) + 2) + self.assertEqual(track, self.controller.tracks[-1]) + self.assertEqual(tl_tracks[0], self.controller.tl_tracks[-1]) + self.assertEqual(track, tl_tracks[0].track) @populate_tracklist def test_filter_by_tlid(self):