andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Check if failure instead of chacking for success when setting GStreamer state

Browse Source
This commit is contained in:
Stein Magnus Jodal 2010-08-14 17:24:06 +02:00
parent 473c31fec8
commit 97ff6bf042
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mopidy/outputs/gstreamer.py
View File

@ -159,15 +159,14 @@ class GStreamerProcess(BaseProcess):
:type state_name: string :type state_name: string
:rtype: :class:`True` or :class:`False` :rtype: :class:`True` or :class:`False`
""" """
# XXX Setting state to PLAYING often returns False even if it works
result = self.gst_pipeline.set_state( result = self.gst_pipeline.set_state(
getattr(gst, 'STATE_' + state_name)) getattr(gst, 'STATE_' + state_name))
if result == gst.STATE_CHANGE_SUCCESS: if result == gst.STATE_CHANGE_FAILURE:
logger.debug('Setting GStreamer state to %s: OK', state_name)
return True
else:
logger.warning('Setting GStreamer state to %s: failed', state_name) logger.warning('Setting GStreamer state to %s: failed', state_name)
return False return False
else:
logger.debug('Setting GStreamer state to %s: OK', state_name)
return True
def get_volume(self): def get_volume(self):
"""Get volume in range [0..100]""" """Get volume in range [0..100]"""