Report multiple settings errors at once

This commit is contained in:
Stein Magnus Jodal 2010-08-17 01:58:31 +02:00
parent a8c736110f
commit 9cb84002bc
2 changed files with 8 additions and 3 deletions

View File

@ -83,17 +83,17 @@ def validate_settings(defaults, settings):
else:
errors[setting] = u'Deprecated setting. Use %s.' % (
changed[setting],)
break
continue
if setting == 'BACKENDS':
if 'mopidy.backends.despotify.DespotifyBackend' in value:
errors[setting] = (u'Deprecated setting value. ' +
'"mopidy.backends.despotify.DespotifyBackend" is no ' +
'longer available.')
break
continue
if setting not in defaults:
errors[setting] = u'Unknown setting. Is it misspelled?'
break
continue
return errors

View File

@ -38,3 +38,8 @@ class ValidateSettingsTest(unittest.TestCase):
u'Deprecated setting value. ' +
'"mopidy.backends.despotify.DespotifyBackend" is no longer ' +
'available.')
def test_two_errors_are_both_reported(self):
result = validate_settings(self.defaults,
{'FOO': '', 'BAR': ''})
self.assertEquals(len(result), 2)