andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update on_received to handle that decode can fail

Browse Source
This commit is contained in:
Thomas Adamcik 2011-07-25 01:24:19 +02:00
parent 68c947ddf2
commit 9fe4674b36
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mopidy/utils/network.py
View File

@ -323,7 +323,8 @@ class LineProtocol(ThreadingActor):
for line in self.parse_lines():
line = self.decode(line)
self.on_line_received(line)
if line is not None:
self.on_line_received(line)
self.connection.enable_timeout()

9
tests/utils/network/lineprotocol_test.py
View File

@ -74,6 +74,15 @@ class LineProtocolTest(unittest.TestCase):
network.LineProtocol.on_receive(self.mock, {'received': 'data\n'})
self.mock.on_line_received.assert_called_once_with(sentinel.decoded)
def test_on_receive_with_new_line_with_failed_decode(self):
self.mock.connection = Mock(spec=network.Connection)
self.mock.recv_buffer = ''
self.mock.parse_lines.return_value = [sentinel.line]
self.mock.decode.return_value = None
network.LineProtocol.on_receive(self.mock, {'received': 'data\n'})
self.assertEqual(0, self.mock.on_line_received.call_count)
def test_on_receive_with_new_lines_calls_on_recieve(self):
self.mock.connection = Mock(spec=network.Connection)
self.mock.recv_buffer = ''