andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

log: Don't disable loggers when loading fileConfig

Browse Source 
The default when loading config for logging from a file is to disable
existing loggers. Since some loggers are created before logging is set
up, these loggers were disabled if logging/config_file is set.

(cherry picked from commit cb0387c46d)

Conflicts:
	docs/changelog.rst
This commit is contained in:
Trygve Aaberge 2014-08-11 01:31:25 +02:00 committed by Stein Magnus Jodal
parent 9b7bcd37b3
commit bac3bfb7a2
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/changelog.rst
View File

@ -14,6 +14,9 @@ Bug fix release.
arguments. This was incorrectly returning artists after the MPD command arguments. This was incorrectly returning artists after the MPD command
changes in 0.19.0. (Fixes: :issue:`817`) changes in 0.19.0. (Fixes: :issue:`817`)
- Logging: Fix that some loggers would be disabled if logging/config_file was
set.
v0.19.3 (2014-08-03) v0.19.3 (2014-08-03)
==================== ====================

3
mopidy/utils/log.py
View File

@ -47,7 +47,8 @@ def setup_logging(config, verbosity_level, save_debug_log):
if config['logging']['config_file']: if config['logging']['config_file']:
# Logging config from file must be read before other handlers are # Logging config from file must be read before other handlers are
# added. If not, the other handlers will have no effect. # added. If not, the other handlers will have no effect.
logging.config.fileConfig(config['logging']['config_file']) logging.config.fileConfig(config['logging']['config_file'],
disable_existing_loggers=False)
setup_console_logging(config, verbosity_level) setup_console_logging(config, verbosity_level)
if save_debug_log: if save_debug_log: