diff --git a/tests/mixers/denon_test.py b/tests/mixers/denon_test.py index f0806604..82e813e9 100644 --- a/tests/mixers/denon_test.py +++ b/tests/mixers/denon_test.py @@ -1,6 +1,7 @@ import unittest from mopidy.mixers.denon import DenonMixer +from tests.mixers.dummy_test import BaseMixerTest class DenonMixerDeviceMock(object): def __init__(self): @@ -23,27 +24,15 @@ class DenonMixerDeviceMock(object): def open(self): self._open = True -class DenonMixerTest(unittest.TestCase): +class DenonMixerTest(BaseMixerTest): + ACTUAL_MAX = 99 + + INITIAL = 1 + def setUp(self): self.device = DenonMixerDeviceMock() self.mixer = DenonMixer(device=self.device) - def test_volume_set_to_min(self): - self.mixer.volume = 0 - self.assertEqual(self.mixer.volume, 0) - - def test_volume_set_to_max(self): - self.mixer.volume = 100 - self.assertEqual(self.mixer.volume, 99) - - def test_volume_set_to_below_min_results_in_min(self): - self.mixer.volume = -10 - self.assertEqual(self.mixer.volume, 0) - - def test_volume_set_to_above_max_results_in_max(self): - self.mixer.volume = 110 - self.assertEqual(self.mixer.volume, 99) - def test_reopen_device(self): self.device._open = False self.mixer.volume = 10 diff --git a/tests/mixers/dummy_test.py b/tests/mixers/dummy_test.py index 742bccf3..35944e14 100644 --- a/tests/mixers/dummy_test.py +++ b/tests/mixers/dummy_test.py @@ -9,11 +9,13 @@ class BaseMixerTest(unittest.TestCase): ACTUAL_MIN = MIN ACTUAL_MAX = MAX + INITIAL = None + def setUp(self): self.mixer = DummyMixer() - def test_volume_is_None_initially(self): - self.assertEqual(self.mixer.volume, None) + def test_initial_volume(self): + self.assertEqual(self.mixer.volume, self.INITIAL) def test_volume_set_to_min(self): self.mixer.volume = self.MIN