From 18eec035b5a76f6dbf6a945ddbe389478fc3d877 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 18:12:01 +0100 Subject: [PATCH 01/65] Add Pykka as dependency --- docs/installation/index.rst | 2 ++ requirements/core.txt | 1 + 2 files changed, 3 insertions(+) create mode 100644 requirements/core.txt diff --git a/docs/installation/index.rst b/docs/installation/index.rst index 56f0015b..19016ce9 100644 --- a/docs/installation/index.rst +++ b/docs/installation/index.rst @@ -25,6 +25,8 @@ Otherwise, make sure you got the required dependencies installed. - Python >= 2.6, < 3 +- `Pykka `_ >= 0.9.1 + - GStreamer >= 0.10, with Python bindings. See :doc:`gstreamer`. - Mixer dependencies: The default mixer does not require any additional diff --git a/requirements/core.txt b/requirements/core.txt new file mode 100644 index 00000000..54781a3b --- /dev/null +++ b/requirements/core.txt @@ -0,0 +1 @@ +Pykka >= 0.9.1 From 9fc7e013ff25e971aaa964d8aeaf55ed06936c1a Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 20:11:34 +0100 Subject: [PATCH 02/65] Move main() into mopidy.core --- bin/mopidy | 2 +- mopidy/__main__.py | 13 +++---------- mopidy/core.py | 5 +++++ 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/bin/mopidy b/bin/mopidy index 0472518e..aabf21d3 100755 --- a/bin/mopidy +++ b/bin/mopidy @@ -1,5 +1,5 @@ #! /usr/bin/env python if __name__ == '__main__': - from mopidy.__main__ import main + from mopidy.core import main main() diff --git a/mopidy/__main__.py b/mopidy/__main__.py index 20e78f5a..169c2754 100644 --- a/mopidy/__main__.py +++ b/mopidy/__main__.py @@ -1,17 +1,10 @@ -import os -import sys - # Add ../ to the path so we can run Mopidy from a Git checkout without # installing it on the system. +import os +import sys sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '../'))) -from mopidy.core import CoreProcess - -def main(): - # Explictly call run() instead of start(), since we don't need to start - # another process. - CoreProcess().run() - if __name__ == '__main__': + from mopidy.core import main main() diff --git a/mopidy/core.py b/mopidy/core.py index 56febe5b..f56bb334 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -12,6 +12,11 @@ from mopidy.utils.settings import list_settings_optparse_callback logger = logging.getLogger('mopidy.core') +def main(): + # Explictly call run() instead of start(), since we don't need to start + # another process. + CoreProcess().run() + class CoreProcess(BaseThread): def __init__(self): self.core_queue = multiprocessing.Queue() From 0acaa8f2853bda3f2d3ebe3b161978c84c3537ca Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 21:33:53 +0100 Subject: [PATCH 03/65] Log startup message directly from setup_logging --- mopidy/utils/log.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mopidy/utils/log.py b/mopidy/utils/log.py index cc1c19c1..c74ff5ea 100644 --- a/mopidy/utils/log.py +++ b/mopidy/utils/log.py @@ -1,13 +1,15 @@ import logging import logging.handlers -from mopidy import settings +from mopidy import get_version, settings def setup_logging(verbosity_level, save_debug_log): setup_root_logger() setup_console_logging(verbosity_level) if save_debug_log: setup_debug_logging_to_file() + logger = logging.getLogger('mopidy.utils.log') + logger.info(u'-- Starting Mopidy %s --', get_version()) def setup_root_logger(): root = logging.getLogger('') From 4749e77f1dd6dd51a8b03ff80de2100fc9fa569a Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 21:34:38 +0100 Subject: [PATCH 04/65] Replace CoreProcess with simple setup functions --- mopidy/core.py | 148 ++++++++++++++++--------------------------------- 1 file changed, 49 insertions(+), 99 deletions(-) diff --git a/mopidy/core.py b/mopidy/core.py index f56bb334..ab457a00 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -3,117 +3,67 @@ import multiprocessing import optparse import sys +from pykka.actor import ThreadingActor + from mopidy import get_version, settings, OptionalDependencyError from mopidy.utils import get_class from mopidy.utils.log import setup_logging from mopidy.utils.path import get_or_create_folder, get_or_create_file -from mopidy.utils.process import BaseThread, GObjectEventThread +from mopidy.utils.process import GObjectEventThread from mopidy.utils.settings import list_settings_optparse_callback logger = logging.getLogger('mopidy.core') def main(): - # Explictly call run() instead of start(), since we don't need to start - # another process. - CoreProcess().run() + options = parse_options() + setup_logging(options.verbosity_level, options.save_debug_log) + setup_settings() + setup_gobject_loop() + setup_output() + setup_backend() + setup_frontends() -class CoreProcess(BaseThread): - def __init__(self): - self.core_queue = multiprocessing.Queue() - super(CoreProcess, self).__init__(self.core_queue) - self.name = 'CoreProcess' - self.options = self.parse_options() - self.gobject_loop = None - self.output = None - self.backend = None - self.frontends = [] +def parse_options(): + parser = optparse.OptionParser(version='Mopidy %s' % get_version()) + parser.add_option('-q', '--quiet', + action='store_const', const=0, dest='verbosity_level', + help='less output (warning level)') + parser.add_option('-v', '--verbose', + action='store_const', const=2, dest='verbosity_level', + help='more output (debug level)') + parser.add_option('--save-debug-log', + action='store_true', dest='save_debug_log', + help='save debug log to "./mopidy.log"') + parser.add_option('--list-settings', + action='callback', callback=list_settings_optparse_callback, + help='list current settings') + return parser.parse_args()[0] - def parse_options(self): - parser = optparse.OptionParser(version='Mopidy %s' % get_version()) - parser.add_option('-q', '--quiet', - action='store_const', const=0, dest='verbosity_level', - help='less output (warning level)') - parser.add_option('-v', '--verbose', - action='store_const', const=2, dest='verbosity_level', - help='more output (debug level)') - parser.add_option('--save-debug-log', - action='store_true', dest='save_debug_log', - help='save debug log to "./mopidy.log"') - parser.add_option('--list-settings', - action='callback', callback=list_settings_optparse_callback, - help='list current settings') - return parser.parse_args()[0] +def setup_settings(): + get_or_create_folder('~/.mopidy/') + get_or_create_file('~/.mopidy/settings.py') + settings.validate() - def run_inside_try(self): - self.setup() - while True: - message = self.core_queue.get() - self.process_message(message) +def setup_gobject_loop(): + gobject_loop = GObjectEventThread() + gobject_loop.start() + return gobject_loop - def setup(self): - self.setup_logging() - self.setup_settings() - self.gobject_loop = self.setup_gobject_loop(self.core_queue) - self.output = self.setup_output(self.core_queue) - self.backend = self.setup_backend(self.core_queue, self.output) - self.frontends = self.setup_frontends(self.core_queue, self.backend) +def setup_output(): + output = get_class(settings.OUTPUT)() + output.start() + return output - def setup_logging(self): - setup_logging(self.options.verbosity_level, - self.options.save_debug_log) - logger.info(u'-- Starting Mopidy %s --', get_version()) +def setup_backend(): + return get_class(settings.BACKENDS[0])() - def setup_settings(self): - get_or_create_folder('~/.mopidy/') - get_or_create_file('~/.mopidy/settings.py') - settings.validate() - - def setup_gobject_loop(self, core_queue): - gobject_loop = GObjectEventThread(core_queue) - gobject_loop.start() - return gobject_loop - - def setup_output(self, core_queue): - output = get_class(settings.OUTPUT)(core_queue) - output.start() - return output - - def setup_backend(self, core_queue, output): - return get_class(settings.BACKENDS[0])(core_queue, output) - - def setup_frontends(self, core_queue, backend): - frontends = [] - for frontend_class_name in settings.FRONTENDS: - try: - frontend = get_class(frontend_class_name)(core_queue, backend) - frontend.start() - frontends.append(frontend) - except OptionalDependencyError as e: - logger.info(u'Disabled: %s (%s)', frontend_class_name, e) - return frontends - - def process_message(self, message): - if message.get('to') == 'core': - self.process_message_to_core(message) - elif message.get('to') == 'output': - self.output.process_message(message) - elif message.get('to') == 'frontend': - for frontend in self.frontends: - frontend.process_message(message) - elif message['command'] == 'end_of_track': - self.backend.playback.on_end_of_track() - elif message['command'] == 'stop_playback': - self.backend.playback.stop() - elif message['command'] == 'set_stored_playlists': - self.backend.stored_playlists.playlists = message['playlists'] - else: - logger.warning(u'Cannot handle message: %s', message) - - def process_message_to_core(self, message): - assert message['to'] == 'core', u'Message recipient must be "core".' - if message['command'] == 'exit': - if message['reason'] is not None: - logger.info(u'Exiting (%s)', message['reason']) - sys.exit(message['status']) - else: - logger.warning(u'Cannot handle message: %s', message) +def setup_frontends(): + frontends = [] + for frontend_class_name in settings.FRONTENDS: + try: + frontend = get_class(frontend_class_name)() + frontend.start() + frontends.append(frontend) + except OptionalDependencyError as e: + logger.info(u'Disabled: %s (%s)', frontend_class_name, e) + return frontends From 9dafc6ebe982eea05a45f2f451b80269e860fc6a Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 21:35:14 +0100 Subject: [PATCH 05/65] Remove lifetime methods from output API --- mopidy/outputs/base.py | 27 --------------------------- mopidy/outputs/dummy.py | 18 ------------------ 2 files changed, 45 deletions(-) diff --git a/mopidy/outputs/base.py b/mopidy/outputs/base.py index 372d7d70..fbc86688 100644 --- a/mopidy/outputs/base.py +++ b/mopidy/outputs/base.py @@ -3,33 +3,6 @@ class BaseOutput(object): Base class for audio outputs. """ - def __init__(self, core_queue): - self.core_queue = core_queue - - def start(self): - """ - Start the output. - - *MAY be implemented by subclasses.* - """ - pass - - def destroy(self): - """ - Destroy the output. - - *MAY be implemented by subclasses.* - """ - pass - - def process_message(self, message): - """ - Process messages with the output as destination. - - *MUST be implemented by subclass.* - """ - raise NotImplementedError - def play_uri(self, uri): """ Play URI. diff --git a/mopidy/outputs/dummy.py b/mopidy/outputs/dummy.py index 060ee02f..738575f3 100644 --- a/mopidy/outputs/dummy.py +++ b/mopidy/outputs/dummy.py @@ -8,15 +8,6 @@ class DummyOutput(BaseOutput): # pylint: disable = R0902 # Too many instance attributes (9/7) - #: For testing. :class:`True` if :meth:`start` has been called. - start_called = False - - #: For testing. :class:`True` if :meth:`destroy` has been called. - destroy_called = False - - #: For testing. Contains all messages :meth:`process_message` has received. - messages = [] - #: For testing. Contains the last URI passed to :meth:`play_uri`. uri = None @@ -40,15 +31,6 @@ class DummyOutput(BaseOutput): #: For testing. Contains the current volume. volume = 100 - def start(self): - self.start_called = True - - def destroy(self): - self.destroy_called = True - - def process_message(self, message): - self.messages.append(message) - def play_uri(self, uri): self.uri = uri return True From 3d56188619b3b3d0549b58f4202cba8d400d9788 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 21:36:26 +0100 Subject: [PATCH 06/65] Convert GstreamerOutput to an actor --- mopidy/outputs/gstreamer.py | 181 +++++++----------------------------- 1 file changed, 36 insertions(+), 145 deletions(-) diff --git a/mopidy/outputs/gstreamer.py b/mopidy/outputs/gstreamer.py index 3b037f62..3fb58a2e 100644 --- a/mopidy/outputs/gstreamer.py +++ b/mopidy/outputs/gstreamer.py @@ -3,113 +3,37 @@ pygst.require('0.10') import gst import logging -import multiprocessing + +from pykka.actor import ThreadingActor from mopidy import settings from mopidy.outputs.base import BaseOutput -from mopidy.utils.process import (BaseThread, pickle_connection, - unpickle_connection) logger = logging.getLogger('mopidy.outputs.gstreamer') -class GStreamerOutput(BaseOutput): +class GStreamerOutput(ThreadingActor, BaseOutput): """ - Audio output through GStreamer. - - Starts :class:`GStreamerMessagesThread` and :class:`GStreamerPlayerThread`. + Audio output through `GStreamer `_. **Settings:** - :attr:`mopidy.settings.GSTREAMER_AUDIO_SINK` + """ - def __init__(self, *args, **kwargs): - super(GStreamerOutput, self).__init__(*args, **kwargs) - self.output_queue = multiprocessing.Queue() - self.player_thread = GStreamerPlayerThread(self.core_queue, - self.output_queue) - - def start(self): - self.player_thread.start() - - def destroy(self): - self.player_thread.destroy() - - def process_message(self, message): - assert message['to'] == 'output', \ - u'Message recipient must be "output".' - self.output_queue.put(message) - - def _send_recv(self, message): - (my_end, other_end) = multiprocessing.Pipe() - message['to'] = 'output' - message['reply_to'] = pickle_connection(other_end) - self.process_message(message) - my_end.poll(None) - return my_end.recv() - - def _send(self, message): - message['to'] = 'output' - self.process_message(message) - - def play_uri(self, uri): - return self._send_recv({'command': 'play_uri', 'uri': uri}) - - def deliver_data(self, capabilities, data): - return self._send({ - 'command': 'deliver_data', - 'caps': capabilities, - 'data': data, - }) - - def end_of_data_stream(self): - return self._send({'command': 'end_of_data_stream'}) - - def get_position(self): - return self._send_recv({'command': 'get_position'}) - - def set_position(self, position): - return self._send_recv({'command': 'set_position', - 'position': position}) - - def set_state(self, state): - return self._send_recv({'command': 'set_state', 'state': state}) - - def get_volume(self): - return self._send_recv({'command': 'get_volume'}) - - def set_volume(self, volume): - return self._send_recv({'command': 'set_volume', 'volume': volume}) - - -class GStreamerPlayerThread(BaseThread): - """ - A process for all work related to GStreamer. - - The main loop processes events from both Mopidy and GStreamer. - - This thread requires :class:`mopidy.utils.process.GObjectEventThread` to be - running too. This is not enforced in any way by the code. - - Make sure this subprocess is started by the MainThread in the top-most - parent process, and not some other thread. If not, we can get into the - problems described at - http://jameswestby.net/weblog/tech/14-caution-python-multiprocessing-and-glib-dont-mix.html. - """ - - def __init__(self, core_queue, output_queue): - super(GStreamerPlayerThread, self).__init__(core_queue) - self.name = u'GStreamerPlayerThread' - self.output_queue = output_queue + def __init__(self): self.gst_pipeline = None - def run_inside_try(self): - self.setup() - while True: - message = self.output_queue.get() - self.process_mopidy_message(message) + # XXX Run setup after actor starts? + self._setup_gstreamer() + + def _setup_gstreamer(self): + """ + **Warning:** :class:`GStreamerOutput` requires + :class:`mopidy.utils.process.GObjectEventThread` to be running. This is + not enforced by :class:`GStreamerOutput` itself. + """ - def setup(self): logger.debug(u'Setting up GStreamer pipeline') self.gst_pipeline = gst.parse_launch(' ! '.join([ @@ -122,7 +46,7 @@ class GStreamerPlayerThread(BaseThread): if settings.BACKENDS[0] == 'mopidy.backends.local.LocalBackend': uri_bin = gst.element_factory_make('uridecodebin', 'uri') - uri_bin.connect('pad-added', self.process_new_pad, pad) + uri_bin.connect('pad-added', self._process_new_pad, pad) self.gst_pipeline.add(uri_bin) else: app_src = gst.element_factory_make('appsrc', 'appsrc') @@ -141,45 +65,12 @@ class GStreamerPlayerThread(BaseThread): # Setup bus and message processor gst_bus = self.gst_pipeline.get_bus() gst_bus.add_signal_watch() - gst_bus.connect('message', self.process_gst_message) + gst_bus.connect('message', self._process_gstreamer_message) - def process_new_pad(self, source, pad, target_pad): + def _process_new_pad(self, source, pad, target_pad): pad.link(target_pad) - def process_mopidy_message(self, message): - """Process messages from the rest of Mopidy.""" - if message['command'] == 'play_uri': - response = self.play_uri(message['uri']) - connection = unpickle_connection(message['reply_to']) - connection.send(response) - elif message['command'] == 'deliver_data': - self.deliver_data(message['caps'], message['data']) - elif message['command'] == 'end_of_data_stream': - self.end_of_data_stream() - elif message['command'] == 'set_state': - response = self.set_state(message['state']) - connection = unpickle_connection(message['reply_to']) - connection.send(response) - elif message['command'] == 'get_volume': - volume = self.get_volume() - connection = unpickle_connection(message['reply_to']) - connection.send(volume) - elif message['command'] == 'set_volume': - response = self.set_volume(message['volume']) - connection = unpickle_connection(message['reply_to']) - connection.send(response) - elif message['command'] == 'set_position': - response = self.set_position(message['position']) - connection = unpickle_connection(message['reply_to']) - connection.send(response) - elif message['command'] == 'get_position': - response = self.get_position() - connection = unpickle_connection(message['reply_to']) - connection.send(response) - else: - logger.warning(u'Cannot handle message: %s', message) - - def process_gst_message(self, bus, message): + def _process_gstreamer_message(self, bus, message): """Process messages from GStreamer.""" if message.type == gst.MESSAGE_EOS: logger.debug(u'GStreamer signalled end-of-stream. ' @@ -189,7 +80,7 @@ class GStreamerPlayerThread(BaseThread): self.set_state('NULL') error, debug = message.parse_error() logger.error(u'%s %s', error, debug) - # FIXME Should we send 'stop_playback' to core here? Can we + # FIXME Should we send 'stop_playback' to the backend here? Can we # differentiate on how serious the error is? def play_uri(self, uri): @@ -198,7 +89,7 @@ class GStreamerPlayerThread(BaseThread): self.gst_pipeline.get_by_name('uri').set_property('uri', uri) return self.set_state('PLAYING') - def deliver_data(self, caps_string, data): + def deliver_data(self, capabilities, data): """Deliver audio data to be played""" app_src = self.gst_pipeline.get_by_name('appsrc') caps = gst.caps_from_string(caps_string) @@ -216,6 +107,21 @@ class GStreamerPlayerThread(BaseThread): """ self.gst_pipeline.get_by_name('appsrc').emit('end-of-stream') + def get_position(self): + try: + position = self.gst_pipeline.query_position(gst.FORMAT_TIME)[0] + return position // gst.MSECOND + except gst.QueryError, e: + logger.error('time_position failed: %s', e) + return 0 + + def set_position(self, position): + self.gst_pipeline.get_state() # block until state changes are done + handeled = self.gst_pipeline.seek_simple(gst.Format(gst.FORMAT_TIME), + gst.SEEK_FLAG_FLUSH, position * gst.MSECOND) + self.gst_pipeline.get_state() # block until seek is done + return handeled + def set_state(self, state_name): """ Set the GStreamer state. Returns :class:`True` if successful. @@ -252,18 +158,3 @@ class GStreamerPlayerThread(BaseThread): gst_volume = self.gst_pipeline.get_by_name('volume') gst_volume.set_property('volume', volume / 100.0) return True - - def set_position(self, position): - self.gst_pipeline.get_state() # block until state changes are done - handeled = self.gst_pipeline.seek_simple(gst.Format(gst.FORMAT_TIME), - gst.SEEK_FLAG_FLUSH, position * gst.MSECOND) - self.gst_pipeline.get_state() # block until seek is done - return handeled - - def get_position(self): - try: - position = self.gst_pipeline.query_position(gst.FORMAT_TIME)[0] - return position // gst.MSECOND - except gst.QueryError, e: - logger.error('time_position failed: %s', e) - return 0 From 3a1de6578df2c93222abdf0bc4ded3af8a724946 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 21:37:55 +0100 Subject: [PATCH 07/65] Remove unused BaseProcess and strip queue stuff from BaseThread --- mopidy/utils/process.py | 53 +++-------------------------------------- 1 file changed, 3 insertions(+), 50 deletions(-) diff --git a/mopidy/utils/process.py b/mopidy/utils/process.py index 11dafa8a..7a5ba62f 100644 --- a/mopidy/utils/process.py +++ b/mopidy/utils/process.py @@ -1,8 +1,5 @@ import logging -import multiprocessing import multiprocessing.dummy -from multiprocessing.reduction import reduce_connection -import pickle import gobject gobject.threads_init() @@ -11,52 +8,10 @@ from mopidy import SettingsError logger = logging.getLogger('mopidy.utils.process') -def pickle_connection(connection): - return pickle.dumps(reduce_connection(connection)) - -def unpickle_connection(pickled_connection): - # From http://stackoverflow.com/questions/1446004 - (func, args) = pickle.loads(pickled_connection) - return func(*args) - -class BaseProcess(multiprocessing.Process): - def __init__(self, core_queue): - super(BaseProcess, self).__init__() - self.core_queue = core_queue - - def run(self): - logger.debug(u'%s: Starting process', self.name) - try: - self.run_inside_try() - except KeyboardInterrupt: - logger.info(u'Interrupted by user') - self.exit(0, u'Interrupted by user') - except SettingsError as e: - logger.error(e.message) - self.exit(1, u'Settings error') - except ImportError as e: - logger.error(e) - self.exit(2, u'Import error') - except Exception as e: - logger.exception(e) - self.exit(3, u'Unknown error') - - def run_inside_try(self): - raise NotImplementedError - - def destroy(self): - self.terminate() - - def exit(self, status=0, reason=None): - self.core_queue.put({'to': 'core', 'command': 'exit', - 'status': status, 'reason': reason}) - self.destroy() - class BaseThread(multiprocessing.dummy.Process): - def __init__(self, core_queue): + def __init__(self): super(BaseThread, self).__init__() - self.core_queue = core_queue # No thread should block process from exiting self.daemon = True @@ -84,8 +39,6 @@ class BaseThread(multiprocessing.dummy.Process): pass def exit(self, status=0, reason=None): - self.core_queue.put({'to': 'core', 'command': 'exit', - 'status': status, 'reason': reason}) self.destroy() @@ -98,8 +51,8 @@ class GObjectEventThread(BaseThread): :mod:`mopidy.output.gstreamer`, :mod:`mopidy.frontend.mpris`, etc. """ - def __init__(self, core_queue): - super(GObjectEventThread, self).__init__(core_queue) + def __init__(self): + super(GObjectEventThread, self).__init__() self.name = u'GObjectEventThread' self.loop = None From b88d8d5d8aa92bbb989387f95e6dca19107045f9 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:03:11 +0100 Subject: [PATCH 08/65] Actorify mixers --- mopidy/core.py | 9 ++++--- mopidy/mixers/alsa.py | 8 +++--- mopidy/mixers/base.py | 10 +------- mopidy/mixers/denon.py | 20 ++++++--------- mopidy/mixers/dummy.py | 7 +++--- mopidy/mixers/gstreamer_software.py | 16 ++++++++---- mopidy/mixers/nad.py | 38 ++++++++++++----------------- mopidy/mixers/osa.py | 5 ++-- 8 files changed, 54 insertions(+), 59 deletions(-) diff --git a/mopidy/core.py b/mopidy/core.py index ab457a00..51a0b737 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -20,6 +20,7 @@ def main(): setup_settings() setup_gobject_loop() setup_output() + setup_mixer() setup_backend() setup_frontends() @@ -50,11 +51,13 @@ def setup_gobject_loop(): return gobject_loop def setup_output(): - output = get_class(settings.OUTPUT)() - output.start() - return output + return get_class(settings.OUTPUT).start_proxy() + +def setup_mixer(): + return get_class(settings.MIXER).start_proxy() def setup_backend(): + # XXX Convert backend to one or more actors? return get_class(settings.BACKENDS[0])() def setup_frontends(): diff --git a/mopidy/mixers/alsa.py b/mopidy/mixers/alsa.py index 4aa5952f..658677e5 100644 --- a/mopidy/mixers/alsa.py +++ b/mopidy/mixers/alsa.py @@ -1,12 +1,14 @@ import alsaaudio import logging +from pykka.actor import ThreadingActor + from mopidy import settings from mopidy.mixers.base import BaseMixer logger = logging.getLogger('mopidy.mixers.alsa') -class AlsaMixer(BaseMixer): +class AlsaMixer(ThreadingActor, BaseMixer): """ Mixer which uses the Advanced Linux Sound Architecture (ALSA) to control volume. @@ -20,8 +22,8 @@ class AlsaMixer(BaseMixer): - :attr:`mopidy.settings.MIXER_ALSA_CONTROL` """ - def __init__(self, *args, **kwargs): - super(AlsaMixer, self).__init__(*args, **kwargs) + def __init__(self): + # XXX Do mixer detection after actor starts? self._mixer = alsaaudio.Mixer(self._get_mixer_control()) assert self._mixer is not None diff --git a/mopidy/mixers/base.py b/mopidy/mixers/base.py index f7f9525c..74996cb6 100644 --- a/mopidy/mixers/base.py +++ b/mopidy/mixers/base.py @@ -2,17 +2,12 @@ from mopidy import settings class BaseMixer(object): """ - :param backend: a backend instance - :type backend: :class:`mopidy.backends.base.Backend` - **Settings:** - :attr:`mopidy.settings.MIXER_MAX_VOLUME` """ - def __init__(self, backend, *args, **kwargs): - self.backend = backend - self.amplification_factor = settings.MIXER_MAX_VOLUME / 100.0 + amplification_factor = settings.MIXER_MAX_VOLUME / 100.0 @property def volume(self): @@ -35,9 +30,6 @@ class BaseMixer(object): volume = 100 self._set_volume(volume) - def destroy(self): - pass - def _get_volume(self): """ Return volume as integer in range [0, 100]. :class:`None` if unknown. diff --git a/mopidy/mixers/denon.py b/mopidy/mixers/denon.py index f0712f95..50c321b6 100644 --- a/mopidy/mixers/denon.py +++ b/mopidy/mixers/denon.py @@ -1,12 +1,13 @@ import logging -from threading import Lock + +from pykka.actor import ThreadingActor from mopidy import settings from mopidy.mixers.base import BaseMixer logger = logging.getLogger(u'mopidy.mixers.denon') -class DenonMixer(BaseMixer): +class DenonMixer(ThreadingActor, BaseMixer): """ Mixer for controlling Denon amplifiers and receivers using the RS-232 protocol. @@ -24,12 +25,12 @@ class DenonMixer(BaseMixer): - :attr:`mopidy.settings.MIXER_EXT_PORT` -- Example: ``/dev/ttyUSB0`` """ - def __init__(self, *args, **kwargs): + def __init__(self): """ Connects using the serial specifications from Denon's RS-232 Protocol specification: 9600bps 8N1. """ - super(DenonMixer, self).__init__(*args, **kwargs) + # XXX Do setup after actor starts? device = kwargs.get('device', None) if device: self._device = device @@ -38,14 +39,11 @@ class DenonMixer(BaseMixer): self._device = Serial(port=settings.MIXER_EXT_PORT, timeout=0.2) self._levels = ['99'] + ["%(#)02d" % {'#': v} for v in range(0, 99)] self._volume = 0 - self._lock = Lock() def _get_volume(self): - self._lock.acquire() - self.ensure_open_device() + self._ensure_open_device() self._device.write('MV?\r') vol = str(self._device.readline()[2:4]) - self._lock.release() logger.debug(u'_get_volume() = %s' % vol) return self._levels.index(vol) @@ -53,14 +51,12 @@ class DenonMixer(BaseMixer): # Clamp according to Denon-spec if volume > 99: volume = 99 - self._lock.acquire() - self.ensure_open_device() + self._ensure_open_device() self._device.write('MV%s\r'% self._levels[volume]) vol = self._device.readline()[2:4] - self._lock.release() self._volume = self._levels.index(vol) - def ensure_open_device(self): + def _ensure_open_device(self): if not self._device.isOpen(): logger.debug(u'(re)connecting to Denon device') self._device.open() diff --git a/mopidy/mixers/dummy.py b/mopidy/mixers/dummy.py index 12a8137e..186bc7aa 100644 --- a/mopidy/mixers/dummy.py +++ b/mopidy/mixers/dummy.py @@ -1,10 +1,11 @@ +from pykka.actor import ThreadingActor + from mopidy.mixers.base import BaseMixer -class DummyMixer(BaseMixer): +class DummyMixer(ThreadingActor, BaseMixer): """Mixer which just stores and reports the chosen volume.""" - def __init__(self, *args, **kwargs): - super(DummyMixer, self).__init__(*args, **kwargs) + def __init__(self): self._volume = None def _get_volume(self): diff --git a/mopidy/mixers/gstreamer_software.py b/mopidy/mixers/gstreamer_software.py index 9dca3690..95635794 100644 --- a/mopidy/mixers/gstreamer_software.py +++ b/mopidy/mixers/gstreamer_software.py @@ -1,13 +1,19 @@ +from pykka.actor import ThreadingActor +from pykka.proxy import ActorProxy +from pykka.registry import ActorRegistry + from mopidy.mixers.base import BaseMixer -class GStreamerSoftwareMixer(BaseMixer): +class GStreamerSoftwareMixer(ThreadingActor, BaseMixer): """Mixer which uses GStreamer to control volume in software.""" - def __init__(self, *args, **kwargs): - super(GStreamerSoftwareMixer, self).__init__(*args, **kwargs) + def __init__(self): + # XXX Get reference to output without hardcoding GStreamerOutput + output_refs = ActorRegistry.get_by_class_name('GStreamerOutput') + self.output = ActorProxy(output_refs[0]) def _get_volume(self): - return self.backend.output.get_volume() + return self.output.get_volume().get() def _set_volume(self, volume): - self.backend.output.set_volume(volume) + self.output.set_volume(volume).get() diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index 5cf92826..0765882d 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -2,13 +2,15 @@ import logging from serial import Serial from multiprocessing import Pipe +from pykka.actor import ThreadingActor + from mopidy import settings from mopidy.mixers.base import BaseMixer from mopidy.utils.process import BaseThread logger = logging.getLogger('mopidy.mixers.nad') -class NadMixer(BaseMixer): +class NadMixer(ThreadingActor, BaseMixer): """ Mixer for controlling NAD amplifiers and receivers using the NAD RS-232 protocol. @@ -36,21 +38,19 @@ class NadMixer(BaseMixer): """ - def __init__(self, *args, **kwargs): - super(NadMixer, self).__init__(*args, **kwargs) - self._volume = None - self._pipe, other_end = Pipe() - NadTalker(self.backend.core_queue, pipe=other_end).start() + def __init__(self): + self._volume_cache = None + self._nad_talker = NadTalker.start_proxy() def _get_volume(self): - return self._volume + return self._volume_cache def _set_volume(self, volume): - self._volume = volume - self._pipe.send({'command': 'set_volume', 'volume': volume}) + self._volume_cache = volume + self._nad_talker.set_volume(volume) -class NadTalker(BaseThread): +class NadTalker(ThreadingActor): """ Independent process which does the communication with the NAD device. @@ -72,21 +72,15 @@ class NadTalker(BaseThread): # Volume in range 0..VOLUME_LEVELS. :class:`None` before calibration. _nad_volume = None - def __init__(self, core_queue, pipe=None): - super(NadTalker, self).__init__(core_queue) - self.name = u'NadTalker' - self.pipe = pipe + def __init__(self): self._device = None - def run_inside_try(self): + # XXX Do after actor starts? + self._setup() + + def _setup(self): self._open_connection() self._set_device_to_known_state() - while self.pipe.poll(None): - message = self.pipe.recv() - if message['command'] == 'set_volume': - self._set_volume(message['volume']) - elif message['command'] == 'reset_device': - self._set_device_to_known_state() def _open_connection(self): # Opens serial connection to the device. @@ -164,7 +158,7 @@ class NadTalker(BaseThread): self._nad_volume = 0 logger.info(u'Done calibrating NAD amplifier') - def _set_volume(self, volume): + def set_volume(self, volume): # Increase or decrease the amplifier volume until it matches the given # target volume. logger.debug(u'Setting volume to %d' % volume) diff --git a/mopidy/mixers/osa.py b/mopidy/mixers/osa.py index 2ea04cf2..53983095 100644 --- a/mopidy/mixers/osa.py +++ b/mopidy/mixers/osa.py @@ -1,9 +1,11 @@ from subprocess import Popen, PIPE import time +from pykka.actor import ThreadingActor + from mopidy.mixers.base import BaseMixer -class OsaMixer(BaseMixer): +class OsaMixer(ThreadingActor, BaseMixer): """ Mixer which uses ``osascript`` on OS X to control volume. @@ -14,7 +16,6 @@ class OsaMixer(BaseMixer): **Settings:** - None - """ CACHE_TTL = 30 From 6a78f11383486fec34fee265e8fa5549c62bad2e Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:15:45 +0100 Subject: [PATCH 09/65] Remove mpd_format() from CurrentPlaylistController --- mopidy/backends/base/current_playlist.py | 7 ------- .../mpd/protocol/current_playlist.py | 19 ++++++++++++++----- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/mopidy/backends/base/current_playlist.py b/mopidy/backends/base/current_playlist.py index fe7d1de9..bd424a2d 100644 --- a/mopidy/backends/base/current_playlist.py +++ b/mopidy/backends/base/current_playlist.py @@ -2,8 +2,6 @@ from copy import copy import logging import random -from mopidy.frontends.mpd import translator - logger = logging.getLogger('mopidy.backends.base') class CurrentPlaylistController(object): @@ -197,8 +195,3 @@ class CurrentPlaylistController(object): random.shuffle(shuffled) self._cp_tracks = before + shuffled + after self.version += 1 - - def mpd_format(self, *args, **kwargs): - """Not a part of the generic backend API.""" - kwargs['cpids'] = [ct[0] for ct in self._cp_tracks] - return translator.tracks_to_mpd_format(self.tracks, *args, **kwargs) diff --git a/mopidy/frontends/mpd/protocol/current_playlist.py b/mopidy/frontends/mpd/protocol/current_playlist.py index 2f0a9f8f..13635a33 100644 --- a/mopidy/frontends/mpd/protocol/current_playlist.py +++ b/mopidy/frontends/mpd/protocol/current_playlist.py @@ -1,6 +1,7 @@ -from mopidy.frontends.mpd.protocol import handle_pattern from mopidy.frontends.mpd.exceptions import (MpdArgError, MpdNoExistError, MpdNotImplemented) +from mopidy.frontends.mpd.protocol import handle_pattern +from mopidy.frontends.mpd.translator import tracks_to_mpd_format @handle_pattern(r'^add "(?P[^"]*)"$') def add(frontend, uri): @@ -218,7 +219,9 @@ def playlistid(frontend, cpid=None): except LookupError: raise MpdNoExistError(u'No such song', command=u'playlistid') else: - return frontend.backend.current_playlist.mpd_format() + cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] + return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, + cpids=cpids) @handle_pattern(r'^playlistinfo$') @handle_pattern(r'^playlistinfo "(?P-?\d+)"$') @@ -248,7 +251,9 @@ def playlistinfo(frontend, songpos=None, end = songpos + 1 if start == -1: end = None - return frontend.backend.current_playlist.mpd_format(start, end) + cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] + return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, + start, end, cpids=cpids) else: if start is None: start = 0 @@ -259,7 +264,9 @@ def playlistinfo(frontend, songpos=None, end = int(end) if end > len(frontend.backend.current_playlist.tracks): end = None - return frontend.backend.current_playlist.mpd_format(start, end) + cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] + return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, + start, end, cpids=cpids) @handle_pattern(r'^playlistsearch "(?P[^"]+)" "(?P[^"]+)"$') @handle_pattern(r'^playlistsearch (?P\S+) "(?P[^"]+)"$') @@ -298,7 +305,9 @@ def plchanges(frontend, version): """ # XXX Naive implementation that returns all tracks as changed if int(version) < frontend.backend.current_playlist.version: - return frontend.backend.current_playlist.mpd_format() + cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] + return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, + cpids=cpids) @handle_pattern(r'^plchangesposid "(?P\d+)"$') def plchangesposid(frontend, version): From ab01828c054a91a54a5edab3394c48629664045a Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:19:23 +0100 Subject: [PATCH 10/65] Strip Backend to a minimum --- mopidy/backends/base/__init__.py | 53 -------------------------------- 1 file changed, 53 deletions(-) diff --git a/mopidy/backends/base/__init__.py b/mopidy/backends/base/__init__.py index 096a433f..963d9eb4 100644 --- a/mopidy/backends/base/__init__.py +++ b/mopidy/backends/base/__init__.py @@ -1,12 +1,4 @@ -from copy import copy import logging -import random -import time - -from mopidy import settings -from mopidy.frontends.mpd import translator -from mopidy.models import Playlist -from mopidy.utils import get_class from .current_playlist import CurrentPlaylistController from .library import LibraryController, BaseLibraryProvider @@ -17,30 +9,6 @@ from .stored_playlists import (StoredPlaylistsController, logger = logging.getLogger('mopidy.backends.base') class Backend(object): - """ - :param core_queue: a queue for sending messages to - :class:`mopidy.process.CoreProcess` - :type core_queue: :class:`multiprocessing.Queue` - :param output: the audio output - :type output: :class:`mopidy.outputs.gstreamer.GStreamerOutput` or similar - :param mixer_class: either a mixer class, or :class:`None` to use the mixer - defined in settings - :type mixer_class: a subclass of :class:`mopidy.mixers.BaseMixer` or - :class:`None` - """ - - def __init__(self, core_queue=None, output=None, mixer_class=None): - self.core_queue = core_queue - self.output = output - if mixer_class is None: - mixer_class = get_class(settings.MIXER) - self.mixer = mixer_class(self) - - #: A :class:`multiprocessing.Queue` which can be used by e.g. library - #: callbacks executing in other threads to send messages to the core - #: thread, so that action may be taken in the correct thread. - core_queue = None - #: The current playlist controller. An instance of #: :class:`mopidy.backends.base.CurrentPlaylistController`. current_playlist = None @@ -62,24 +30,3 @@ class Backend(object): #: List of URI prefixes this backend can handle. uri_handlers = [] - - def destroy(self): - """ - Call destroy on all sub-components in backend so that they can cleanup - after themselves. - """ - - if self.current_playlist: - self.current_playlist.destroy() - - if self.library: - self.library.destroy() - - if self.mixer: - self.mixer.destroy() - - if self.playback: - self.playback.destroy() - - if self.stored_playlists: - self.stored_playlists.destroy() From 38e5cec0f03cfac11ad55416dcb0d41c09525533 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:35:22 +0100 Subject: [PATCH 11/65] Partly actorify MpdFrontend --- mopidy/core.py | 3 +- mopidy/frontends/mpd/__init__.py | 49 ++++++++++++++------------------ mopidy/frontends/mpd/session.py | 11 +------ mopidy/frontends/mpd/thread.py | 18 ------------ 4 files changed, 23 insertions(+), 58 deletions(-) delete mode 100644 mopidy/frontends/mpd/thread.py diff --git a/mopidy/core.py b/mopidy/core.py index 51a0b737..c687aed1 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -64,8 +64,7 @@ def setup_frontends(): frontends = [] for frontend_class_name in settings.FRONTENDS: try: - frontend = get_class(frontend_class_name)() - frontend.start() + frontend = get_class(frontend_class_name).start_proxy() frontends.append(frontend) except OptionalDependencyError as e: logger.info(u'Disabled: %s (%s)', frontend_class_name, e) diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index 2f87088c..b3d5b5e8 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -1,13 +1,15 @@ +import asyncore import logging +from pykka.actor import ThreadingActor + from mopidy.frontends.base import BaseFrontend -from mopidy.frontends.mpd.dispatcher import MpdDispatcher -from mopidy.frontends.mpd.thread import MpdThread -from mopidy.utils.process import unpickle_connection +from mopidy.frontends.mpd.server import MpdServer +from mopidy.utils.process import BaseThread logger = logging.getLogger('mopidy.frontends.mpd') -class MpdFrontend(BaseFrontend): +class MpdFrontend(ThreadingActor, BaseFrontend): """ The MPD frontend. @@ -18,32 +20,23 @@ class MpdFrontend(BaseFrontend): - :attr:`mopidy.settings.MPD_SERVER_PORT` """ - def __init__(self, *args, **kwargs): - super(MpdFrontend, self).__init__(*args, **kwargs) - self.thread = None - self.dispatcher = MpdDispatcher(self.backend) - - def start(self): - """Starts the MPD server.""" - self.thread = MpdThread(self.core_queue) - self.thread.start() + def __init__(self): + # XXX Do setup after actor starts? + self._thread = MpdThread() + self._thread.start() def destroy(self): """Destroys the MPD server.""" - self.thread.destroy() + self._thread.destroy() - def process_message(self, message): - """ - Processes messages with the MPD frontend as destination. - :param message: the message - :type message: dict - """ - assert message['to'] == 'frontend', \ - u'Message recipient must be "frontend".' - if message['command'] == 'mpd_request': - response = self.dispatcher.handle_request(message['request']) - connection = unpickle_connection(message['reply_to']) - connection.send(response) - else: - pass # Ignore messages for other frontends +class MpdThread(BaseThread): + def __init__(self): + super(BaseThread, self).__init__() + self.name = u'MpdThread' + + def run_inside_try(self): + logger.debug(u'Starting MPD server thread') + server = MpdServer(self.core_queue) + server.start() + asyncore.loop() diff --git a/mopidy/frontends/mpd/session.py b/mopidy/frontends/mpd/session.py index e8e3291d..349fceb9 100644 --- a/mopidy/frontends/mpd/session.py +++ b/mopidy/frontends/mpd/session.py @@ -5,7 +5,6 @@ import multiprocessing from mopidy import settings from mopidy.frontends.mpd.protocol import ENCODING, LINE_TERMINATOR, VERSION from mopidy.utils.log import indent -from mopidy.utils.process import pickle_connection logger = logging.getLogger('mopidy.frontends.mpd.session') @@ -53,15 +52,7 @@ class MpdSession(asynchat.async_chat): if response is not None: self.send_response(response) return - my_end, other_end = multiprocessing.Pipe() - self.core_queue.put({ - 'to': 'frontend', - 'command': 'mpd_request', - 'request': request, - 'reply_to': pickle_connection(other_end), - }) - my_end.poll(None) - response = my_end.recv() + # TODO-PYKKA: Process request using MpdDispatcher/backend if response is not None: self.handle_response(response) diff --git a/mopidy/frontends/mpd/thread.py b/mopidy/frontends/mpd/thread.py deleted file mode 100644 index 0ad5ee68..00000000 --- a/mopidy/frontends/mpd/thread.py +++ /dev/null @@ -1,18 +0,0 @@ -import asyncore -import logging - -from mopidy.frontends.mpd.server import MpdServer -from mopidy.utils.process import BaseThread - -logger = logging.getLogger('mopidy.frontends.mpd.thread') - -class MpdThread(BaseThread): - def __init__(self, core_queue): - super(MpdThread, self).__init__(core_queue) - self.name = u'MpdThread' - - def run_inside_try(self): - logger.debug(u'Starting MPD server thread') - server = MpdServer(self.core_queue) - server.start() - asyncore.loop() From 18e252a9d39283a63ef55d024fd192882a0917f5 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:36:23 +0100 Subject: [PATCH 12/65] Strip FrontendBase to a minimum --- mopidy/frontends/base.py | 37 +------------------------------------ 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/mopidy/frontends/base.py b/mopidy/frontends/base.py index bf1c9bda..811644b1 100644 --- a/mopidy/frontends/base.py +++ b/mopidy/frontends/base.py @@ -1,40 +1,5 @@ class BaseFrontend(object): """ Base class for frontends. - - :param core_queue: queue for messaging the core - :type core_queue: :class:`multiprocessing.Queue` - :param backend: the backend - :type backend: :class:`mopidy.backends.base.Backend` """ - - def __init__(self, core_queue, backend): - self.core_queue = core_queue - self.backend = backend - - def start(self): - """ - Start the frontend. - - *MAY be implemented by subclass.* - """ - pass - - def destroy(self): - """ - Destroy the frontend. - - *MAY be implemented by subclass.* - """ - pass - - def process_message(self, message): - """ - Process messages for the frontend. - - *MUST be implemented by subclass.* - - :param message: the message - :type message: dict - """ - raise NotImplementedError + pass From 43cb8d077c1bf59be3b040b0fbf19cfe1f630e5b Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:41:07 +0100 Subject: [PATCH 13/65] Actorify LastfmFrontend --- mopidy/frontends/lastfm.py | 47 ++++++++------------------------------ 1 file changed, 9 insertions(+), 38 deletions(-) diff --git a/mopidy/frontends/lastfm.py b/mopidy/frontends/lastfm.py index d2c9af88..f8a46c0f 100644 --- a/mopidy/frontends/lastfm.py +++ b/mopidy/frontends/lastfm.py @@ -1,5 +1,4 @@ import logging -import multiprocessing import time try: @@ -8,6 +7,8 @@ except ImportError as import_error: from mopidy import OptionalDependencyError raise OptionalDependencyError(import_error) +from pykka.actor import ThreadingActor + from mopidy import settings, SettingsError from mopidy.frontends.base import BaseFrontend from mopidy.utils.process import BaseThread @@ -17,7 +18,7 @@ logger = logging.getLogger('mopidy.frontends.lastfm') API_KEY = '2236babefa8ebb3d93ea467560d00d04' API_SECRET = '94d9a09c0cd5be955c4afaeaffcaefcd' -class LastfmFrontend(BaseFrontend): +class LastfmFrontend(ThreadingActor, BaseFrontend): """ Frontend which scrobbles the music you play to your `Last.fm `_ profile. @@ -36,38 +37,14 @@ class LastfmFrontend(BaseFrontend): - :attr:`mopidy.settings.LASTFM_PASSWORD` """ - def __init__(self, *args, **kwargs): - super(LastfmFrontend, self).__init__(*args, **kwargs) - (self.connection, other_end) = multiprocessing.Pipe() - self.thread = LastfmFrontendThread(self.core_queue, other_end) - - def start(self): - self.thread.start() - - def destroy(self): - self.thread.destroy() - - def process_message(self, message): - if self.thread.is_alive(): - self.connection.send(message) - - -class LastfmFrontendThread(BaseThread): - def __init__(self, core_queue, connection): - super(LastfmFrontendThread, self).__init__(core_queue) - self.name = u'LastfmFrontendThread' - self.connection = connection + def __init__(self): self.lastfm = None self.last_start_time = None - def run_inside_try(self): - self.setup() - while self.lastfm is not None: - self.connection.poll(None) - message = self.connection.recv() - self.process_message(message) + # TODO-PYKKA: Do setup after actor starts + self._setup() - def setup(self): + def _setup(self): try: username = settings.LASTFM_USERNAME password_hash = pylast.md5(settings.LASTFM_PASSWORD) @@ -78,17 +55,11 @@ class LastfmFrontendThread(BaseThread): except SettingsError as e: logger.info(u'Last.fm scrobbler not started') logger.debug(u'Last.fm settings error: %s', e) + self.stop() except (pylast.NetworkError, pylast.MalformedResponseError, pylast.WSError) as e: logger.error(u'Error during Last.fm setup: %s', e) - - def process_message(self, message): - if message['command'] == 'started_playing': - self.started_playing(message['track']) - elif message['command'] == 'stopped_playing': - self.stopped_playing(message['track'], message['stop_position']) - else: - pass # Ignore commands for other frontends + self.stop() def started_playing(self, track): artists = ', '.join([a.name for a in track.artists]) From d75ca5b4e8dce13ece6238bcf5b082a29ca65581 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:42:55 +0100 Subject: [PATCH 14/65] Make MpdFrontend start --- mopidy/frontends/mpd/__init__.py | 2 +- mopidy/frontends/mpd/server.py | 6 ++---- mopidy/frontends/mpd/session.py | 4 +--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index b3d5b5e8..f4684b9d 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -37,6 +37,6 @@ class MpdThread(BaseThread): def run_inside_try(self): logger.debug(u'Starting MPD server thread') - server = MpdServer(self.core_queue) + server = MpdServer() server.start() asyncore.loop() diff --git a/mopidy/frontends/mpd/server.py b/mopidy/frontends/mpd/server.py index 7caf21f9..231bdf40 100644 --- a/mopidy/frontends/mpd/server.py +++ b/mopidy/frontends/mpd/server.py @@ -15,9 +15,8 @@ class MpdServer(asyncore.dispatcher): for each client connection. """ - def __init__(self, core_queue): + def __init__(self): asyncore.dispatcher.__init__(self) - self.core_queue = core_queue def start(self): """Start MPD server.""" @@ -47,8 +46,7 @@ class MpdServer(asyncore.dispatcher): (client_socket, client_socket_address) = self.accept() logger.info(u'MPD client connection from [%s]:%s', client_socket_address[0], client_socket_address[1]) - MpdSession(self, client_socket, client_socket_address, - self.core_queue).start() + MpdSession(self, client_socket, client_socket_address).start() def handle_close(self): """Handle end of client connection.""" diff --git a/mopidy/frontends/mpd/session.py b/mopidy/frontends/mpd/session.py index 349fceb9..399c2adb 100644 --- a/mopidy/frontends/mpd/session.py +++ b/mopidy/frontends/mpd/session.py @@ -14,13 +14,11 @@ class MpdSession(asynchat.async_chat): MPD requests to the dispatcher. """ - def __init__(self, server, client_socket, client_socket_address, - core_queue): + def __init__(self, server, client_socket, client_socket_address): asynchat.async_chat.__init__(self, sock=client_socket) self.server = server self.client_address = client_socket_address[0] self.client_port = client_socket_address[1] - self.core_queue = core_queue self.input_buffer = [] self.authenticated = False self.set_terminator(LINE_TERMINATOR.encode(ENCODING)) From f0fd2c9df279830cb18f304f51c2e8af34d5aa9e Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:52:04 +0100 Subject: [PATCH 15/65] Change XXXs to TODO-PYKKA to easier find them again --- mopidy/core.py | 2 +- mopidy/frontends/mpd/__init__.py | 2 +- mopidy/mixers/alsa.py | 2 +- mopidy/mixers/denon.py | 2 +- mopidy/mixers/gstreamer_software.py | 2 +- mopidy/mixers/nad.py | 2 +- mopidy/outputs/gstreamer.py | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mopidy/core.py b/mopidy/core.py index c687aed1..747ef5fb 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -57,7 +57,7 @@ def setup_mixer(): return get_class(settings.MIXER).start_proxy() def setup_backend(): - # XXX Convert backend to one or more actors? + # TODO-PYKKA: Convert backend to one or more actors? return get_class(settings.BACKENDS[0])() def setup_frontends(): diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index f4684b9d..3a1211ae 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -21,7 +21,7 @@ class MpdFrontend(ThreadingActor, BaseFrontend): """ def __init__(self): - # XXX Do setup after actor starts? + # TODO-PYKKA: Do setup after actor starts? self._thread = MpdThread() self._thread.start() diff --git a/mopidy/mixers/alsa.py b/mopidy/mixers/alsa.py index 658677e5..f4f40ca1 100644 --- a/mopidy/mixers/alsa.py +++ b/mopidy/mixers/alsa.py @@ -23,7 +23,7 @@ class AlsaMixer(ThreadingActor, BaseMixer): """ def __init__(self): - # XXX Do mixer detection after actor starts? + # PYKKA-TODO: Do mixer detection after actor starts? self._mixer = alsaaudio.Mixer(self._get_mixer_control()) assert self._mixer is not None diff --git a/mopidy/mixers/denon.py b/mopidy/mixers/denon.py index 50c321b6..36f0f3bd 100644 --- a/mopidy/mixers/denon.py +++ b/mopidy/mixers/denon.py @@ -30,7 +30,7 @@ class DenonMixer(ThreadingActor, BaseMixer): Connects using the serial specifications from Denon's RS-232 Protocol specification: 9600bps 8N1. """ - # XXX Do setup after actor starts? + # TODO-PYKKA: Do setup after actor starts? device = kwargs.get('device', None) if device: self._device = device diff --git a/mopidy/mixers/gstreamer_software.py b/mopidy/mixers/gstreamer_software.py index 95635794..f9d171ca 100644 --- a/mopidy/mixers/gstreamer_software.py +++ b/mopidy/mixers/gstreamer_software.py @@ -8,7 +8,7 @@ class GStreamerSoftwareMixer(ThreadingActor, BaseMixer): """Mixer which uses GStreamer to control volume in software.""" def __init__(self): - # XXX Get reference to output without hardcoding GStreamerOutput + # TODO-PYKKA Get reference to output without hardcoding GStreamerOutput output_refs = ActorRegistry.get_by_class_name('GStreamerOutput') self.output = ActorProxy(output_refs[0]) diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index 0765882d..90d5d5b2 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -75,7 +75,7 @@ class NadTalker(ThreadingActor): def __init__(self): self._device = None - # XXX Do after actor starts? + # TODO-PYKKA: Do after actor starts? self._setup() def _setup(self): diff --git a/mopidy/outputs/gstreamer.py b/mopidy/outputs/gstreamer.py index 3fb58a2e..b0b98d99 100644 --- a/mopidy/outputs/gstreamer.py +++ b/mopidy/outputs/gstreamer.py @@ -24,7 +24,7 @@ class GStreamerOutput(ThreadingActor, BaseOutput): def __init__(self): self.gst_pipeline = None - # XXX Run setup after actor starts? + # TODO-PYKKA: Run setup after actor starts? self._setup_gstreamer() def _setup_gstreamer(self): From 3a3777e93e8e10cb1b55d9a2665128368aee6c4f Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 7 Mar 2011 22:59:25 +0100 Subject: [PATCH 16/65] Update Spotify backend enough to make it start without errors --- mopidy/backends/spotify/__init__.py | 4 +--- mopidy/backends/spotify/session_manager.py | 27 ++++++++++++---------- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/mopidy/backends/spotify/__init__.py b/mopidy/backends/spotify/__init__.py index d36f6250..ad3dd7ea 100644 --- a/mopidy/backends/spotify/__init__.py +++ b/mopidy/backends/spotify/__init__.py @@ -67,8 +67,6 @@ class SpotifyBackend(Backend): logger.info(u'Mopidy uses SPOTIFY(R) CORE') logger.debug(u'Connecting to Spotify') spotify = SpotifySessionManager( - settings.SPOTIFY_USERNAME, settings.SPOTIFY_PASSWORD, - core_queue=self.core_queue, - output=self.output) + settings.SPOTIFY_USERNAME, settings.SPOTIFY_PASSWORD) spotify.start() return spotify diff --git a/mopidy/backends/spotify/session_manager.py b/mopidy/backends/spotify/session_manager.py index 9736f2eb..d08a7c97 100644 --- a/mopidy/backends/spotify/session_manager.py +++ b/mopidy/backends/spotify/session_manager.py @@ -2,7 +2,10 @@ import logging import os import threading -import spotify.manager +from spotify.manager import SpotifySessionManager as PyspotifySessionManager + +from pykka.registry import ActorRegistry +from pykka.proxy import ActorProxy from mopidy import get_version, settings from mopidy.backends.spotify.translator import SpotifyTranslator @@ -14,18 +17,21 @@ logger = logging.getLogger('mopidy.backends.spotify.session_manager') # pylint: disable = R0901 # SpotifySessionManager: Too many ancestors (9/7) -class SpotifySessionManager(spotify.manager.SpotifySessionManager, BaseThread): +class SpotifySessionManager(BaseThread, PyspotifySessionManager): cache_location = settings.SPOTIFY_CACHE_PATH settings_location = settings.SPOTIFY_CACHE_PATH appkey_file = os.path.join(os.path.dirname(__file__), 'spotify_appkey.key') user_agent = 'Mopidy %s' % get_version() - def __init__(self, username, password, core_queue, output): - spotify.manager.SpotifySessionManager.__init__( - self, username, password) - BaseThread.__init__(self, core_queue) + def __init__(self, username, password): + PyspotifySessionManager.__init__(self, username, password) + BaseThread.__init__(self) self.name = 'SpotifySMThread' - self.output = output + + # TODO-PYKKA Get reference to output without hardcoding GStreamerOutput + output_refs = ActorRegistry.get_by_class_name('GStreamerOutput') + self.output = ActorProxy(output_refs[0]) + self.connected = threading.Event() self.session = None @@ -88,7 +94,7 @@ class SpotifySessionManager(spotify.manager.SpotifySessionManager, BaseThread): def play_token_lost(self, session): """Callback used by pyspotify""" logger.debug(u'Play token lost') - self.core_queue.put({'command': 'stop_playback'}) + # TODO-PYKKA: Send 'stop_playback' to backend def log_message(self, session, data): """Callback used by pyspotify""" @@ -107,10 +113,7 @@ class SpotifySessionManager(spotify.manager.SpotifySessionManager, BaseThread): playlists.append( SpotifyTranslator.to_mopidy_playlist(spotify_playlist)) playlists = filter(None, playlists) - self.core_queue.put({ - 'command': 'set_stored_playlists', - 'playlists': playlists, - }) + # TODO-PYKKA: Set stored_playlists on backend logger.debug(u'Refreshed %d stored playlist(s)', len(playlists)) def search(self, query, connection): From 65c64b4a8abc2cb74419c277f50d54cdc472e4e7 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Tue, 8 Mar 2011 20:39:50 +0100 Subject: [PATCH 17/65] Actorify backends --- mopidy/backends/base/current_playlist.py | 2 ++ mopidy/backends/base/library.py | 2 ++ mopidy/backends/base/playback.py | 4 ++++ mopidy/backends/dummy/__init__.py | 14 +++----------- mopidy/backends/local/__init__.py | 4 +++- mopidy/backends/spotify/__init__.py | 5 ++++- mopidy/core.py | 3 +-- 7 files changed, 19 insertions(+), 15 deletions(-) diff --git a/mopidy/backends/base/current_playlist.py b/mopidy/backends/base/current_playlist.py index bd424a2d..ffdce176 100644 --- a/mopidy/backends/base/current_playlist.py +++ b/mopidy/backends/base/current_playlist.py @@ -10,6 +10,8 @@ class CurrentPlaylistController(object): :type backend: :class:`mopidy.backends.base.Backend` """ + pykka_traversable = True + def __init__(self, backend): self.backend = backend self._cp_tracks = [] diff --git a/mopidy/backends/base/library.py b/mopidy/backends/base/library.py index fd018b5f..9ca103c0 100644 --- a/mopidy/backends/base/library.py +++ b/mopidy/backends/base/library.py @@ -10,6 +10,8 @@ class LibraryController(object): :type provider: instance of :class:`BaseLibraryProvider` """ + pykka_traversable = True + def __init__(self, backend, provider): self.backend = backend self.provider = provider diff --git a/mopidy/backends/base/playback.py b/mopidy/backends/base/playback.py index 8a3eeee5..e4ffa075 100644 --- a/mopidy/backends/base/playback.py +++ b/mopidy/backends/base/playback.py @@ -15,6 +15,8 @@ class PlaybackController(object): # pylint: disable = R0902 # Too many instance attributes + pykka_traversable = True + #: Constant representing the paused state. PAUSED = u'paused' @@ -461,6 +463,7 @@ class PlaybackController(object): For internal use only. Should be called by the backend directly after a track has started playing. """ + return # TODO-PYKKA Send started_playing event to interested parties if self.current_track is not None: self.backend.core_queue.put({ 'to': 'frontend', @@ -476,6 +479,7 @@ class PlaybackController(object): is stopped playing, e.g. at the next, previous, and stop actions and at end-of-track. """ + return # TODO-PYKKA Send stopped_playing event to interested parties if self.current_track is not None: self.backend.core_queue.put({ 'to': 'frontend', diff --git a/mopidy/backends/dummy/__init__.py b/mopidy/backends/dummy/__init__.py index 9c6885bc..82051188 100644 --- a/mopidy/backends/dummy/__init__.py +++ b/mopidy/backends/dummy/__init__.py @@ -1,3 +1,5 @@ +from pykka.actor import ThreadingActor + from mopidy.backends.base import (Backend, CurrentPlaylistController, PlaybackController, BasePlaybackProvider, LibraryController, BaseLibraryProvider, StoredPlaylistsController, @@ -5,15 +7,7 @@ from mopidy.backends.base import (Backend, CurrentPlaylistController, from mopidy.models import Playlist -class DummyQueue(object): - def __init__(self): - self.received_messages = [] - - def put(self, message): - self.received_messages.append(message) - - -class DummyBackend(Backend): +class DummyBackend(ThreadingActor, Backend): """ A backend which implements the backend API in the simplest way possible. Used in tests of the frontends. @@ -24,8 +18,6 @@ class DummyBackend(Backend): def __init__(self, *args, **kwargs): super(DummyBackend, self).__init__(*args, **kwargs) - self.core_queue = DummyQueue() - self.current_playlist = CurrentPlaylistController(backend=self) library_provider = DummyLibraryProvider(backend=self) diff --git a/mopidy/backends/local/__init__.py b/mopidy/backends/local/__init__.py index e3e1d5dc..c5b42b74 100644 --- a/mopidy/backends/local/__init__.py +++ b/mopidy/backends/local/__init__.py @@ -4,6 +4,8 @@ import multiprocessing import os import shutil +from pykka.actor import ThreadingActor + from mopidy import settings from mopidy.backends.base import (Backend, CurrentPlaylistController, LibraryController, BaseLibraryProvider, PlaybackController, @@ -16,7 +18,7 @@ from .translator import parse_m3u, parse_mpd_tag_cache logger = logging.getLogger(u'mopidy.backends.local') -class LocalBackend(Backend): +class LocalBackend(ThreadingActor, Backend): """ A backend for playing music from a local music archive. diff --git a/mopidy/backends/spotify/__init__.py b/mopidy/backends/spotify/__init__.py index ad3dd7ea..d85e91b2 100644 --- a/mopidy/backends/spotify/__init__.py +++ b/mopidy/backends/spotify/__init__.py @@ -1,5 +1,7 @@ import logging +from pykka.actor import ThreadingActor + from mopidy import settings from mopidy.backends.base import (Backend, CurrentPlaylistController, LibraryController, PlaybackController, StoredPlaylistsController) @@ -8,7 +10,7 @@ logger = logging.getLogger('mopidy.backends.spotify') ENCODING = 'utf-8' -class SpotifyBackend(Backend): +class SpotifyBackend(ThreadingActor, Backend): """ A backend for playing music from the `Spotify `_ music streaming service. The backend uses the official `libspotify @@ -59,6 +61,7 @@ class SpotifyBackend(Backend): self.uri_handlers = [u'spotify:', u'http://open.spotify.com/'] + # TODO-PYKKA: Do setup after actor starts? self.spotify = self._connect() def _connect(self): diff --git a/mopidy/core.py b/mopidy/core.py index 747ef5fb..a82ec2d1 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -57,8 +57,7 @@ def setup_mixer(): return get_class(settings.MIXER).start_proxy() def setup_backend(): - # TODO-PYKKA: Convert backend to one or more actors? - return get_class(settings.BACKENDS[0])() + return get_class(settings.BACKENDS[0]).start_proxy() def setup_frontends(): frontends = [] From a88cf1e2cada6cc010c36579e38822ee1d84f4fd Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Tue, 8 Mar 2011 21:08:45 +0100 Subject: [PATCH 18/65] Hook an MpdDispatcher directly onto each MpdSession --- mopidy/frontends/mpd/dispatcher.py | 18 +++++++++++++++--- mopidy/frontends/mpd/session.py | 8 +++++--- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/mopidy/frontends/mpd/dispatcher.py b/mopidy/frontends/mpd/dispatcher.py index ab5f2e8c..932eb3e3 100644 --- a/mopidy/frontends/mpd/dispatcher.py +++ b/mopidy/frontends/mpd/dispatcher.py @@ -1,5 +1,8 @@ import re +from pykka.proxy import ActorProxy +from pykka.registry import ActorRegistry + from mopidy.frontends.mpd.exceptions import (MpdAckError, MpdArgError, MpdUnknownCommand) from mopidy.frontends.mpd.protocol import mpd_commands, request_handlers @@ -14,11 +17,20 @@ from mopidy.utils import flatten class MpdDispatcher(object): """ - Dispatches MPD requests to the correct handler. + The MPD session feeds the MPD dispatcher with requests. The dispatcher + finds the correct handler, processes the request and sends the response + back to the MPD session. """ - def __init__(self, backend=None): - self.backend = backend + # XXX Consider merging MpdDispatcher into MpdSession + + def __init__(self, session): + self.session = session + + # TODO-PYKKA: Get reference to backend in a more generic way + backend_refs = ActorRegistry.get_by_class_name('SpotifyBackend') + self.backend = ActorProxy(backend_refs[0]) + self.command_list = False self.command_list_ok = False diff --git a/mopidy/frontends/mpd/session.py b/mopidy/frontends/mpd/session.py index 399c2adb..eb8c4f11 100644 --- a/mopidy/frontends/mpd/session.py +++ b/mopidy/frontends/mpd/session.py @@ -3,6 +3,7 @@ import logging import multiprocessing from mopidy import settings +from mopidy.frontends.mpd.dispatcher import MpdDispatcher from mopidy.frontends.mpd.protocol import ENCODING, LINE_TERMINATOR, VERSION from mopidy.utils.log import indent @@ -10,8 +11,8 @@ logger = logging.getLogger('mopidy.frontends.mpd.session') class MpdSession(asynchat.async_chat): """ - The MPD client session. Keeps track of a single client and passes its - MPD requests to the dispatcher. + The MPD client session. Keeps track of a single client session. Any + requests from the client is passed on to the MPD request dispatcher. """ def __init__(self, server, client_socket, client_socket_address): @@ -22,6 +23,7 @@ class MpdSession(asynchat.async_chat): self.input_buffer = [] self.authenticated = False self.set_terminator(LINE_TERMINATOR.encode(ENCODING)) + self.dispatcher = MpdDispatcher(self) def start(self): """Start a new client session.""" @@ -50,7 +52,7 @@ class MpdSession(asynchat.async_chat): if response is not None: self.send_response(response) return - # TODO-PYKKA: Process request using MpdDispatcher/backend + response = self.dispatcher.handle_request(request) if response is not None: self.handle_response(response) From 7f725e8c783dfd3226fbe3e2f954efada12f8a45 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Tue, 8 Mar 2011 23:20:42 +0100 Subject: [PATCH 19/65] Upgrade to Pykka 0.10 --- docs/installation/index.rst | 2 +- mopidy/core.py | 8 ++++---- mopidy/mixers/nad.py | 2 +- requirements/core.txt | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/installation/index.rst b/docs/installation/index.rst index 19016ce9..ed6107d8 100644 --- a/docs/installation/index.rst +++ b/docs/installation/index.rst @@ -25,7 +25,7 @@ Otherwise, make sure you got the required dependencies installed. - Python >= 2.6, < 3 -- `Pykka `_ >= 0.9.1 +- `Pykka `_ >= 0.10 - GStreamer >= 0.10, with Python bindings. See :doc:`gstreamer`. diff --git a/mopidy/core.py b/mopidy/core.py index a82ec2d1..e21efd00 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -51,19 +51,19 @@ def setup_gobject_loop(): return gobject_loop def setup_output(): - return get_class(settings.OUTPUT).start_proxy() + return get_class(settings.OUTPUT).start().proxy() def setup_mixer(): - return get_class(settings.MIXER).start_proxy() + return get_class(settings.MIXER).start().proxy() def setup_backend(): - return get_class(settings.BACKENDS[0]).start_proxy() + return get_class(settings.BACKENDS[0]).start().proxy() def setup_frontends(): frontends = [] for frontend_class_name in settings.FRONTENDS: try: - frontend = get_class(frontend_class_name).start_proxy() + frontend = get_class(frontend_class_name).start().proxy() frontends.append(frontend) except OptionalDependencyError as e: logger.info(u'Disabled: %s (%s)', frontend_class_name, e) diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index 90d5d5b2..2844f579 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -40,7 +40,7 @@ class NadMixer(ThreadingActor, BaseMixer): def __init__(self): self._volume_cache = None - self._nad_talker = NadTalker.start_proxy() + self._nad_talker = NadTalker.start().proxy() def _get_volume(self): return self._volume_cache diff --git a/requirements/core.txt b/requirements/core.txt index 54781a3b..1b5cfc4b 100644 --- a/requirements/core.txt +++ b/requirements/core.txt @@ -1 +1 @@ -Pykka >= 0.9.1 +Pykka >= 0.10 From 0575d5d3be96dacb64fa8aa9274387268c77227a Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Tue, 8 Mar 2011 23:28:24 +0100 Subject: [PATCH 20/65] Use Actor.post_start() to do actor setup in the actor's own thread --- mopidy/backends/spotify/__init__.py | 4 +++- mopidy/frontends/lastfm.py | 5 +---- mopidy/frontends/mpd/__init__.py | 8 +++----- mopidy/mixers/denon.py | 19 +++++++------------ mopidy/mixers/nad.py | 5 +---- mopidy/outputs/gstreamer.py | 2 +- 6 files changed, 16 insertions(+), 27 deletions(-) diff --git a/mopidy/backends/spotify/__init__.py b/mopidy/backends/spotify/__init__.py index d85e91b2..021277f2 100644 --- a/mopidy/backends/spotify/__init__.py +++ b/mopidy/backends/spotify/__init__.py @@ -61,7 +61,9 @@ class SpotifyBackend(ThreadingActor, Backend): self.uri_handlers = [u'spotify:', u'http://open.spotify.com/'] - # TODO-PYKKA: Do setup after actor starts? + self.spotify = None + + def post_start(self): self.spotify = self._connect() def _connect(self): diff --git a/mopidy/frontends/lastfm.py b/mopidy/frontends/lastfm.py index f8a46c0f..4a703c22 100644 --- a/mopidy/frontends/lastfm.py +++ b/mopidy/frontends/lastfm.py @@ -41,10 +41,7 @@ class LastfmFrontend(ThreadingActor, BaseFrontend): self.lastfm = None self.last_start_time = None - # TODO-PYKKA: Do setup after actor starts - self._setup() - - def _setup(self): + def post_start(self): try: username = settings.LASTFM_USERNAME password_hash = pylast.md5(settings.LASTFM_PASSWORD) diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index 3a1211ae..96500d9b 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -21,14 +21,12 @@ class MpdFrontend(ThreadingActor, BaseFrontend): """ def __init__(self): - # TODO-PYKKA: Do setup after actor starts? + self._thread = None + + def post_start(self): self._thread = MpdThread() self._thread.start() - def destroy(self): - """Destroys the MPD server.""" - self._thread.destroy() - class MpdThread(BaseThread): def __init__(self): diff --git a/mopidy/mixers/denon.py b/mopidy/mixers/denon.py index 36f0f3bd..832e7d1a 100644 --- a/mopidy/mixers/denon.py +++ b/mopidy/mixers/denon.py @@ -25,21 +25,16 @@ class DenonMixer(ThreadingActor, BaseMixer): - :attr:`mopidy.settings.MIXER_EXT_PORT` -- Example: ``/dev/ttyUSB0`` """ - def __init__(self): - """ - Connects using the serial specifications from Denon's RS-232 Protocol - specification: 9600bps 8N1. - """ - # TODO-PYKKA: Do setup after actor starts? - device = kwargs.get('device', None) - if device: - self._device = device - else: - from serial import Serial - self._device = Serial(port=settings.MIXER_EXT_PORT, timeout=0.2) + def __init__(self, *args, **kwargs): + self._device = kwargs.get('device', None) self._levels = ['99'] + ["%(#)02d" % {'#': v} for v in range(0, 99)] self._volume = 0 + def post_start(self): + if self._device is None: + from serial import Serial + self._device = Serial(port=settings.MIXER_EXT_PORT, timeout=0.2) + def _get_volume(self): self._ensure_open_device() self._device.write('MV?\r') diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index 2844f579..e12b8b92 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -75,10 +75,7 @@ class NadTalker(ThreadingActor): def __init__(self): self._device = None - # TODO-PYKKA: Do after actor starts? - self._setup() - - def _setup(self): + def post_start(self): self._open_connection() self._set_device_to_known_state() diff --git a/mopidy/outputs/gstreamer.py b/mopidy/outputs/gstreamer.py index b0b98d99..2a3d9adc 100644 --- a/mopidy/outputs/gstreamer.py +++ b/mopidy/outputs/gstreamer.py @@ -24,7 +24,7 @@ class GStreamerOutput(ThreadingActor, BaseOutput): def __init__(self): self.gst_pipeline = None - # TODO-PYKKA: Run setup after actor starts? + def post_start(self): self._setup_gstreamer() def _setup_gstreamer(self): From d8ea7ea884ad4dc6f4a06e88c08cf76bec7dc066 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 9 Mar 2011 19:30:12 +0100 Subject: [PATCH 21/65] Lookup other actors by their known superclasses --- mopidy/backends/spotify/session_manager.py | 8 ++++---- mopidy/frontends/mpd/dispatcher.py | 8 ++++---- mopidy/mixers/gstreamer_software.py | 11 +++++++---- 3 files changed, 15 insertions(+), 12 deletions(-) diff --git a/mopidy/backends/spotify/session_manager.py b/mopidy/backends/spotify/session_manager.py index d08a7c97..b79fc48f 100644 --- a/mopidy/backends/spotify/session_manager.py +++ b/mopidy/backends/spotify/session_manager.py @@ -5,11 +5,11 @@ import threading from spotify.manager import SpotifySessionManager as PyspotifySessionManager from pykka.registry import ActorRegistry -from pykka.proxy import ActorProxy from mopidy import get_version, settings from mopidy.backends.spotify.translator import SpotifyTranslator from mopidy.models import Playlist +from mopidy.outputs.base import BaseOutput from mopidy.utils.process import BaseThread logger = logging.getLogger('mopidy.backends.spotify.session_manager') @@ -28,9 +28,9 @@ class SpotifySessionManager(BaseThread, PyspotifySessionManager): BaseThread.__init__(self) self.name = 'SpotifySMThread' - # TODO-PYKKA Get reference to output without hardcoding GStreamerOutput - output_refs = ActorRegistry.get_by_class_name('GStreamerOutput') - self.output = ActorProxy(output_refs[0]) + output_refs = ActorRegistry.get_by_class(BaseOutput) + assert len(output_refs) == 1, 'Expected exactly one running output.' + self.output = output_refs[0].proxy() self.connected = threading.Event() self.session = None diff --git a/mopidy/frontends/mpd/dispatcher.py b/mopidy/frontends/mpd/dispatcher.py index 932eb3e3..b934070e 100644 --- a/mopidy/frontends/mpd/dispatcher.py +++ b/mopidy/frontends/mpd/dispatcher.py @@ -1,8 +1,8 @@ import re -from pykka.proxy import ActorProxy from pykka.registry import ActorRegistry +from mopidy.backends.base import Backend from mopidy.frontends.mpd.exceptions import (MpdAckError, MpdArgError, MpdUnknownCommand) from mopidy.frontends.mpd.protocol import mpd_commands, request_handlers @@ -27,9 +27,9 @@ class MpdDispatcher(object): def __init__(self, session): self.session = session - # TODO-PYKKA: Get reference to backend in a more generic way - backend_refs = ActorRegistry.get_by_class_name('SpotifyBackend') - self.backend = ActorProxy(backend_refs[0]) + backend_refs = ActorRegistry.get_by_class(Backend) + assert len(backend_refs) == 1, 'Expected exactly one running backend.' + self.backend = backend_refs[0].proxy() self.command_list = False self.command_list_ok = False diff --git a/mopidy/mixers/gstreamer_software.py b/mopidy/mixers/gstreamer_software.py index f9d171ca..2125aab3 100644 --- a/mopidy/mixers/gstreamer_software.py +++ b/mopidy/mixers/gstreamer_software.py @@ -1,16 +1,19 @@ from pykka.actor import ThreadingActor -from pykka.proxy import ActorProxy from pykka.registry import ActorRegistry from mopidy.mixers.base import BaseMixer +from mopidy.outputs.base import BaseOutput class GStreamerSoftwareMixer(ThreadingActor, BaseMixer): """Mixer which uses GStreamer to control volume in software.""" def __init__(self): - # TODO-PYKKA Get reference to output without hardcoding GStreamerOutput - output_refs = ActorRegistry.get_by_class_name('GStreamerOutput') - self.output = ActorProxy(output_refs[0]) + self.output = None + + def post_start(self): + output_refs = ActorRegistry.get_by_class(BaseOutput) + assert len(output_refs) == 1, 'Expected exactly one running output.' + self.output = output_refs[0].proxy() def _get_volume(self): return self.output.get_volume().get() From 650f7773064a9d854c10528cc41c303cd19f35a9 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 9 Mar 2011 20:37:23 +0100 Subject: [PATCH 22/65] Reimplement pause on lost play token and setting of stored playlists --- mopidy/backends/spotify/session_manager.py | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/mopidy/backends/spotify/session_manager.py b/mopidy/backends/spotify/session_manager.py index b79fc48f..ed4d665c 100644 --- a/mopidy/backends/spotify/session_manager.py +++ b/mopidy/backends/spotify/session_manager.py @@ -7,6 +7,7 @@ from spotify.manager import SpotifySessionManager as PyspotifySessionManager from pykka.registry import ActorRegistry from mopidy import get_version, settings +from mopidy.backends.base import Backend from mopidy.backends.spotify.translator import SpotifyTranslator from mopidy.models import Playlist from mopidy.outputs.base import BaseOutput @@ -28,16 +29,25 @@ class SpotifySessionManager(BaseThread, PyspotifySessionManager): BaseThread.__init__(self) self.name = 'SpotifySMThread' - output_refs = ActorRegistry.get_by_class(BaseOutput) - assert len(output_refs) == 1, 'Expected exactly one running output.' - self.output = output_refs[0].proxy() + self.output = None + self.backend = None self.connected = threading.Event() self.session = None def run_inside_try(self): + self.setup() self.connect() + def setup(self): + output_refs = ActorRegistry.get_by_class(BaseOutput) + assert len(output_refs) == 1, 'Expected exactly one running output.' + self.output = output_refs[0].proxy() + + backend_refs = ActorRegistry.get_by_class(Backend) + assert len(backend_refs) == 1, 'Expected exactly one running backend.' + self.backend = backend_refs[0].proxy() + def logged_in(self, session, error): """Callback used by pyspotify""" logger.info(u'Connected to Spotify') @@ -94,7 +104,7 @@ class SpotifySessionManager(BaseThread, PyspotifySessionManager): def play_token_lost(self, session): """Callback used by pyspotify""" logger.debug(u'Play token lost') - # TODO-PYKKA: Send 'stop_playback' to backend + self.backend.playback.pause() def log_message(self, session, data): """Callback used by pyspotify""" @@ -113,7 +123,7 @@ class SpotifySessionManager(BaseThread, PyspotifySessionManager): playlists.append( SpotifyTranslator.to_mopidy_playlist(spotify_playlist)) playlists = filter(None, playlists) - # TODO-PYKKA: Set stored_playlists on backend + self.backend.stored_playlists = playlists logger.debug(u'Refreshed %d stored playlist(s)', len(playlists)) def search(self, query, connection): From 8c163104d116bbd479a5cf14d83c1c439479dd9a Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 9 Mar 2011 21:37:47 +0100 Subject: [PATCH 23/65] Reimplement sending of started/stopped_playing events from the backend to interested frontends --- mopidy/backends/base/playback.py | 22 ++++++++++++++-------- mopidy/frontends/lastfm.py | 8 ++++++++ mopidy/frontends/mpd/__init__.py | 3 +++ 3 files changed, 25 insertions(+), 8 deletions(-) diff --git a/mopidy/backends/base/playback.py b/mopidy/backends/base/playback.py index e4ffa075..80133c33 100644 --- a/mopidy/backends/base/playback.py +++ b/mopidy/backends/base/playback.py @@ -2,6 +2,10 @@ import logging import random import time +from pykka.registry import ActorRegistry + +from mopidy.frontends.base import BaseFrontend + logger = logging.getLogger('mopidy.backends.base') class PlaybackController(object): @@ -463,10 +467,11 @@ class PlaybackController(object): For internal use only. Should be called by the backend directly after a track has started playing. """ - return # TODO-PYKKA Send started_playing event to interested parties - if self.current_track is not None: - self.backend.core_queue.put({ - 'to': 'frontend', + if self.current_track is None: + return + frontend_refs = ActorRegistry.get_by_class(BaseFrontend) + for frontend_ref in frontend_refs: + frontend_ref.send_one_way({ 'command': 'started_playing', 'track': self.current_track, }) @@ -479,10 +484,11 @@ class PlaybackController(object): is stopped playing, e.g. at the next, previous, and stop actions and at end-of-track. """ - return # TODO-PYKKA Send stopped_playing event to interested parties - if self.current_track is not None: - self.backend.core_queue.put({ - 'to': 'frontend', + if self.current_track is None: + return + frontend_refs = ActorRegistry.get_by_class(BaseFrontend) + for frontend_ref in frontend_refs: + frontend_ref.send_one_way({ 'command': 'stopped_playing', 'track': self.current_track, 'stop_position': self.time_position, diff --git a/mopidy/frontends/lastfm.py b/mopidy/frontends/lastfm.py index 4a703c22..d723052e 100644 --- a/mopidy/frontends/lastfm.py +++ b/mopidy/frontends/lastfm.py @@ -58,6 +58,14 @@ class LastfmFrontend(ThreadingActor, BaseFrontend): logger.error(u'Error during Last.fm setup: %s', e) self.stop() + def react(self, message): + if message.get('command') == 'started_playing': + self.started_playing(message['track']) + elif message.get('command') == 'stopped_playing': + self.stopped_playing(message['track'], message['stop_position']) + else: + pass # Ignore any other messages + def started_playing(self, track): artists = ', '.join([a.name for a in track.artists]) duration = track.length and track.length // 1000 or 0 diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index 96500d9b..c7f469dd 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -27,6 +27,9 @@ class MpdFrontend(ThreadingActor, BaseFrontend): self._thread = MpdThread() self._thread.start() + def react(self, message): + pass # Ignore any messages + class MpdThread(BaseThread): def __init__(self): From 9b77d34e24ea8619cf159d4c0109f7fbed5567b0 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 9 Mar 2011 21:41:32 +0100 Subject: [PATCH 24/65] Move AlsaMixer initialization to post_start() --- mopidy/mixers/alsa.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mopidy/mixers/alsa.py b/mopidy/mixers/alsa.py index f4f40ca1..f19819e8 100644 --- a/mopidy/mixers/alsa.py +++ b/mopidy/mixers/alsa.py @@ -23,7 +23,9 @@ class AlsaMixer(ThreadingActor, BaseMixer): """ def __init__(self): - # PYKKA-TODO: Do mixer detection after actor starts? + self._mixer = None + + def post_start(self): self._mixer = alsaaudio.Mixer(self._get_mixer_control()) assert self._mixer is not None From 985213ffa2bd463bb185e3407fe08b868b97244f Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 9 Mar 2011 21:46:18 +0100 Subject: [PATCH 25/65] Remove unused import --- mopidy/backends/local/__init__.py | 1 - 1 file changed, 1 deletion(-) diff --git a/mopidy/backends/local/__init__.py b/mopidy/backends/local/__init__.py index c5b42b74..db2eab37 100644 --- a/mopidy/backends/local/__init__.py +++ b/mopidy/backends/local/__init__.py @@ -12,7 +12,6 @@ from mopidy.backends.base import (Backend, CurrentPlaylistController, BasePlaybackProvider, StoredPlaylistsController, BaseStoredPlaylistsProvider) from mopidy.models import Playlist, Track, Album -from mopidy.utils.process import pickle_connection from .translator import parse_m3u, parse_mpd_tag_cache From 46c6ee68df97629a7d411aabefe560ee0eaca0ef Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Thu, 10 Mar 2011 23:19:44 +0100 Subject: [PATCH 26/65] Fix ~200 backend tests --- docs/development/contributing.rst | 4 ++-- mopidy/backends/local/__init__.py | 9 +++++++++ mopidy/outputs/dummy.py | 4 +++- requirements/tests.txt | 1 + tests/backends/base/current_playlist.py | 14 ++++---------- tests/backends/base/library.py | 6 +----- tests/backends/base/playback.py | 16 ++++++---------- tests/backends/base/stored_playlists.py | 5 +---- tests/backends/local/stored_playlists_test.py | 3 +-- 9 files changed, 28 insertions(+), 34 deletions(-) diff --git a/docs/development/contributing.rst b/docs/development/contributing.rst index fbc7baee..9ea3533f 100644 --- a/docs/development/contributing.rst +++ b/docs/development/contributing.rst @@ -74,11 +74,11 @@ Running tests To run tests, you need a couple of dependencies. They can be installed through Debian/Ubuntu package management:: - sudo aptitude install python-coverage python-nose + sudo aptitude install python-coverage python-mock python-nose Or, they can be installed using ``pip``:: - sudo pip install -r requirements-tests.txt + sudo pip install -r requirements/tests.txt Then, to run all tests, go to the project directory and run:: diff --git a/mopidy/backends/local/__init__.py b/mopidy/backends/local/__init__.py index db2eab37..80762c89 100644 --- a/mopidy/backends/local/__init__.py +++ b/mopidy/backends/local/__init__.py @@ -5,6 +5,7 @@ import os import shutil from pykka.actor import ThreadingActor +from pykka.registry import ActorRegistry from mopidy import settings from mopidy.backends.base import (Backend, CurrentPlaylistController, @@ -12,6 +13,7 @@ from mopidy.backends.base import (Backend, CurrentPlaylistController, BasePlaybackProvider, StoredPlaylistsController, BaseStoredPlaylistsProvider) from mopidy.models import Playlist, Track, Album +from mopidy.outputs.base import BaseOutput from .translator import parse_m3u, parse_mpd_tag_cache @@ -49,6 +51,13 @@ class LocalBackend(ThreadingActor, Backend): self.uri_handlers = [u'file://'] + self.output = None + + def post_start(self): + output_refs = ActorRegistry.get_by_class(BaseOutput) + assert len(output_refs) == 1, 'Expected exactly one running output.' + self.output = output_refs[0].proxy() + class LocalPlaybackController(PlaybackController): def __init__(self, *args, **kwargs): diff --git a/mopidy/outputs/dummy.py b/mopidy/outputs/dummy.py index 738575f3..f09965f7 100644 --- a/mopidy/outputs/dummy.py +++ b/mopidy/outputs/dummy.py @@ -1,6 +1,8 @@ +from pykka.actor import ThreadingActor + from mopidy.outputs.base import BaseOutput -class DummyOutput(BaseOutput): +class DummyOutput(ThreadingActor, BaseOutput): """ Audio output used for testing. """ diff --git a/requirements/tests.txt b/requirements/tests.txt index 33f49451..fb54268f 100644 --- a/requirements/tests.txt +++ b/requirements/tests.txt @@ -1,2 +1,3 @@ coverage +mock nose diff --git a/tests/backends/base/current_playlist.py b/tests/backends/base/current_playlist.py index c2a9df6f..ee5e1111 100644 --- a/tests/backends/base/current_playlist.py +++ b/tests/backends/base/current_playlist.py @@ -1,9 +1,9 @@ +import mock import multiprocessing import random -from mopidy.mixers.dummy import DummyMixer from mopidy.models import Playlist, Track -from mopidy.outputs.dummy import DummyOutput +from mopidy.outputs.base import BaseOutput from tests.backends.base import populate_playlist @@ -11,19 +11,13 @@ class CurrentPlaylistControllerTest(object): tracks = [] def setUp(self): - self.core_queue = multiprocessing.Queue() - self.output = DummyOutput(self.core_queue) - self.backend = self.backend_class( - self.core_queue, self.output, DummyMixer) + self.backend = self.backend_class() + self.backend.output = mock.Mock(spec=BaseOutput) self.controller = self.backend.current_playlist self.playback = self.backend.playback assert len(self.tracks) == 3, 'Need three tracks to run tests.' - def tearDown(self): - self.backend.destroy() - self.output.destroy() - def test_add(self): for track in self.tracks: cp_track = self.controller.add(track) diff --git a/tests/backends/base/library.py b/tests/backends/base/library.py index 71f62147..bff26c4c 100644 --- a/tests/backends/base/library.py +++ b/tests/backends/base/library.py @@ -1,4 +1,3 @@ -from mopidy.mixers.dummy import DummyMixer from mopidy.models import Playlist, Track, Album, Artist from tests import SkipTest, data_folder @@ -15,12 +14,9 @@ class LibraryControllerTest(object): Track()] def setUp(self): - self.backend = self.backend_class(mixer_class=DummyMixer) + self.backend = self.backend_class() self.library = self.backend.library - def tearDown(self): - self.backend.destroy() - def test_refresh(self): self.library.refresh() diff --git a/tests/backends/base/playback.py b/tests/backends/base/playback.py index 77eb012d..aa200047 100644 --- a/tests/backends/base/playback.py +++ b/tests/backends/base/playback.py @@ -1,10 +1,10 @@ +import mock import multiprocessing import random import time -from mopidy.mixers.dummy import DummyMixer from mopidy.models import Track -from mopidy.outputs.dummy import DummyOutput +from mopidy.outputs.base import BaseOutput from tests import SkipTest from tests.backends.base import populate_playlist @@ -15,10 +15,8 @@ class PlaybackControllerTest(object): tracks = [] def setUp(self): - self.core_queue = multiprocessing.Queue() - self.output = DummyOutput(self.core_queue) - self.backend = self.backend_class( - self.core_queue, self.output, DummyMixer) + self.backend = self.backend_class() + self.backend.output = mock.Mock(spec=BaseOutput) self.playback = self.backend.playback self.current_playlist = self.backend.current_playlist @@ -27,10 +25,6 @@ class PlaybackControllerTest(object): assert self.tracks[0].length >= 2000, \ 'First song needs to be at least 2000 miliseconds' - def tearDown(self): - self.backend.destroy() - self.output.destroy() - def test_initial_state_is_stopped(self): self.assertEqual(self.playback.state, self.playback.STOPPED) @@ -733,10 +727,12 @@ class PlaybackControllerTest(object): self.assertEqual(self.playback.stop(), None) def test_time_position_when_stopped(self): + self.backend.output.get_position = mock.Mock(return_value=0) self.assertEqual(self.playback.time_position, 0) @populate_playlist def test_time_position_when_stopped_with_playlist(self): + self.backend.output.get_position = mock.Mock(return_value=0) self.assertEqual(self.playback.time_position, 0) @SkipTest # Uses sleep and does not work with LocalBackend+DummyOutput diff --git a/tests/backends/base/stored_playlists.py b/tests/backends/base/stored_playlists.py index 0ac0b167..12e48256 100644 --- a/tests/backends/base/stored_playlists.py +++ b/tests/backends/base/stored_playlists.py @@ -3,7 +3,6 @@ import shutil import tempfile from mopidy import settings -from mopidy.mixers.dummy import DummyMixer from mopidy.models import Playlist from tests import SkipTest, data_folder @@ -14,12 +13,10 @@ class StoredPlaylistsControllerTest(object): settings.LOCAL_TAG_CACHE_FILE = data_folder('library_tag_cache') settings.LOCAL_MUSIC_PATH = data_folder('') - self.backend = self.backend_class(mixer_class=DummyMixer) + self.backend = self.backend_class() self.stored = self.backend.stored_playlists def tearDown(self): - self.backend.destroy() - if os.path.exists(settings.LOCAL_PLAYLIST_PATH): shutil.rmtree(settings.LOCAL_PLAYLIST_PATH) diff --git a/tests/backends/local/stored_playlists_test.py b/tests/backends/local/stored_playlists_test.py index a7d9043f..5bc16d1c 100644 --- a/tests/backends/local/stored_playlists_test.py +++ b/tests/backends/local/stored_playlists_test.py @@ -70,8 +70,7 @@ class LocalStoredPlaylistsControllerTest(StoredPlaylistsControllerTest, self.stored.save(playlist) - self.backend.destroy() - self.backend = self.backend_class(mixer_class=DummyMixer) + self.backend = self.backend_class() self.stored = self.backend.stored_playlists self.assert_(self.stored.playlists) From 0c6ad8e8f08f1e55a2b6a97c875fdb0e0cb86643 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Thu, 10 Mar 2011 23:23:06 +0100 Subject: [PATCH 27/65] Fix output tests --- tests/outputs/gstreamer_test.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/outputs/gstreamer_test.py b/tests/outputs/gstreamer_test.py index b4cb5ef9..801f476e 100644 --- a/tests/outputs/gstreamer_test.py +++ b/tests/outputs/gstreamer_test.py @@ -18,12 +18,10 @@ class GStreamerOutputTest(unittest.TestCase): def setUp(self): settings.BACKENDS = ('mopidy.backends.local.LocalBackend',) self.song_uri = path_to_uri(data_folder('song1.wav')) - self.core_queue = multiprocessing.Queue() - self.output = GStreamerOutput(self.core_queue) - self.output.start() + self.output = GStreamerOutput() + self.output.post_start() def tearDown(self): - self.output.destroy() settings.runtime.clear() def test_play_uri_existing_file(self): From 122e13be855d2077c9ddb0ad71806ac42b22cf97 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Thu, 10 Mar 2011 23:23:46 +0100 Subject: [PATCH 28/65] Fix mixer tests --- tests/mixers/base_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/mixers/base_test.py b/tests/mixers/base_test.py index 395d8f7b..54cd8773 100644 --- a/tests/mixers/base_test.py +++ b/tests/mixers/base_test.py @@ -11,7 +11,7 @@ class BaseMixerTest(object): assert self.mixer_class is not None, \ "mixer_class must be set in subclass" # pylint: disable = E1102 - self.mixer = self.mixer_class(None) + self.mixer = self.mixer_class() # pylint: enable = E1102 def test_initial_volume(self): From 49d62aecab3d860dfad048b3683d3cbe5795681f Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 15:55:25 +0100 Subject: [PATCH 29/65] Do not give MpdDispatcher an MpdSession object yet, as it is not needed to get current tests passing --- mopidy/frontends/mpd/dispatcher.py | 4 +--- mopidy/frontends/mpd/session.py | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/mopidy/frontends/mpd/dispatcher.py b/mopidy/frontends/mpd/dispatcher.py index b934070e..c1249028 100644 --- a/mopidy/frontends/mpd/dispatcher.py +++ b/mopidy/frontends/mpd/dispatcher.py @@ -24,9 +24,7 @@ class MpdDispatcher(object): # XXX Consider merging MpdDispatcher into MpdSession - def __init__(self, session): - self.session = session - + def __init__(self): backend_refs = ActorRegistry.get_by_class(Backend) assert len(backend_refs) == 1, 'Expected exactly one running backend.' self.backend = backend_refs[0].proxy() diff --git a/mopidy/frontends/mpd/session.py b/mopidy/frontends/mpd/session.py index eb8c4f11..78e6f624 100644 --- a/mopidy/frontends/mpd/session.py +++ b/mopidy/frontends/mpd/session.py @@ -23,7 +23,7 @@ class MpdSession(asynchat.async_chat): self.input_buffer = [] self.authenticated = False self.set_terminator(LINE_TERMINATOR.encode(ENCODING)) - self.dispatcher = MpdDispatcher(self) + self.dispatcher = MpdDispatcher() def start(self): """Start a new client session.""" From a4a015af1d6ed099cf68efe85235a57d452442e5 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 16:05:22 +0100 Subject: [PATCH 30/65] Update MPD/audio_output --- mopidy/frontends/mpd/protocol/audio_output.py | 2 +- tests/frontends/mpd/audio_output_test.py | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/audio_output.py b/mopidy/frontends/mpd/protocol/audio_output.py index d25fc118..98c1d645 100644 --- a/mopidy/frontends/mpd/protocol/audio_output.py +++ b/mopidy/frontends/mpd/protocol/audio_output.py @@ -34,6 +34,6 @@ def outputs(frontend): """ return [ ('outputid', 0), - ('outputname', frontend.backend.__class__.__name__), + ('outputname', None), ('outputenabled', 1), ] diff --git a/tests/frontends/mpd/audio_output_test.py b/tests/frontends/mpd/audio_output_test.py index b81e727e..d4ddbc92 100644 --- a/tests/frontends/mpd/audio_output_test.py +++ b/tests/frontends/mpd/audio_output_test.py @@ -2,12 +2,14 @@ import unittest from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher -from mopidy.mixers.dummy import DummyMixer class AudioOutputHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() def test_enableoutput(self): result = self.h.handle_request(u'enableoutput "0"') @@ -20,6 +22,6 @@ class AudioOutputHandlerTest(unittest.TestCase): def test_outputs(self): result = self.h.handle_request(u'outputs') self.assert_(u'outputid: 0' in result) - self.assert_(u'outputname: DummyBackend' in result) + self.assert_(u'outputname: None' in result) self.assert_(u'outputenabled: 1' in result) self.assert_(u'OK' in result) From 88780c717b4d1af05c03c0ca5c4a4ce59cde6c81 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 16:05:36 +0100 Subject: [PATCH 31/65] Update MPD/connection --- tests/frontends/mpd/connection_test.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/frontends/mpd/connection_test.py b/tests/frontends/mpd/connection_test.py index 44ce78ca..4d2a309d 100644 --- a/tests/frontends/mpd/connection_test.py +++ b/tests/frontends/mpd/connection_test.py @@ -3,14 +3,14 @@ import unittest from mopidy import settings from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher -from mopidy.mixers.dummy import DummyMixer class ConnectionHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() def tearDown(self): + self.b.stop() settings.runtime.clear() def test_close(self): From c67eb4b973f3431e8716cadd1f05cc597e0b654e Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 16:41:48 +0100 Subject: [PATCH 32/65] Make backend providers traversable so they can be set up for tests --- mopidy/backends/base/library.py | 2 ++ mopidy/backends/base/playback.py | 2 ++ mopidy/backends/base/stored_playlists.py | 4 ++++ 3 files changed, 8 insertions(+) diff --git a/mopidy/backends/base/library.py b/mopidy/backends/base/library.py index 9ca103c0..a30ed412 100644 --- a/mopidy/backends/base/library.py +++ b/mopidy/backends/base/library.py @@ -84,6 +84,8 @@ class BaseLibraryProvider(object): :type backend: :class:`mopidy.backends.base.Backend` """ + pykka_traversable = True + def __init__(self, backend): self.backend = backend diff --git a/mopidy/backends/base/playback.py b/mopidy/backends/base/playback.py index 80133c33..ce63abf7 100644 --- a/mopidy/backends/base/playback.py +++ b/mopidy/backends/base/playback.py @@ -501,6 +501,8 @@ class BasePlaybackProvider(object): :type backend: :class:`mopidy.backends.base.Backend` """ + pykka_traversable = True + def __init__(self, backend): self.backend = backend diff --git a/mopidy/backends/base/stored_playlists.py b/mopidy/backends/base/stored_playlists.py index 6578c046..aca78a8c 100644 --- a/mopidy/backends/base/stored_playlists.py +++ b/mopidy/backends/base/stored_playlists.py @@ -11,6 +11,8 @@ class StoredPlaylistsController(object): :type provider: instance of :class:`BaseStoredPlaylistsProvider` """ + pykka_traversable = True + def __init__(self, backend, provider): self.backend = backend self.provider = provider @@ -125,6 +127,8 @@ class BaseStoredPlaylistsProvider(object): :type backend: :class:`mopidy.backends.base.Backend` """ + pykka_traversable = True + def __init__(self, backend): self.backend = backend self._playlists = [] From 462f9d3afb52757c51eead2ce4b14c530641adf3 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 17:08:05 +0100 Subject: [PATCH 33/65] Make dummy library available through actor proxies --- mopidy/backends/dummy/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mopidy/backends/dummy/__init__.py b/mopidy/backends/dummy/__init__.py index 82051188..90c87dac 100644 --- a/mopidy/backends/dummy/__init__.py +++ b/mopidy/backends/dummy/__init__.py @@ -38,13 +38,13 @@ class DummyBackend(ThreadingActor, Backend): class DummyLibraryProvider(BaseLibraryProvider): def __init__(self, *args, **kwargs): super(DummyLibraryProvider, self).__init__(*args, **kwargs) - self._library = [] + self.dummy_library = [] def find_exact(self, **query): return Playlist() def lookup(self, uri): - matches = filter(lambda t: uri == t.uri, self._library) + matches = filter(lambda t: uri == t.uri, self.dummy_library) if matches: return matches[0] From 0d57a74cb3bdcc552d3bd18bb00d01b18d1ddf74 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 17:46:22 +0100 Subject: [PATCH 34/65] Update MPD/current_playlist --- .../mpd/protocol/current_playlist.py | 82 ++++--- tests/frontends/mpd/current_playlist_test.py | 206 +++++++++--------- 2 files changed, 153 insertions(+), 135 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/current_playlist.py b/mopidy/frontends/mpd/protocol/current_playlist.py index 13635a33..8ef5e026 100644 --- a/mopidy/frontends/mpd/protocol/current_playlist.py +++ b/mopidy/frontends/mpd/protocol/current_playlist.py @@ -19,9 +19,9 @@ def add(frontend, uri): """ if not uri: return - for handler_prefix in frontend.backend.uri_handlers: + for handler_prefix in frontend.backend.uri_handlers.get(): if uri.startswith(handler_prefix): - track = frontend.backend.library.lookup(uri) + track = frontend.backend.library.lookup(uri).get() if track is not None: frontend.backend.current_playlist.add(track) return @@ -51,13 +51,14 @@ def addid(frontend, uri, songpos=None): raise MpdNoExistError(u'No such song', command=u'addid') if songpos is not None: songpos = int(songpos) - track = frontend.backend.library.lookup(uri) + track = frontend.backend.library.lookup(uri).get() if track is None: raise MpdNoExistError(u'No such song', command=u'addid') - if songpos and songpos > len(frontend.backend.current_playlist.tracks): + if songpos and songpos > len( + frontend.backend.current_playlist.tracks.get()): raise MpdArgError(u'Bad song index', command=u'addid') cp_track = frontend.backend.current_playlist.add(track, - at_position=songpos) + at_position=songpos).get() return ('Id', cp_track[0]) @handle_pattern(r'^delete "(?P\d+):(?P\d+)*"$') @@ -73,8 +74,8 @@ def delete_range(frontend, start, end=None): if end is not None: end = int(end) else: - end = len(frontend.backend.current_playlist.tracks) - cp_tracks = frontend.backend.current_playlist.cp_tracks[start:end] + end = len(frontend.backend.current_playlist.tracks.get()) + cp_tracks = frontend.backend.current_playlist.cp_tracks.get()[start:end] if not cp_tracks: raise MpdArgError(u'Bad song index', command=u'delete') for (cpid, _) in cp_tracks: @@ -85,7 +86,7 @@ def delete_songpos(frontend, songpos): """See :meth:`delete_range`""" try: songpos = int(songpos) - (cpid, _) = frontend.backend.current_playlist.cp_tracks[songpos] + (cpid, _) = frontend.backend.current_playlist.cp_tracks.get()[songpos] frontend.backend.current_playlist.remove(cpid=cpid) except IndexError: raise MpdArgError(u'Bad song index', command=u'delete') @@ -101,9 +102,9 @@ def deleteid(frontend, cpid): """ try: cpid = int(cpid) - if frontend.backend.playback.current_cpid == cpid: + if frontend.backend.playback.current_cpid.get() == cpid: frontend.backend.playback.next() - return frontend.backend.current_playlist.remove(cpid=cpid) + return frontend.backend.current_playlist.remove(cpid=cpid).get() except LookupError: raise MpdNoExistError(u'No such song', command=u'deleteid') @@ -129,7 +130,7 @@ def move_range(frontend, start, to, end=None): ``TO`` in the playlist. """ if end is None: - end = len(frontend.backend.current_playlist.tracks) + end = len(frontend.backend.current_playlist.tracks.get()) start = int(start) end = int(end) to = int(to) @@ -155,8 +156,9 @@ def moveid(frontend, cpid, to): """ cpid = int(cpid) to = int(to) - cp_track = frontend.backend.current_playlist.get(cpid=cpid) - position = frontend.backend.current_playlist.cp_tracks.index(cp_track) + cp_track = frontend.backend.current_playlist.get(cpid=cpid).get() + position = frontend.backend.current_playlist.cp_tracks.get().index( + cp_track) frontend.backend.current_playlist.move(position, position + 1, to) @handle_pattern(r'^playlist$') @@ -190,9 +192,9 @@ def playlistfind(frontend, tag, needle): """ if tag == 'filename': try: - cp_track = frontend.backend.current_playlist.get(uri=needle) + cp_track = frontend.backend.current_playlist.get(uri=needle).get() (cpid, track) = cp_track - position = frontend.backend.current_playlist.cp_tracks.index( + position = frontend.backend.current_playlist.cp_tracks.get().index( cp_track) return track.mpd_format(cpid=cpid, position=position) except LookupError: @@ -212,16 +214,17 @@ def playlistid(frontend, cpid=None): if cpid is not None: try: cpid = int(cpid) - cp_track = frontend.backend.current_playlist.get(cpid=cpid) - position = frontend.backend.current_playlist.cp_tracks.index( + cp_track = frontend.backend.current_playlist.get(cpid=cpid).get() + position = frontend.backend.current_playlist.cp_tracks.get().index( cp_track) return cp_track[1].mpd_format(position=position, cpid=cpid) except LookupError: raise MpdNoExistError(u'No such song', command=u'playlistid') else: - cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] - return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, - cpids=cpids) + cpids = [ct[0] for ct in + frontend.backend.current_playlist.cp_tracks.get()] + return tracks_to_mpd_format( + frontend.backend.current_playlist.tracks.get(), cpids=cpids) @handle_pattern(r'^playlistinfo$') @handle_pattern(r'^playlistinfo "(?P-?\d+)"$') @@ -251,21 +254,26 @@ def playlistinfo(frontend, songpos=None, end = songpos + 1 if start == -1: end = None - cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] - return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, + cpids = [ct[0] for ct in + frontend.backend.current_playlist.cp_tracks.get()] + return tracks_to_mpd_format( + frontend.backend.current_playlist.tracks.get(), start, end, cpids=cpids) else: if start is None: start = 0 start = int(start) - if not (0 <= start <= len(frontend.backend.current_playlist.tracks)): + if not (0 <= start <= len( + frontend.backend.current_playlist.tracks.get())): raise MpdArgError(u'Bad song index', command=u'playlistinfo') if end is not None: end = int(end) - if end > len(frontend.backend.current_playlist.tracks): + if end > len(frontend.backend.current_playlist.tracks.get()): end = None - cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] - return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, + cpids = [ct[0] for ct in + frontend.backend.current_playlist.cp_tracks.get()] + return tracks_to_mpd_format( + frontend.backend.current_playlist.tracks.get(), start, end, cpids=cpids) @handle_pattern(r'^playlistsearch "(?P[^"]+)" "(?P[^"]+)"$') @@ -305,9 +313,10 @@ def plchanges(frontend, version): """ # XXX Naive implementation that returns all tracks as changed if int(version) < frontend.backend.current_playlist.version: - cpids = [ct[0] for ct in frontend.backend.current_playlist.cp_tracks] - return tracks_to_mpd_format(frontend.backend.current_playlist.tracks, - cpids=cpids) + cpids = [ct[0] for ct in + frontend.backend.current_playlist.cp_tracks.get()] + return tracks_to_mpd_format( + frontend.backend.current_playlist.tracks.get(), cpids=cpids) @handle_pattern(r'^plchangesposid "(?P\d+)"$') def plchangesposid(frontend, version): @@ -324,10 +333,10 @@ def plchangesposid(frontend, version): ``playlistlength`` returned by status command. """ # XXX Naive implementation that returns all tracks as changed - if int(version) != frontend.backend.current_playlist.version: + if int(version) != frontend.backend.current_playlist.version.get(): result = [] for (position, (cpid, _)) in enumerate( - frontend.backend.current_playlist.cp_tracks): + frontend.backend.current_playlist.cp_tracks.get()): result.append((u'cpos', position)) result.append((u'Id', cpid)) return result @@ -360,7 +369,7 @@ def swap(frontend, songpos1, songpos2): """ songpos1 = int(songpos1) songpos2 = int(songpos2) - tracks = frontend.backend.current_playlist.tracks + tracks = frontend.backend.current_playlist.tracks.get() song1 = tracks[songpos1] song2 = tracks[songpos2] del tracks[songpos1] @@ -381,8 +390,9 @@ def swapid(frontend, cpid1, cpid2): """ cpid1 = int(cpid1) cpid2 = int(cpid2) - cp_track1 = frontend.backend.current_playlist.get(cpid=cpid1) - cp_track2 = frontend.backend.current_playlist.get(cpid=cpid2) - position1 = frontend.backend.current_playlist.cp_tracks.index(cp_track1) - position2 = frontend.backend.current_playlist.cp_tracks.index(cp_track2) + cp_track1 = frontend.backend.current_playlist.get(cpid=cpid1).get() + cp_track2 = frontend.backend.current_playlist.get(cpid=cpid2).get() + cp_tracks = frontend.backend.current_playlist.cp_tracks.get() + position1 = cp_tracks.index(cp_track1) + position2 = cp_tracks.index(cp_track2) swap(frontend, position1, position2) diff --git a/tests/frontends/mpd/current_playlist_test.py b/tests/frontends/mpd/current_playlist_test.py index a4179637..8e189dee 100644 --- a/tests/frontends/mpd/current_playlist_test.py +++ b/tests/frontends/mpd/current_playlist_test.py @@ -2,31 +2,28 @@ import unittest from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher -from mopidy.mixers.dummy import DummyMixer from mopidy.models import Track class CurrentPlaylistHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() def test_add(self): needle = Track(uri='dummy://foo') - self.b.library.provider._library = [Track(), Track(), needle, Track()] + self.b.library.provider.dummy_library = [ + Track(), Track(), needle, Track()] self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'add "dummy://foo"') - self.assertEqual(len(self.b.current_playlist.tracks), 6) - self.assertEqual(self.b.current_playlist.tracks[5], needle) self.assertEqual(len(result), 1) - self.assert_(u'OK' in result) - - def test_add_with_uri_not_found_in_library_should_not_call_lookup(self): - self.b.library.lookup = lambda uri: self.fail("Shouldn't run") - result = self.h.handle_request(u'add "foo"') - self.assertEqual(result[0], - u'ACK [50@0] {add} directory or file not found') + self.assertEqual(result[0], u'OK') + self.assertEqual(len(self.b.current_playlist.tracks.get()), 6) + self.assertEqual(self.b.current_playlist.tracks.get()[5], needle) def test_add_with_uri_not_found_in_library_should_ack(self): result = self.h.handle_request(u'add "dummy://foo"') @@ -40,41 +37,43 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): def test_addid_without_songpos(self): needle = Track(uri='dummy://foo') - self.b.library.provider._library = [Track(), Track(), needle, Track()] + self.b.library.provider.dummy_library = [ + Track(), Track(), needle, Track()] self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'addid "dummy://foo"') - self.assertEqual(len(self.b.current_playlist.tracks), 6) - self.assertEqual(self.b.current_playlist.tracks[5], needle) - self.assert_(u'Id: %d' % self.b.current_playlist.cp_tracks[5][0] + self.assertEqual(len(self.b.current_playlist.tracks.get()), 6) + self.assertEqual(self.b.current_playlist.tracks.get()[5], needle) + self.assert_(u'Id: %d' % self.b.current_playlist.cp_tracks.get()[5][0] in result) self.assert_(u'OK' in result) - def test_addid_with_empty_uri_does_not_lookup_and_acks(self): - self.b.library.lookup = lambda uri: self.fail("Shouldn't run") + def test_addid_with_empty_uri_acks(self): result = self.h.handle_request(u'addid ""') self.assertEqual(result[0], u'ACK [50@0] {addid} No such song') def test_addid_with_songpos(self): needle = Track(uri='dummy://foo') - self.b.library.provider._library = [Track(), Track(), needle, Track()] + self.b.library.provider.dummy_library = [ + Track(), Track(), needle, Track()] self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'addid "dummy://foo" "3"') - self.assertEqual(len(self.b.current_playlist.tracks), 6) - self.assertEqual(self.b.current_playlist.tracks[3], needle) - self.assert_(u'Id: %d' % self.b.current_playlist.cp_tracks[3][0] + self.assertEqual(len(self.b.current_playlist.tracks.get()), 6) + self.assertEqual(self.b.current_playlist.tracks.get()[3], needle) + self.assert_(u'Id: %d' % self.b.current_playlist.cp_tracks.get()[3][0] in result) self.assert_(u'OK' in result) def test_addid_with_songpos_out_of_bounds_should_ack(self): needle = Track(uri='dummy://foo') - self.b.library.provider._library = [Track(), Track(), needle, Track()] + self.b.library.provider.dummy_library = [ + Track(), Track(), needle, Track()] self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'addid "dummy://foo" "6"') self.assertEqual(result[0], u'ACK [2@0] {addid} Bad song index') @@ -85,65 +84,65 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): def test_clear(self): self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'clear') - self.assertEqual(len(self.b.current_playlist.tracks), 0) - self.assertEqual(self.b.playback.current_track, None) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 0) + self.assertEqual(self.b.playback.current_track.get(), None) self.assert_(u'OK' in result) def test_delete_songpos(self): self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'delete "%d"' % - self.b.current_playlist.cp_tracks[2][0]) - self.assertEqual(len(self.b.current_playlist.tracks), 4) + self.b.current_playlist.cp_tracks.get()[2][0]) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 4) self.assert_(u'OK' in result) def test_delete_songpos_out_of_bounds(self): self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'delete "5"') - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) self.assertEqual(result[0], u'ACK [2@0] {delete} Bad song index') def test_delete_open_range(self): self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'delete "1:"') - self.assertEqual(len(self.b.current_playlist.tracks), 1) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 1) self.assert_(u'OK' in result) def test_delete_closed_range(self): self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'delete "1:3"') - self.assertEqual(len(self.b.current_playlist.tracks), 3) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 3) self.assert_(u'OK' in result) def test_delete_range_out_of_bounds(self): self.b.current_playlist.append( [Track(), Track(), Track(), Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) result = self.h.handle_request(u'delete "5:7"') - self.assertEqual(len(self.b.current_playlist.tracks), 5) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 5) self.assertEqual(result[0], u'ACK [2@0] {delete} Bad song index') def test_deleteid(self): self.b.current_playlist.append([Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 2) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 2) result = self.h.handle_request(u'deleteid "1"') - self.assertEqual(len(self.b.current_playlist.tracks), 1) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 1) self.assert_(u'OK' in result) def test_deleteid_does_not_exist(self): self.b.current_playlist.append([Track(), Track()]) - self.assertEqual(len(self.b.current_playlist.tracks), 2) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 2) result = self.h.handle_request(u'deleteid "12345"') - self.assertEqual(len(self.b.current_playlist.tracks), 2) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 2) self.assertEqual(result[0], u'ACK [50@0] {deleteid} No such song') def test_move_songpos(self): @@ -152,12 +151,13 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='d'), Track(name='e'), Track(name='f'), ]) result = self.h.handle_request(u'move "1" "0"') - self.assertEqual(self.b.current_playlist.tracks[0].name, 'b') - self.assertEqual(self.b.current_playlist.tracks[1].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[2].name, 'c') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'd') - self.assertEqual(self.b.current_playlist.tracks[4].name, 'e') - self.assertEqual(self.b.current_playlist.tracks[5].name, 'f') + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'b') + self.assertEqual(tracks[1].name, 'a') + self.assertEqual(tracks[2].name, 'c') + self.assertEqual(tracks[3].name, 'd') + self.assertEqual(tracks[4].name, 'e') + self.assertEqual(tracks[5].name, 'f') self.assert_(u'OK' in result) def test_move_open_range(self): @@ -166,12 +166,13 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='d'), Track(name='e'), Track(name='f'), ]) result = self.h.handle_request(u'move "2:" "0"') - self.assertEqual(self.b.current_playlist.tracks[0].name, 'c') - self.assertEqual(self.b.current_playlist.tracks[1].name, 'd') - self.assertEqual(self.b.current_playlist.tracks[2].name, 'e') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'f') - self.assertEqual(self.b.current_playlist.tracks[4].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[5].name, 'b') + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'c') + self.assertEqual(tracks[1].name, 'd') + self.assertEqual(tracks[2].name, 'e') + self.assertEqual(tracks[3].name, 'f') + self.assertEqual(tracks[4].name, 'a') + self.assertEqual(tracks[5].name, 'b') self.assert_(u'OK' in result) def test_move_closed_range(self): @@ -180,12 +181,13 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='d'), Track(name='e'), Track(name='f'), ]) result = self.h.handle_request(u'move "1:3" "0"') - self.assertEqual(self.b.current_playlist.tracks[0].name, 'b') - self.assertEqual(self.b.current_playlist.tracks[1].name, 'c') - self.assertEqual(self.b.current_playlist.tracks[2].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'd') - self.assertEqual(self.b.current_playlist.tracks[4].name, 'e') - self.assertEqual(self.b.current_playlist.tracks[5].name, 'f') + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'b') + self.assertEqual(tracks[1].name, 'c') + self.assertEqual(tracks[2].name, 'a') + self.assertEqual(tracks[3].name, 'd') + self.assertEqual(tracks[4].name, 'e') + self.assertEqual(tracks[5].name, 'f') self.assert_(u'OK' in result) def test_moveid(self): @@ -194,12 +196,13 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='d'), Track(name='e'), Track(name='f'), ]) result = self.h.handle_request(u'moveid "4" "2"') - self.assertEqual(self.b.current_playlist.tracks[0].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[1].name, 'b') - self.assertEqual(self.b.current_playlist.tracks[2].name, 'e') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'c') - self.assertEqual(self.b.current_playlist.tracks[4].name, 'd') - self.assertEqual(self.b.current_playlist.tracks[5].name, 'f') + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'a') + self.assertEqual(tracks[1].name, 'b') + self.assertEqual(tracks[2].name, 'e') + self.assertEqual(tracks[3].name, 'c') + self.assertEqual(tracks[4].name, 'd') + self.assertEqual(tracks[5].name, 'f') self.assert_(u'OK' in result) def test_playlist_returns_same_as_playlistinfo(self): @@ -361,14 +364,15 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): def test_plchangesposid(self): self.b.current_playlist.append([Track(), Track(), Track()]) result = self.h.handle_request(u'plchangesposid "0"') + cp_tracks = self.b.current_playlist.cp_tracks.get() self.assert_(u'cpos: 0' in result) - self.assert_(u'Id: %d' % self.b.current_playlist.cp_tracks[0][0] + self.assert_(u'Id: %d' % cp_tracks[0][0] in result) self.assert_(u'cpos: 2' in result) - self.assert_(u'Id: %d' % self.b.current_playlist.cp_tracks[1][0] + self.assert_(u'Id: %d' % cp_tracks[1][0] in result) self.assert_(u'cpos: 2' in result) - self.assert_(u'Id: %d' % self.b.current_playlist.cp_tracks[2][0] + self.assert_(u'Id: %d' % cp_tracks[2][0] in result) self.assert_(u'OK' in result) @@ -377,9 +381,9 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='a'), Track(name='b'), Track(name='c'), Track(name='d'), Track(name='e'), Track(name='f'), ]) - version = self.b.current_playlist.version + version = self.b.current_playlist.version.get() result = self.h.handle_request(u'shuffle') - self.assert_(version < self.b.current_playlist.version) + self.assert_(version < self.b.current_playlist.version.get()) self.assert_(u'OK' in result) def test_shuffle_with_open_range(self): @@ -387,13 +391,14 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='a'), Track(name='b'), Track(name='c'), Track(name='d'), Track(name='e'), Track(name='f'), ]) - version = self.b.current_playlist.version + version = self.b.current_playlist.version.get() result = self.h.handle_request(u'shuffle "4:"') - self.assert_(version < self.b.current_playlist.version) - self.assertEqual(self.b.current_playlist.tracks[0].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[1].name, 'b') - self.assertEqual(self.b.current_playlist.tracks[2].name, 'c') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'd') + self.assert_(version < self.b.current_playlist.version.get()) + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'a') + self.assertEqual(tracks[1].name, 'b') + self.assertEqual(tracks[2].name, 'c') + self.assertEqual(tracks[3].name, 'd') self.assert_(u'OK' in result) def test_shuffle_with_closed_range(self): @@ -401,13 +406,14 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='a'), Track(name='b'), Track(name='c'), Track(name='d'), Track(name='e'), Track(name='f'), ]) - version = self.b.current_playlist.version + version = self.b.current_playlist.version.get() result = self.h.handle_request(u'shuffle "1:3"') - self.assert_(version < self.b.current_playlist.version) - self.assertEqual(self.b.current_playlist.tracks[0].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'd') - self.assertEqual(self.b.current_playlist.tracks[4].name, 'e') - self.assertEqual(self.b.current_playlist.tracks[5].name, 'f') + self.assert_(version < self.b.current_playlist.version.get()) + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'a') + self.assertEqual(tracks[3].name, 'd') + self.assertEqual(tracks[4].name, 'e') + self.assertEqual(tracks[5].name, 'f') self.assert_(u'OK' in result) def test_swap(self): @@ -416,12 +422,13 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='d'), Track(name='e'), Track(name='f'), ]) result = self.h.handle_request(u'swap "1" "4"') - self.assertEqual(self.b.current_playlist.tracks[0].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[1].name, 'e') - self.assertEqual(self.b.current_playlist.tracks[2].name, 'c') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'd') - self.assertEqual(self.b.current_playlist.tracks[4].name, 'b') - self.assertEqual(self.b.current_playlist.tracks[5].name, 'f') + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'a') + self.assertEqual(tracks[1].name, 'e') + self.assertEqual(tracks[2].name, 'c') + self.assertEqual(tracks[3].name, 'd') + self.assertEqual(tracks[4].name, 'b') + self.assertEqual(tracks[5].name, 'f') self.assert_(u'OK' in result) def test_swapid(self): @@ -430,10 +437,11 @@ class CurrentPlaylistHandlerTest(unittest.TestCase): Track(name='d'), Track(name='e'), Track(name='f'), ]) result = self.h.handle_request(u'swapid "1" "4"') - self.assertEqual(self.b.current_playlist.tracks[0].name, 'a') - self.assertEqual(self.b.current_playlist.tracks[1].name, 'e') - self.assertEqual(self.b.current_playlist.tracks[2].name, 'c') - self.assertEqual(self.b.current_playlist.tracks[3].name, 'd') - self.assertEqual(self.b.current_playlist.tracks[4].name, 'b') - self.assertEqual(self.b.current_playlist.tracks[5].name, 'f') + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(tracks[0].name, 'a') + self.assertEqual(tracks[1].name, 'e') + self.assertEqual(tracks[2].name, 'c') + self.assertEqual(tracks[3].name, 'd') + self.assertEqual(tracks[4].name, 'b') + self.assertEqual(tracks[5].name, 'f') self.assert_(u'OK' in result) From 4e82730732e466ca00b1f7a1201cf227ab708826 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 17:57:06 +0100 Subject: [PATCH 35/65] Update MPD/dispatcher --- tests/frontends/mpd/dispatcher_test.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/frontends/mpd/dispatcher_test.py b/tests/frontends/mpd/dispatcher_test.py index 2a2ee4db..8c17c9ee 100644 --- a/tests/frontends/mpd/dispatcher_test.py +++ b/tests/frontends/mpd/dispatcher_test.py @@ -4,12 +4,14 @@ from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher from mopidy.frontends.mpd.exceptions import MpdAckError from mopidy.frontends.mpd.protocol import request_handlers, handle_pattern -from mopidy.mixers.dummy import DummyMixer class MpdDispatcherTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() def test_register_same_pattern_twice_fails(self): func = lambda: None From 517a2a935619180ebf534310de14ac5c1eb76c2b Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 19 Mar 2011 18:05:09 +0100 Subject: [PATCH 36/65] Update MPD/music_db --- mopidy/frontends/mpd/protocol/music_db.py | 10 +++---- .../mpd/protocol/stored_playlists.py | 2 +- tests/frontends/mpd/music_db_test.py | 29 +++++++++++++------ 3 files changed, 26 insertions(+), 15 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/music_db.py b/mopidy/frontends/mpd/protocol/music_db.py index d50388f5..a6836533 100644 --- a/mopidy/frontends/mpd/protocol/music_db.py +++ b/mopidy/frontends/mpd/protocol/music_db.py @@ -68,7 +68,7 @@ def find(frontend, mpd_query): - also uses the search type "date". """ query = _build_query(mpd_query) - return frontend.backend.library.find_exact(**query).mpd_format() + return frontend.backend.library.find_exact(**query).get().mpd_format() @handle_pattern(r'^findadd ' r'(?P("?([Aa]lbum|[Aa]rtist|[Ff]ilename|[Tt]itle|[Aa]ny)"? ' @@ -215,7 +215,7 @@ def _list_build_query(field, mpd_query): def _list_artist(frontend, query): artists = set() - playlist = frontend.backend.library.find_exact(**query) + playlist = frontend.backend.library.find_exact(**query).get() for track in playlist.tracks: for artist in track.artists: artists.add((u'Artist', artist.name)) @@ -223,7 +223,7 @@ def _list_artist(frontend, query): def _list_album(frontend, query): albums = set() - playlist = frontend.backend.library.find_exact(**query) + playlist = frontend.backend.library.find_exact(**query).get() for track in playlist.tracks: if track.album is not None: albums.add((u'Album', track.album.name)) @@ -231,7 +231,7 @@ def _list_album(frontend, query): def _list_date(frontend, query): dates = set() - playlist = frontend.backend.library.find_exact(**query) + playlist = frontend.backend.library.find_exact(**query).get() for track in playlist.tracks: if track.date is not None: dates.add((u'Date', track.date.strftime('%Y-%m-%d'))) @@ -324,7 +324,7 @@ def search(frontend, mpd_query): - also uses the search type "date". """ query = _build_query(mpd_query) - return frontend.backend.library.search(**query).mpd_format() + return frontend.backend.library.search(**query).get().mpd_format() @handle_pattern(r'^update( "(?P[^"]+)")*$') def update(frontend, uri=None, rescan_unmodified_files=False): diff --git a/mopidy/frontends/mpd/protocol/stored_playlists.py b/mopidy/frontends/mpd/protocol/stored_playlists.py index c34b1676..f0a63544 100644 --- a/mopidy/frontends/mpd/protocol/stored_playlists.py +++ b/mopidy/frontends/mpd/protocol/stored_playlists.py @@ -66,7 +66,7 @@ def listplaylists(frontend): Last-Modified: 2010-02-06T02:11:08Z """ result = [] - for playlist in frontend.backend.stored_playlists.playlists: + for playlist in frontend.backend.stored_playlists.playlists.get(): result.append((u'playlist', playlist.name)) last_modified = (playlist.last_modified or dt.datetime.now()).isoformat() diff --git a/tests/frontends/mpd/music_db_test.py b/tests/frontends/mpd/music_db_test.py index 486eac4f..595ef02c 100644 --- a/tests/frontends/mpd/music_db_test.py +++ b/tests/frontends/mpd/music_db_test.py @@ -2,12 +2,14 @@ import unittest from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher -from mopidy.mixers.dummy import DummyMixer class MusicDatabaseHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() def test_count(self): result = self.h.handle_request(u'count "tag" "needle"') @@ -65,8 +67,11 @@ class MusicDatabaseHandlerTest(unittest.TestCase): class MusicDatabaseFindTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() def test_find_album(self): result = self.h.handle_request(u'find "album" "what"') @@ -117,8 +122,11 @@ class MusicDatabaseFindTest(unittest.TestCase): class MusicDatabaseListTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() def test_list_foo_returns_ack(self): result = self.h.handle_request(u'list "foo"') @@ -308,8 +316,11 @@ class MusicDatabaseListTest(unittest.TestCase): class MusicDatabaseSearchTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() def test_search_album(self): result = self.h.handle_request(u'search "album" "analbum"') From 2700698ec7dbe08d5d57f7c4caf7fb8729fa05a5 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:00:20 +0100 Subject: [PATCH 37/65] Require Pykka 0.11 --- docs/installation/index.rst | 2 +- requirements/core.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/installation/index.rst b/docs/installation/index.rst index ed6107d8..3ef5af99 100644 --- a/docs/installation/index.rst +++ b/docs/installation/index.rst @@ -25,7 +25,7 @@ Otherwise, make sure you got the required dependencies installed. - Python >= 2.6, < 3 -- `Pykka `_ >= 0.10 +- `Pykka `_ >= 0.11 - GStreamer >= 0.10, with Python bindings. See :doc:`gstreamer`. diff --git a/requirements/core.txt b/requirements/core.txt index 1b5cfc4b..f0f0bd39 100644 --- a/requirements/core.txt +++ b/requirements/core.txt @@ -1 +1 @@ -Pykka >= 0.10 +Pykka >= 0.11 From 7206d68648c91790ac4fa14a3074c77c97c01636 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:02:25 +0100 Subject: [PATCH 38/65] Remove mixer from the Backend API as it is independent --- mopidy/backends/base/__init__.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/mopidy/backends/base/__init__.py b/mopidy/backends/base/__init__.py index 963d9eb4..038e2d7b 100644 --- a/mopidy/backends/base/__init__.py +++ b/mopidy/backends/base/__init__.py @@ -17,9 +17,6 @@ class Backend(object): # :class:`mopidy.backends.base.LibraryController`. library = None - #: The sound mixer. An instance of :class:`mopidy.mixers.BaseMixer`. - mixer = None - #: The playback controller. An instance of #: :class:`mopidy.backends.base.PlaybackController`. playback = None From dad2422a96df7d79a7a4aeac8aea224be4be94f4 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:10:14 +0100 Subject: [PATCH 39/65] MpdDispatcher requires a mixer to be running --- mopidy/frontends/mpd/dispatcher.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mopidy/frontends/mpd/dispatcher.py b/mopidy/frontends/mpd/dispatcher.py index c1249028..f5c30b23 100644 --- a/mopidy/frontends/mpd/dispatcher.py +++ b/mopidy/frontends/mpd/dispatcher.py @@ -13,6 +13,7 @@ from mopidy.frontends.mpd.protocol import (audio_output, command_list, connection, current_playlist, empty, music_db, playback, reflection, status, stickers, stored_playlists) # pylint: enable = W0611 +from mopidy.mixers.base import BaseMixer from mopidy.utils import flatten class MpdDispatcher(object): @@ -29,6 +30,10 @@ class MpdDispatcher(object): assert len(backend_refs) == 1, 'Expected exactly one running backend.' self.backend = backend_refs[0].proxy() + mixer_refs = ActorRegistry.get_by_class(BaseMixer) + assert len(mixer_refs) == 1, 'Expected exactly one running mixer.' + self.mixer = mixer_refs[0].proxy() + self.command_list = False self.command_list_ok = False From 1048795f2bd34abbe3c99984a4fe98c04f075ee7 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:14:59 +0100 Subject: [PATCH 40/65] Update working MPD tests to start mixer actor --- tests/frontends/mpd/audio_output_test.py | 3 +++ tests/frontends/mpd/connection_test.py | 5 ++++- tests/frontends/mpd/current_playlist_test.py | 3 +++ tests/frontends/mpd/dispatcher_test.py | 3 +++ tests/frontends/mpd/music_db_test.py | 9 +++++++++ 5 files changed, 22 insertions(+), 1 deletion(-) diff --git a/tests/frontends/mpd/audio_output_test.py b/tests/frontends/mpd/audio_output_test.py index d4ddbc92..afa99d26 100644 --- a/tests/frontends/mpd/audio_output_test.py +++ b/tests/frontends/mpd/audio_output_test.py @@ -2,14 +2,17 @@ import unittest from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher +from mopidy.mixers.dummy import DummyMixer class AudioOutputHandlerTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): self.b.stop().get() + self.mixer.stop().get() def test_enableoutput(self): result = self.h.handle_request(u'enableoutput "0"') diff --git a/tests/frontends/mpd/connection_test.py b/tests/frontends/mpd/connection_test.py index 4d2a309d..cf161a5a 100644 --- a/tests/frontends/mpd/connection_test.py +++ b/tests/frontends/mpd/connection_test.py @@ -3,14 +3,17 @@ import unittest from mopidy import settings from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher +from mopidy.mixers.dummy import DummyMixer class ConnectionHandlerTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): - self.b.stop() + self.b.stop().get() + self.mixer.stop().get() settings.runtime.clear() def test_close(self): diff --git a/tests/frontends/mpd/current_playlist_test.py b/tests/frontends/mpd/current_playlist_test.py index 8e189dee..eb113ed7 100644 --- a/tests/frontends/mpd/current_playlist_test.py +++ b/tests/frontends/mpd/current_playlist_test.py @@ -2,15 +2,18 @@ import unittest from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher +from mopidy.mixers.dummy import DummyMixer from mopidy.models import Track class CurrentPlaylistHandlerTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): self.b.stop().get() + self.mixer.stop().get() def test_add(self): needle = Track(uri='dummy://foo') diff --git a/tests/frontends/mpd/dispatcher_test.py b/tests/frontends/mpd/dispatcher_test.py index 8c17c9ee..77e0ddf0 100644 --- a/tests/frontends/mpd/dispatcher_test.py +++ b/tests/frontends/mpd/dispatcher_test.py @@ -4,14 +4,17 @@ from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher from mopidy.frontends.mpd.exceptions import MpdAckError from mopidy.frontends.mpd.protocol import request_handlers, handle_pattern +from mopidy.mixers.dummy import DummyMixer class MpdDispatcherTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): self.b.stop().get() + self.mixer.stop().get() def test_register_same_pattern_twice_fails(self): func = lambda: None diff --git a/tests/frontends/mpd/music_db_test.py b/tests/frontends/mpd/music_db_test.py index 595ef02c..fa5634be 100644 --- a/tests/frontends/mpd/music_db_test.py +++ b/tests/frontends/mpd/music_db_test.py @@ -2,14 +2,17 @@ import unittest from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher +from mopidy.mixers.dummy import DummyMixer class MusicDatabaseHandlerTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): self.b.stop().get() + self.mixer.stop().get() def test_count(self): result = self.h.handle_request(u'count "tag" "needle"') @@ -68,10 +71,12 @@ class MusicDatabaseHandlerTest(unittest.TestCase): class MusicDatabaseFindTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): self.b.stop().get() + self.mixer.stop().get() def test_find_album(self): result = self.h.handle_request(u'find "album" "what"') @@ -123,10 +128,12 @@ class MusicDatabaseFindTest(unittest.TestCase): class MusicDatabaseListTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): self.b.stop().get() + self.mixer.stop().get() def test_list_foo_returns_ack(self): result = self.h.handle_request(u'list "foo"') @@ -317,10 +324,12 @@ class MusicDatabaseListTest(unittest.TestCase): class MusicDatabaseSearchTest(unittest.TestCase): def setUp(self): self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() self.h = dispatcher.MpdDispatcher() def tearDown(self): self.b.stop().get() + self.mixer.stop().get() def test_search_album(self): result = self.h.handle_request(u'search "album" "analbum"') From cbe727d2bd202a4d000d2acb518a2b9b8d399f9b Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:19:30 +0100 Subject: [PATCH 41/65] Update MPD/playback --- mopidy/frontends/mpd/protocol/playback.py | 43 +++--- tests/frontends/mpd/playback_test.py | 175 ++++++++++++---------- 2 files changed, 117 insertions(+), 101 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/playback.py b/mopidy/frontends/mpd/protocol/playback.py index d009969d..65282f42 100644 --- a/mopidy/frontends/mpd/protocol/playback.py +++ b/mopidy/frontends/mpd/protocol/playback.py @@ -1,3 +1,4 @@ +from mopidy.backends.base import PlaybackController from mopidy.frontends.mpd.protocol import handle_pattern from mopidy.frontends.mpd.exceptions import (MpdArgError, MpdNoExistError, MpdNotImplemented) @@ -86,7 +87,7 @@ def next_(frontend): order as the first time. """ - return frontend.backend.playback.next() + return frontend.backend.playback.next().get() @handle_pattern(r'^pause$') @handle_pattern(r'^pause "(?P[01])"$') @@ -103,11 +104,11 @@ def pause(frontend, state=None): - Calls ``pause`` without any arguments to toogle pause. """ if state is None: - if (frontend.backend.playback.state == - frontend.backend.playback.PLAYING): + if (frontend.backend.playback.state.get() == + PlaybackController.PLAYING): frontend.backend.playback.pause() - elif (frontend.backend.playback.state == - frontend.backend.playback.PAUSED): + elif (frontend.backend.playback.state.get() == + PlaybackController.PAUSED): frontend.backend.playback.resume() elif int(state): frontend.backend.playback.pause() @@ -120,7 +121,7 @@ def play(frontend): The original MPD server resumes from the paused state on ``play`` without arguments. """ - return frontend.backend.playback.play() + return frontend.backend.playback.play().get() @handle_pattern(r'^playid "(?P\d+)"$') @handle_pattern(r'^playid "(?P-1)"$') @@ -145,8 +146,8 @@ def playid(frontend, cpid): if cpid == -1: return _play_minus_one(frontend) try: - cp_track = frontend.backend.current_playlist.get(cpid=cpid) - return frontend.backend.playback.play(cp_track) + cp_track = frontend.backend.current_playlist.get(cpid=cpid).get() + return frontend.backend.playback.play(cp_track).get() except LookupError: raise MpdNoExistError(u'No such song', command=u'playid') @@ -177,22 +178,22 @@ def playpos(frontend, songpos): if songpos == -1: return _play_minus_one(frontend) try: - cp_track = frontend.backend.current_playlist.cp_tracks[songpos] - return frontend.backend.playback.play(cp_track) + cp_track = frontend.backend.current_playlist.cp_tracks.get()[songpos] + return frontend.backend.playback.play(cp_track).get() except IndexError: raise MpdArgError(u'Bad song index', command=u'play') def _play_minus_one(frontend): - if (frontend.backend.playback.state == frontend.backend.playback.PLAYING): + if (frontend.backend.playback.state.get() == PlaybackController.PLAYING): return # Nothing to do - elif (frontend.backend.playback.state == frontend.backend.playback.PAUSED): - return frontend.backend.playback.resume() - elif frontend.backend.playback.current_cp_track is not None: - cp_track = frontend.backend.playback.current_cp_track - return frontend.backend.playback.play(cp_track) - elif frontend.backend.current_playlist.cp_tracks: - cp_track = frontend.backend.current_playlist.cp_tracks[0] - return frontend.backend.playback.play(cp_track) + elif (frontend.backend.playback.state.get() == PlaybackController.PAUSED): + return frontend.backend.playback.resume().get() + elif frontend.backend.playback.current_cp_track.get() is not None: + cp_track = frontend.backend.playback.current_cp_track.get() + return frontend.backend.playback.play(cp_track).get() + elif frontend.backend.current_playlist.cp_tracks.get(): + cp_track = frontend.backend.current_playlist.cp_tracks.get()[0] + return frontend.backend.playback.play(cp_track).get() else: return # Fail silently @@ -240,7 +241,7 @@ def previous(frontend): ``previous`` should do a seek to time position 0. """ - return frontend.backend.playback.previous() + return frontend.backend.playback.previous().get() @handle_pattern(r'^random (?P[01])$') @handle_pattern(r'^random "(?P[01])"$') @@ -351,7 +352,7 @@ def setvol(frontend, volume): volume = 0 if volume > 100: volume = 100 - frontend.backend.mixer.volume = volume + frontend.mixer.volume = volume @handle_pattern(r'^single (?P[01])$') @handle_pattern(r'^single "(?P[01])"$') diff --git a/tests/frontends/mpd/playback_test.py b/tests/frontends/mpd/playback_test.py index 8f0560c7..8601aa9c 100644 --- a/tests/frontends/mpd/playback_test.py +++ b/tests/frontends/mpd/playback_test.py @@ -1,5 +1,6 @@ import unittest +from mopidy.backends.base import PlaybackController from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher from mopidy.mixers.dummy import DummyMixer @@ -7,29 +8,38 @@ from mopidy.models import Track from tests import SkipTest +PAUSED = PlaybackController.PAUSED +PLAYING = PlaybackController.PLAYING +STOPPED = PlaybackController.STOPPED + class PlaybackOptionsHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() + self.mixer.stop().get() def test_consume_off(self): result = self.h.handle_request(u'consume "0"') - self.assertFalse(self.b.playback.consume) + self.assertFalse(self.b.playback.consume.get()) self.assert_(u'OK' in result) def test_consume_off_without_quotes(self): result = self.h.handle_request(u'consume 0') - self.assertFalse(self.b.playback.consume) + self.assertFalse(self.b.playback.consume.get()) self.assert_(u'OK' in result) def test_consume_on(self): result = self.h.handle_request(u'consume "1"') - self.assertTrue(self.b.playback.consume) + self.assertTrue(self.b.playback.consume.get()) self.assert_(u'OK' in result) def test_consume_on_without_quotes(self): result = self.h.handle_request(u'consume 1') - self.assertTrue(self.b.playback.consume) + self.assertTrue(self.b.playback.consume.get()) self.assert_(u'OK' in result) def test_crossfade(self): @@ -38,97 +48,97 @@ class PlaybackOptionsHandlerTest(unittest.TestCase): def test_random_off(self): result = self.h.handle_request(u'random "0"') - self.assertFalse(self.b.playback.random) + self.assertFalse(self.b.playback.random.get()) self.assert_(u'OK' in result) def test_random_off_without_quotes(self): result = self.h.handle_request(u'random 0') - self.assertFalse(self.b.playback.random) + self.assertFalse(self.b.playback.random.get()) self.assert_(u'OK' in result) def test_random_on(self): result = self.h.handle_request(u'random "1"') - self.assertTrue(self.b.playback.random) + self.assertTrue(self.b.playback.random.get()) self.assert_(u'OK' in result) def test_random_on_without_quotes(self): result = self.h.handle_request(u'random 1') - self.assertTrue(self.b.playback.random) + self.assertTrue(self.b.playback.random.get()) self.assert_(u'OK' in result) def test_repeat_off(self): result = self.h.handle_request(u'repeat "0"') - self.assertFalse(self.b.playback.repeat) + self.assertFalse(self.b.playback.repeat.get()) self.assert_(u'OK' in result) def test_repeat_off_without_quotes(self): result = self.h.handle_request(u'repeat 0') - self.assertFalse(self.b.playback.repeat) + self.assertFalse(self.b.playback.repeat.get()) self.assert_(u'OK' in result) def test_repeat_on(self): result = self.h.handle_request(u'repeat "1"') - self.assertTrue(self.b.playback.repeat) + self.assertTrue(self.b.playback.repeat.get()) self.assert_(u'OK' in result) def test_repeat_on_without_quotes(self): result = self.h.handle_request(u'repeat 1') - self.assertTrue(self.b.playback.repeat) + self.assertTrue(self.b.playback.repeat.get()) self.assert_(u'OK' in result) def test_setvol_below_min(self): result = self.h.handle_request(u'setvol "-10"') self.assert_(u'OK' in result) - self.assertEqual(0, self.b.mixer.volume) + self.assertEqual(0, self.mixer.volume.get()) def test_setvol_min(self): result = self.h.handle_request(u'setvol "0"') self.assert_(u'OK' in result) - self.assertEqual(0, self.b.mixer.volume) + self.assertEqual(0, self.mixer.volume.get()) def test_setvol_middle(self): result = self.h.handle_request(u'setvol "50"') self.assert_(u'OK' in result) - self.assertEqual(50, self.b.mixer.volume) + self.assertEqual(50, self.mixer.volume.get()) def test_setvol_max(self): result = self.h.handle_request(u'setvol "100"') self.assert_(u'OK' in result) - self.assertEqual(100, self.b.mixer.volume) + self.assertEqual(100, self.mixer.volume.get()) def test_setvol_above_max(self): result = self.h.handle_request(u'setvol "110"') self.assert_(u'OK' in result) - self.assertEqual(100, self.b.mixer.volume) + self.assertEqual(100, self.mixer.volume.get()) def test_setvol_plus_is_ignored(self): result = self.h.handle_request(u'setvol "+10"') self.assert_(u'OK' in result) - self.assertEqual(10, self.b.mixer.volume) + self.assertEqual(10, self.mixer.volume.get()) def test_setvol_without_quotes(self): result = self.h.handle_request(u'setvol 50') self.assert_(u'OK' in result) - self.assertEqual(50, self.b.mixer.volume) + self.assertEqual(50, self.mixer.volume.get()) def test_single_off(self): result = self.h.handle_request(u'single "0"') - self.assertFalse(self.b.playback.single) + self.assertFalse(self.b.playback.single.get()) self.assert_(u'OK' in result) def test_single_off_without_quotes(self): result = self.h.handle_request(u'single 0') - self.assertFalse(self.b.playback.single) + self.assertFalse(self.b.playback.single.get()) self.assert_(u'OK' in result) def test_single_on(self): result = self.h.handle_request(u'single "1"') - self.assertTrue(self.b.playback.single) + self.assertTrue(self.b.playback.single.get()) self.assert_(u'OK' in result) def test_single_on_without_quotes(self): result = self.h.handle_request(u'single 1') - self.assertTrue(self.b.playback.single) + self.assertTrue(self.b.playback.single.get()) self.assert_(u'OK' in result) def test_replay_gain_mode_off(self): @@ -176,8 +186,13 @@ class PlaybackOptionsHandlerTest(unittest.TestCase): class PlaybackControlHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() + self.mixer.stop().get() def test_next(self): result = self.h.handle_request(u'next') @@ -189,155 +204,155 @@ class PlaybackControlHandlerTest(unittest.TestCase): self.h.handle_request(u'pause "1"') result = self.h.handle_request(u'pause "0"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) + self.assertEqual(PLAYING, self.b.playback.state.get()) def test_pause_on(self): self.b.current_playlist.append([Track()]) self.h.handle_request(u'play "0"') result = self.h.handle_request(u'pause "1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PAUSED, self.b.playback.state) + self.assertEqual(PAUSED, self.b.playback.state.get()) def test_pause_toggle(self): self.b.current_playlist.append([Track()]) result = self.h.handle_request(u'play "0"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) + self.assertEqual(PLAYING, self.b.playback.state.get()) result = self.h.handle_request(u'pause') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PAUSED, self.b.playback.state) + self.assertEqual(PAUSED, self.b.playback.state.get()) result = self.h.handle_request(u'pause') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) + self.assertEqual(PLAYING, self.b.playback.state.get()) def test_play_without_pos(self): self.b.current_playlist.append([Track()]) - self.b.playback.state = self.b.playback.PAUSED + self.b.playback.state = PAUSED result = self.h.handle_request(u'play') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) + self.assertEqual(PLAYING, self.b.playback.state.get()) def test_play_with_pos(self): self.b.current_playlist.append([Track()]) result = self.h.handle_request(u'play "0"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) + self.assertEqual(PLAYING, self.b.playback.state.get()) def test_play_with_pos_without_quotes(self): self.b.current_playlist.append([Track()]) result = self.h.handle_request(u'play 0') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) + self.assertEqual(PLAYING, self.b.playback.state.get()) def test_play_with_pos_out_of_bounds(self): self.b.current_playlist.append([]) result = self.h.handle_request(u'play "0"') self.assertEqual(result[0], u'ACK [2@0] {play} Bad song index') - self.assertEqual(self.b.playback.STOPPED, self.b.playback.state) + self.assertEqual(STOPPED, self.b.playback.state.get()) def test_play_minus_one_plays_first_in_playlist_if_no_current_track(self): - self.assertEqual(self.b.playback.current_track, None) + self.assertEqual(self.b.playback.current_track.get(), None) self.b.current_playlist.append([Track(uri='a'), Track(uri='b')]) result = self.h.handle_request(u'play "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assertEqual(self.b.playback.current_track.uri, 'a') + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assertEqual(self.b.playback.current_track.get().uri, 'a') def test_play_minus_one_plays_current_track_if_current_track_is_set(self): self.b.current_playlist.append([Track(uri='a'), Track(uri='b')]) - self.assertEqual(self.b.playback.current_track, None) + self.assertEqual(self.b.playback.current_track.get(), None) self.b.playback.play() self.b.playback.next() self.b.playback.stop() - self.assertNotEqual(self.b.playback.current_track, None) + self.assertNotEqual(self.b.playback.current_track.get(), None) result = self.h.handle_request(u'play "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assertEqual(self.b.playback.current_track.uri, 'b') + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assertEqual(self.b.playback.current_track.get().uri, 'b') def test_play_minus_one_on_empty_playlist_does_not_ack(self): self.b.current_playlist.clear() result = self.h.handle_request(u'play "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.STOPPED, self.b.playback.state) - self.assertEqual(self.b.playback.current_track, None) + self.assertEqual(STOPPED, self.b.playback.state.get()) + self.assertEqual(self.b.playback.current_track.get(), None) def test_play_minus_is_ignored_if_playing(self): self.b.current_playlist.append([Track(length=40000)]) self.b.playback.seek(30000) - self.assert_(self.b.playback.time_position >= 30000) - self.assertEquals(self.b.playback.PLAYING, self.b.playback.state) + self.assert_(self.b.playback.time_position.get() >= 30000) + self.assertEquals(PLAYING, self.b.playback.state.get()) result = self.h.handle_request(u'play "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assert_(self.b.playback.time_position >= 30000) + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assert_(self.b.playback.time_position.get() >= 30000) def test_play_minus_one_resumes_if_paused(self): self.b.current_playlist.append([Track(length=40000)]) self.b.playback.seek(30000) - self.assert_(self.b.playback.time_position >= 30000) - self.assertEquals(self.b.playback.PLAYING, self.b.playback.state) + self.assert_(self.b.playback.time_position.get() >= 30000) + self.assertEquals(PLAYING, self.b.playback.state.get()) self.b.playback.pause() - self.assertEquals(self.b.playback.PAUSED, self.b.playback.state) + self.assertEquals(PAUSED, self.b.playback.state.get()) result = self.h.handle_request(u'play "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assert_(self.b.playback.time_position >= 30000) + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assert_(self.b.playback.time_position.get() >= 30000) def test_playid(self): self.b.current_playlist.append([Track()]) result = self.h.handle_request(u'playid "0"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) + self.assertEqual(PLAYING, self.b.playback.state.get()) def test_playid_minus_one_plays_first_in_playlist_if_no_current_track(self): - self.assertEqual(self.b.playback.current_track, None) + self.assertEqual(self.b.playback.current_track.get(), None) self.b.current_playlist.append([Track(uri='a'), Track(uri='b')]) result = self.h.handle_request(u'playid "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assertEqual(self.b.playback.current_track.uri, 'a') + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assertEqual(self.b.playback.current_track.get().uri, 'a') def test_playid_minus_one_plays_current_track_if_current_track_is_set(self): self.b.current_playlist.append([Track(uri='a'), Track(uri='b')]) - self.assertEqual(self.b.playback.current_track, None) + self.assertEqual(self.b.playback.current_track.get(), None) self.b.playback.play() self.b.playback.next() self.b.playback.stop() - self.assertNotEqual(self.b.playback.current_track, None) + self.assertNotEqual(self.b.playback.current_track.get(), None) result = self.h.handle_request(u'playid "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assertEqual(self.b.playback.current_track.uri, 'b') + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assertEqual(self.b.playback.current_track.get().uri, 'b') def test_playid_minus_one_on_empty_playlist_does_not_ack(self): self.b.current_playlist.clear() result = self.h.handle_request(u'playid "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.STOPPED, self.b.playback.state) - self.assertEqual(self.b.playback.current_track, None) + self.assertEqual(STOPPED, self.b.playback.state.get()) + self.assertEqual(self.b.playback.current_track.get(), None) def test_playid_minus_is_ignored_if_playing(self): self.b.current_playlist.append([Track(length=40000)]) self.b.playback.seek(30000) - self.assert_(self.b.playback.time_position >= 30000) - self.assertEquals(self.b.playback.PLAYING, self.b.playback.state) + self.assert_(self.b.playback.time_position.get() >= 30000) + self.assertEquals(PLAYING, self.b.playback.state.get()) result = self.h.handle_request(u'playid "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assert_(self.b.playback.time_position >= 30000) + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assert_(self.b.playback.time_position.get() >= 30000) def test_playid_minus_one_resumes_if_paused(self): self.b.current_playlist.append([Track(length=40000)]) self.b.playback.seek(30000) - self.assert_(self.b.playback.time_position >= 30000) - self.assertEquals(self.b.playback.PLAYING, self.b.playback.state) + self.assert_(self.b.playback.time_position.get() >= 30000) + self.assertEquals(PLAYING, self.b.playback.state.get()) self.b.playback.pause() - self.assertEquals(self.b.playback.PAUSED, self.b.playback.state) + self.assertEquals(PAUSED, self.b.playback.state.get()) result = self.h.handle_request(u'playid "-1"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.PLAYING, self.b.playback.state) - self.assert_(self.b.playback.time_position >= 30000) + self.assertEqual(PLAYING, self.b.playback.state.get()) + self.assert_(self.b.playback.time_position.get() >= 30000) def test_playid_which_does_not_exist(self): self.b.current_playlist.append([Track()]) @@ -361,20 +376,20 @@ class PlaybackControlHandlerTest(unittest.TestCase): [Track(uri='1', length=40000), seek_track]) result = self.h.handle_request(u'seek "1" "30"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.current_track, seek_track) + self.assertEqual(self.b.playback.current_track.get(), seek_track) def test_seek_without_quotes(self): self.b.current_playlist.append([Track(length=40000)]) self.h.handle_request(u'seek 0') result = self.h.handle_request(u'seek 0 30') self.assert_(u'OK' in result) - self.assert_(self.b.playback.time_position >= 30000) + self.assert_(self.b.playback.time_position.get() >= 30000) def test_seekid(self): self.b.current_playlist.append([Track(length=40000)]) result = self.h.handle_request(u'seekid "0" "30"') self.assert_(u'OK' in result) - self.assert_(self.b.playback.time_position >= 30000) + self.assert_(self.b.playback.time_position.get() >= 30000) def test_seekid_with_cpid(self): seek_track = Track(uri='2', length=40000) @@ -382,10 +397,10 @@ class PlaybackControlHandlerTest(unittest.TestCase): [Track(length=40000), seek_track]) result = self.h.handle_request(u'seekid "1" "30"') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.current_cpid, 1) - self.assertEqual(self.b.playback.current_track, seek_track) + self.assertEqual(self.b.playback.current_cpid.get(), 1) + self.assertEqual(self.b.playback.current_track.get(), seek_track) def test_stop(self): result = self.h.handle_request(u'stop') self.assert_(u'OK' in result) - self.assertEqual(self.b.playback.STOPPED, self.b.playback.state) + self.assertEqual(STOPPED, self.b.playback.state.get()) From 2e1ea8080ead98fae9b83862f34fa73047907cd1 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:21:43 +0100 Subject: [PATCH 42/65] Update MPD/reflection --- mopidy/frontends/mpd/protocol/reflection.py | 2 +- tests/frontends/mpd/reflection_test.py | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/reflection.py b/mopidy/frontends/mpd/protocol/reflection.py index 83efdd94..ab782440 100644 --- a/mopidy/frontends/mpd/protocol/reflection.py +++ b/mopidy/frontends/mpd/protocol/reflection.py @@ -81,4 +81,4 @@ def urlhandlers(frontend): Gets a list of available URL handlers. """ - return [(u'handler', uri) for uri in frontend.backend.uri_handlers] + return [(u'handler', uri) for uri in frontend.backend.uri_handlers.get()] diff --git a/tests/frontends/mpd/reflection_test.py b/tests/frontends/mpd/reflection_test.py index a4491d75..be95c49b 100644 --- a/tests/frontends/mpd/reflection_test.py +++ b/tests/frontends/mpd/reflection_test.py @@ -6,8 +6,13 @@ from mopidy.mixers.dummy import DummyMixer class ReflectionHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() + self.mixer.stop().get() def test_commands_returns_list_of_all_commands(self): result = self.h.handle_request(u'commands') From 21153dd52b9f026b708fb9ad01d137f2696df128 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:29:43 +0100 Subject: [PATCH 43/65] Update MPD/regression tests --- mopidy/frontends/mpd/protocol/status.py | 38 ++++++++++++---------- tests/frontends/mpd/regression_test.py | 43 +++++++++++++++++-------- 2 files changed, 50 insertions(+), 31 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/status.py b/mopidy/frontends/mpd/protocol/status.py index e18f1ea4..9de82756 100644 --- a/mopidy/frontends/mpd/protocol/status.py +++ b/mopidy/frontends/mpd/protocol/status.py @@ -1,5 +1,6 @@ from mopidy.frontends.mpd.protocol import handle_pattern from mopidy.frontends.mpd.exceptions import MpdNotImplemented +from mopidy.backends.base import PlaybackController @handle_pattern(r'^clearerror$') def clearerror(frontend): @@ -152,28 +153,28 @@ def status(frontend): def _status_bitrate(frontend): if frontend.backend.playback.current_track is not None: - return frontend.backend.playback.current_track.bitrate + return frontend.backend.playback.current_track.get().bitrate def _status_consume(frontend): - if frontend.backend.playback.consume: + if frontend.backend.playback.consume.get(): return 1 else: return 0 def _status_playlist_length(frontend): - return len(frontend.backend.current_playlist.tracks) + return len(frontend.backend.current_playlist.tracks.get()) def _status_playlist_version(frontend): - return frontend.backend.current_playlist.version + return frontend.backend.current_playlist.version.get() def _status_random(frontend): - return int(frontend.backend.playback.random) + return int(frontend.backend.playback.random.get()) def _status_repeat(frontend): - return int(frontend.backend.playback.repeat) + return int(frontend.backend.playback.repeat.get()) def _status_single(frontend): - return int(frontend.backend.playback.single) + return int(frontend.backend.playback.single.get()) def _status_songid(frontend): if frontend.backend.playback.current_cpid is not None: @@ -182,14 +183,15 @@ def _status_songid(frontend): return _status_songpos(frontend) def _status_songpos(frontend): - return frontend.backend.playback.current_playlist_position + return frontend.backend.playback.current_playlist_position.get() def _status_state(frontend): - if frontend.backend.playback.state == frontend.backend.playback.PLAYING: + state = frontend.backend.playback.state.get() + if state == PlaybackController.PLAYING: return u'play' - elif frontend.backend.playback.state == frontend.backend.playback.STOPPED: + elif state == PlaybackController.STOPPED: return u'stop' - elif frontend.backend.playback.state == frontend.backend.playback.PAUSED: + elif state == PlaybackController.PAUSED: return u'pause' def _status_time(frontend): @@ -197,19 +199,21 @@ def _status_time(frontend): _status_time_total(frontend) // 1000) def _status_time_elapsed(frontend): - return frontend.backend.playback.time_position + return frontend.backend.playback.time_position.get() def _status_time_total(frontend): - if frontend.backend.playback.current_track is None: + current_track = frontend.backend.playback.current_track.get() + if current_track is None: return 0 - elif frontend.backend.playback.current_track.length is None: + elif current_track.length is None: return 0 else: - return frontend.backend.playback.current_track.length + return current_track.length def _status_volume(frontend): - if frontend.backend.mixer.volume is not None: - return frontend.backend.mixer.volume + volume = frontend.mixer.volume.get() + if volume is not None: + return volume else: return 0 diff --git a/tests/frontends/mpd/regression_test.py b/tests/frontends/mpd/regression_test.py index 7e7163d8..1d661b5a 100644 --- a/tests/frontends/mpd/regression_test.py +++ b/tests/frontends/mpd/regression_test.py @@ -18,26 +18,31 @@ class IssueGH17RegressionTest(unittest.TestCase): """ def setUp(self): - self.backend = DummyBackend(mixer_class=DummyMixer) + self.backend = DummyBackend.start().proxy() self.backend.current_playlist.append([ Track(uri='a'), Track(uri='b'), None, Track(uri='d'), Track(uri='e'), Track(uri='f')]) - self.mpd = dispatcher.MpdDispatcher(backend=self.backend) + self.mixer = DummyMixer.start().proxy() + self.mpd = dispatcher.MpdDispatcher() + + def tearDown(self): + self.backend.stop().get() + self.mixer.stop().get() def test(self): random.seed(1) # Playlist order: abcfde self.mpd.handle_request(u'play') - self.assertEquals('a', self.backend.playback.current_track.uri) + self.assertEquals('a', self.backend.playback.current_track.get().uri) self.mpd.handle_request(u'random "1"') self.mpd.handle_request(u'next') - self.assertEquals('b', self.backend.playback.current_track.uri) + self.assertEquals('b', self.backend.playback.current_track.get().uri) self.mpd.handle_request(u'next') # Should now be at track 'c', but playback fails and it skips ahead - self.assertEquals('f', self.backend.playback.current_track.uri) + self.assertEquals('f', self.backend.playback.current_track.get().uri) self.mpd.handle_request(u'next') - self.assertEquals('d', self.backend.playback.current_track.uri) + self.assertEquals('d', self.backend.playback.current_track.get().uri) self.mpd.handle_request(u'next') - self.assertEquals('e', self.backend.playback.current_track.uri) + self.assertEquals('e', self.backend.playback.current_track.get().uri) class IssueGH18RegressionTest(unittest.TestCase): @@ -52,11 +57,16 @@ class IssueGH18RegressionTest(unittest.TestCase): """ def setUp(self): - self.backend = DummyBackend(mixer_class=DummyMixer) + self.backend = DummyBackend.start().proxy() self.backend.current_playlist.append([ Track(uri='a'), Track(uri='b'), Track(uri='c'), Track(uri='d'), Track(uri='e'), Track(uri='f')]) - self.mpd = dispatcher.MpdDispatcher(backend=self.backend) + self.mixer = DummyMixer.start().proxy() + self.mpd = dispatcher.MpdDispatcher() + + def tearDown(self): + self.backend.stop().get() + self.mixer.stop().get() def test(self): random.seed(1) @@ -67,11 +77,11 @@ class IssueGH18RegressionTest(unittest.TestCase): self.mpd.handle_request(u'next') self.mpd.handle_request(u'next') - cp_track_1 = self.backend.playback.current_cp_track + cp_track_1 = self.backend.playback.current_cp_track.get() self.mpd.handle_request(u'next') - cp_track_2 = self.backend.playback.current_cp_track + cp_track_2 = self.backend.playback.current_cp_track.get() self.mpd.handle_request(u'next') - cp_track_3 = self.backend.playback.current_cp_track + cp_track_3 = self.backend.playback.current_cp_track.get() self.assertNotEqual(cp_track_1, cp_track_2) self.assertNotEqual(cp_track_2, cp_track_3) @@ -91,11 +101,16 @@ class IssueGH22RegressionTest(unittest.TestCase): """ def setUp(self): - self.backend = DummyBackend(mixer_class=DummyMixer) + self.backend = DummyBackend.start().proxy() self.backend.current_playlist.append([ Track(uri='a'), Track(uri='b'), Track(uri='c'), Track(uri='d'), Track(uri='e'), Track(uri='f')]) - self.mpd = dispatcher.MpdDispatcher(backend=self.backend) + self.mixer = DummyMixer.start().proxy() + self.mpd = dispatcher.MpdDispatcher() + + def tearDown(self): + self.backend.stop().get() + self.mixer.stop().get() def test(self): random.seed(1) From f73268c332038b9e440679d7b9323da036a2324c Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:38:09 +0100 Subject: [PATCH 44/65] Update MPD/server --- tests/frontends/mpd/server_test.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/frontends/mpd/server_test.py b/tests/frontends/mpd/server_test.py index 48c7e790..ef963347 100644 --- a/tests/frontends/mpd/server_test.py +++ b/tests/frontends/mpd/server_test.py @@ -1,11 +1,19 @@ import unittest from mopidy import settings +from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import server +from mopidy.mixers.dummy import DummyMixer class MpdServerTest(unittest.TestCase): def setUp(self): - self.server = server.MpdServer(None) + self.backend = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.server = server.MpdServer() + + def tearDown(self): + self.backend.stop().get() + self.mixer.stop().get() def test_format_hostname_prefixes_ipv4_addresses_when_ipv6_available(self): server.socket.has_ipv6 = True @@ -20,9 +28,13 @@ class MpdServerTest(unittest.TestCase): class MpdSessionTest(unittest.TestCase): def setUp(self): - self.session = server.MpdSession(None, None, (None, None), None) + self.backend = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.session = server.MpdSession(None, None, (None, None)) def tearDown(self): + self.backend.stop().get() + self.mixer.stop().get() settings.runtime.clear() def test_found_terminator_catches_decode_error(self): From 0de8d1b4b8f2238972e38bc91bf3d39771ce1bd5 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:56:43 +0100 Subject: [PATCH 45/65] Update MPD/status --- mopidy/backends/base/playback.py | 26 +++++++++++------------ mopidy/frontends/mpd/protocol/status.py | 27 +++++++++++++----------- tests/frontends/mpd/status_test.py | 28 +++++++++++++++++-------- 3 files changed, 47 insertions(+), 34 deletions(-) diff --git a/mopidy/backends/base/playback.py b/mopidy/backends/base/playback.py index ce63abf7..2e690b4a 100644 --- a/mopidy/backends/base/playback.py +++ b/mopidy/backends/base/playback.py @@ -68,8 +68,8 @@ class PlaybackController(object): self._state = self.STOPPED self._shuffled = [] self._first_shuffle = True - self._play_time_accumulated = 0 - self._play_time_started = None + self.play_time_accumulated = 0 + self.play_time_started = None def destroy(self): """ @@ -275,7 +275,7 @@ class PlaybackController(object): def state(self, new_state): (old_state, self._state) = (self.state, new_state) logger.debug(u'Changing state: %s -> %s', old_state, new_state) - # FIXME _play_time stuff assumes backend does not have a better way of + # FIXME play_time stuff assumes backend does not have a better way of # handeling this stuff :/ if (old_state in (self.PLAYING, self.STOPPED) and new_state == self.PLAYING): @@ -290,23 +290,23 @@ class PlaybackController(object): """Time position in milliseconds.""" if self.state == self.PLAYING: time_since_started = (self._current_wall_time - - self._play_time_started) - return self._play_time_accumulated + time_since_started + self.play_time_started) + return self.play_time_accumulated + time_since_started elif self.state == self.PAUSED: - return self._play_time_accumulated + return self.play_time_accumulated elif self.state == self.STOPPED: return 0 def _play_time_start(self): - self._play_time_accumulated = 0 - self._play_time_started = self._current_wall_time + self.play_time_accumulated = 0 + self.play_time_started = self._current_wall_time def _play_time_pause(self): - time_since_started = self._current_wall_time - self._play_time_started - self._play_time_accumulated += time_since_started + time_since_started = self._current_wall_time - self.play_time_started + self.play_time_accumulated += time_since_started def _play_time_resume(self): - self._play_time_started = self._current_wall_time + self.play_time_started = self._current_wall_time @property def _current_wall_time(self): @@ -439,8 +439,8 @@ class PlaybackController(object): self.next() return True - self._play_time_started = self._current_wall_time - self._play_time_accumulated = time_position + self.play_time_started = self._current_wall_time + self.play_time_accumulated = time_position return self.provider.seek(time_position) diff --git a/mopidy/frontends/mpd/protocol/status.py b/mopidy/frontends/mpd/protocol/status.py index 9de82756..87d58f89 100644 --- a/mopidy/frontends/mpd/protocol/status.py +++ b/mopidy/frontends/mpd/protocol/status.py @@ -1,6 +1,6 @@ +from mopidy.backends.base import PlaybackController from mopidy.frontends.mpd.protocol import handle_pattern from mopidy.frontends.mpd.exceptions import MpdNotImplemented -from mopidy.backends.base import PlaybackController @handle_pattern(r'^clearerror$') def clearerror(frontend): @@ -24,10 +24,11 @@ def currentsong(frontend): Displays the song info of the current song (same song that is identified in status). """ - if frontend.backend.playback.current_track is not None: - return frontend.backend.playback.current_track.mpd_format( - position=frontend.backend.playback.current_playlist_position, - cpid=frontend.backend.playback.current_cpid) + current_cp_track = frontend.backend.playback.current_cp_track.get() + if current_cp_track is not None: + return current_cp_track[1].mpd_format( + position=frontend.backend.playback.current_playlist_position.get(), + cpid=current_cp_track[0]) @handle_pattern(r'^idle$') @handle_pattern(r'^idle (?P.+)$') @@ -141,19 +142,20 @@ def status(frontend): ('xfade', _status_xfade(frontend)), ('state', _status_state(frontend)), ] - if frontend.backend.playback.current_track is not None: + if frontend.backend.playback.current_track.get() is not None: result.append(('song', _status_songpos(frontend))) result.append(('songid', _status_songid(frontend))) - if frontend.backend.playback.state in (frontend.backend.playback.PLAYING, - frontend.backend.playback.PAUSED): + if frontend.backend.playback.state.get() in (PlaybackController.PLAYING, + PlaybackController.PAUSED): result.append(('time', _status_time(frontend))) result.append(('elapsed', _status_time_elapsed(frontend))) result.append(('bitrate', _status_bitrate(frontend))) return result def _status_bitrate(frontend): - if frontend.backend.playback.current_track is not None: - return frontend.backend.playback.current_track.get().bitrate + current_track = frontend.backend.playback.current_track.get() + if current_track is not None: + return current_track.bitrate def _status_consume(frontend): if frontend.backend.playback.consume.get(): @@ -177,8 +179,9 @@ def _status_single(frontend): return int(frontend.backend.playback.single.get()) def _status_songid(frontend): - if frontend.backend.playback.current_cpid is not None: - return frontend.backend.playback.current_cpid + current_cpid = frontend.backend.playback.current_cpid.get() + if current_cpid is not None: + return current_cpid else: return _status_songpos(frontend) diff --git a/tests/frontends/mpd/status_test.py b/tests/frontends/mpd/status_test.py index 1afe6ccd..791d734f 100644 --- a/tests/frontends/mpd/status_test.py +++ b/tests/frontends/mpd/status_test.py @@ -1,14 +1,24 @@ import unittest +from mopidy.backends.base import PlaybackController from mopidy.backends.dummy import DummyBackend from mopidy.frontends.mpd import dispatcher from mopidy.mixers.dummy import DummyMixer from mopidy.models import Track +PAUSED = PlaybackController.PAUSED +PLAYING = PlaybackController.PLAYING +STOPPED = PlaybackController.STOPPED + class StatusHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() + self.mixer.stop().get() def test_clearerror(self): result = self.h.handle_request(u'clearerror') @@ -77,7 +87,7 @@ class StatusHandlerTest(unittest.TestCase): self.assertEqual(int(result['volume']), 0) def test_status_method_contains_volume(self): - self.b.mixer.volume = 17 + self.mixer.volume = 17 result = dict(dispatcher.status.status(self.h)) self.assert_('volume' in result) self.assertEqual(int(result['volume']), 17) @@ -136,20 +146,20 @@ class StatusHandlerTest(unittest.TestCase): self.assert_(int(result['xfade']) >= 0) def test_status_method_contains_state_is_play(self): - self.b.playback.state = self.b.playback.PLAYING + self.b.playback.state = PLAYING result = dict(dispatcher.status.status(self.h)) self.assert_('state' in result) self.assertEqual(result['state'], 'play') def test_status_method_contains_state_is_stop(self): - self.b.playback.state = self.b.playback.STOPPED + self.b.playback.state = STOPPED result = dict(dispatcher.status.status(self.h)) self.assert_('state' in result) self.assertEqual(result['state'], 'stop') def test_status_method_contains_state_is_pause(self): - self.b.playback.state = self.b.playback.PLAYING - self.b.playback.state = self.b.playback.PAUSED + self.b.playback.state = PLAYING + self.b.playback.state = PAUSED result = dict(dispatcher.status.status(self.h)) self.assert_('state' in result) self.assertEqual(result['state'], 'pause') @@ -189,8 +199,8 @@ class StatusHandlerTest(unittest.TestCase): self.assert_(position <= total) def test_status_method_when_playing_contains_elapsed(self): - self.b.playback.state = self.b.playback.PAUSED - self.b.playback._play_time_accumulated = 59123 + self.b.playback.state = PAUSED + self.b.playback.play_time_accumulated = 59123 result = dict(dispatcher.status.status(self.h)) self.assert_('elapsed' in result) self.assertEqual(int(result['elapsed']), 59123) From 289cefc53a746254bf04d82bcc5871928f8ae47f Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 00:58:13 +0100 Subject: [PATCH 46/65] Update MPD/stickers --- tests/frontends/mpd/stickers_test.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/frontends/mpd/stickers_test.py b/tests/frontends/mpd/stickers_test.py index 5b66d723..83d43792 100644 --- a/tests/frontends/mpd/stickers_test.py +++ b/tests/frontends/mpd/stickers_test.py @@ -6,8 +6,13 @@ from mopidy.mixers.dummy import DummyMixer class StickersHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() + self.mixer.stop().get() def test_sticker_get(self): result = self.h.handle_request( From f0ebc242344ee03847c7da601fee8de49539d399 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 01:04:18 +0100 Subject: [PATCH 47/65] Update MPD/stored playlists --- .../mpd/protocol/stored_playlists.py | 9 ++++--- tests/frontends/mpd/stored_playlists_test.py | 26 ++++++++++++------- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/mopidy/frontends/mpd/protocol/stored_playlists.py b/mopidy/frontends/mpd/protocol/stored_playlists.py index f0a63544..6eccffac 100644 --- a/mopidy/frontends/mpd/protocol/stored_playlists.py +++ b/mopidy/frontends/mpd/protocol/stored_playlists.py @@ -19,8 +19,8 @@ def listplaylist(frontend, name): file: relative/path/to/file3.mp3 """ try: - return ['file: %s' % t.uri - for t in frontend.backend.stored_playlists.get(name=name).tracks] + playlist = frontend.backend.stored_playlists.get(name=name).get() + return ['file: %s' % t.uri for t in playlist.tracks] except LookupError: raise MpdNoExistError(u'No such playlist', command=u'listplaylist') @@ -39,7 +39,8 @@ def listplaylistinfo(frontend, name): Album, Artist, Track """ try: - return frontend.backend.stored_playlists.get(name=name).mpd_format() + playlist = frontend.backend.stored_playlists.get(name=name).get() + return playlist.mpd_format() except LookupError: raise MpdNoExistError( u'No such playlist', command=u'listplaylistinfo') @@ -92,7 +93,7 @@ def load(frontend, name): - ``load`` appends the given playlist to the current playlist. """ try: - playlist = frontend.backend.stored_playlists.get(name=name) + playlist = frontend.backend.stored_playlists.get(name=name).get() frontend.backend.current_playlist.append(playlist.tracks) except LookupError: raise MpdNoExistError(u'No such playlist', command=u'load') diff --git a/tests/frontends/mpd/stored_playlists_test.py b/tests/frontends/mpd/stored_playlists_test.py index a24cbb88..e981c9ed 100644 --- a/tests/frontends/mpd/stored_playlists_test.py +++ b/tests/frontends/mpd/stored_playlists_test.py @@ -8,8 +8,13 @@ from mopidy.models import Track, Playlist class StoredPlaylistsHandlerTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() + self.mixer.stop().get() def test_listplaylist(self): self.b.stored_playlists.playlists = [ @@ -49,22 +54,23 @@ class StoredPlaylistsHandlerTest(unittest.TestCase): def test_load_known_playlist_appends_to_current_playlist(self): self.b.current_playlist.append([Track(uri='a'), Track(uri='b')]) - self.assertEqual(len(self.b.current_playlist.tracks), 2) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 2) self.b.stored_playlists.playlists = [Playlist(name='A-list', tracks=[Track(uri='c'), Track(uri='d'), Track(uri='e')])] result = self.h.handle_request(u'load "A-list"') self.assert_(u'OK' in result) - self.assertEqual(len(self.b.current_playlist.tracks), 5) - self.assertEqual(self.b.current_playlist.tracks[0].uri, 'a') - self.assertEqual(self.b.current_playlist.tracks[1].uri, 'b') - self.assertEqual(self.b.current_playlist.tracks[2].uri, 'c') - self.assertEqual(self.b.current_playlist.tracks[3].uri, 'd') - self.assertEqual(self.b.current_playlist.tracks[4].uri, 'e') + tracks = self.b.current_playlist.tracks.get() + self.assertEqual(len(tracks), 5) + self.assertEqual(tracks[0].uri, 'a') + self.assertEqual(tracks[1].uri, 'b') + self.assertEqual(tracks[2].uri, 'c') + self.assertEqual(tracks[3].uri, 'd') + self.assertEqual(tracks[4].uri, 'e') def test_load_unknown_playlist_acks(self): result = self.h.handle_request(u'load "unknown playlist"') self.assert_(u'ACK [50@0] {load} No such playlist' in result) - self.assertEqual(len(self.b.current_playlist.tracks), 0) + self.assertEqual(len(self.b.current_playlist.tracks.get()), 0) def test_playlistadd(self): result = self.h.handle_request( From 20e55873e9dd46e4d9c339f01c4ef35952b463dd Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 01:10:32 +0100 Subject: [PATCH 48/65] Update MPD/command list --- tests/frontends/mpd/command_list_test.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/frontends/mpd/command_list_test.py b/tests/frontends/mpd/command_list_test.py index 6c801c3f..7ff96bac 100644 --- a/tests/frontends/mpd/command_list_test.py +++ b/tests/frontends/mpd/command_list_test.py @@ -6,8 +6,13 @@ from mopidy.mixers.dummy import DummyMixer class CommandListsTest(unittest.TestCase): def setUp(self): - self.b = DummyBackend(mixer_class=DummyMixer) - self.h = dispatcher.MpdDispatcher(backend=self.b) + self.b = DummyBackend.start().proxy() + self.mixer = DummyMixer.start().proxy() + self.h = dispatcher.MpdDispatcher() + + def tearDown(self): + self.b.stop().get() + self.mixer.stop().get() def test_command_list_begin(self): result = self.h.handle_request(u'command_list_begin') From bcff80c714b783cc9eced45ba49633a56c7e1055 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 01:14:33 +0100 Subject: [PATCH 49/65] Switch from multiprocessing.dummy to threading to fix startup issue --- mopidy/utils/process.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mopidy/utils/process.py b/mopidy/utils/process.py index 7a5ba62f..dbc6cada 100644 --- a/mopidy/utils/process.py +++ b/mopidy/utils/process.py @@ -1,5 +1,5 @@ import logging -import multiprocessing.dummy +import threading import gobject gobject.threads_init() @@ -9,7 +9,7 @@ from mopidy import SettingsError logger = logging.getLogger('mopidy.utils.process') -class BaseThread(multiprocessing.dummy.Process): +class BaseThread(threading.Thread): def __init__(self): super(BaseThread, self).__init__() # No thread should block process from exiting From 4087675334fdc833a4b828aac039cccfa342f646 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 01:14:51 +0100 Subject: [PATCH 50/65] Remove unused imports --- mopidy/backends/local/__init__.py | 1 - mopidy/core.py | 1 - mopidy/frontends/mpd/protocol/status.py | 3 +-- mopidy/frontends/mpd/session.py | 1 - mopidy/mixers/nad.py | 7 +++---- 5 files changed, 4 insertions(+), 9 deletions(-) diff --git a/mopidy/backends/local/__init__.py b/mopidy/backends/local/__init__.py index 80762c89..2a06ca61 100644 --- a/mopidy/backends/local/__init__.py +++ b/mopidy/backends/local/__init__.py @@ -1,6 +1,5 @@ import glob import logging -import multiprocessing import os import shutil diff --git a/mopidy/core.py b/mopidy/core.py index e21efd00..78f0dd6c 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -1,5 +1,4 @@ import logging -import multiprocessing import optparse import sys diff --git a/mopidy/frontends/mpd/protocol/status.py b/mopidy/frontends/mpd/protocol/status.py index 87d58f89..a78efc0a 100644 --- a/mopidy/frontends/mpd/protocol/status.py +++ b/mopidy/frontends/mpd/protocol/status.py @@ -92,8 +92,7 @@ def stats(frontend): 'artists': 0, # TODO 'albums': 0, # TODO 'songs': 0, # TODO - # TODO Does not work after multiprocessing branch merge - 'uptime': 0, # frontend.session.stats_uptime(), + 'uptime': 0, # TODO 'db_playtime': 0, # TODO 'db_update': 0, # TODO 'playtime': 0, # TODO diff --git a/mopidy/frontends/mpd/session.py b/mopidy/frontends/mpd/session.py index 78e6f624..5a473eca 100644 --- a/mopidy/frontends/mpd/session.py +++ b/mopidy/frontends/mpd/session.py @@ -1,6 +1,5 @@ import asynchat import logging -import multiprocessing from mopidy import settings from mopidy.frontends.mpd.dispatcher import MpdDispatcher diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index e12b8b92..3d279736 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -1,6 +1,5 @@ import logging -from serial import Serial -from multiprocessing import Pipe +import serial from pykka.actor import ThreadingActor @@ -84,8 +83,8 @@ class NadTalker(ThreadingActor): # Communication settings: 115200 bps 8N1 logger.info(u'Connecting to serial device "%s"', settings.MIXER_EXT_PORT) - self._device = Serial(port=settings.MIXER_EXT_PORT, baudrate=115200, - timeout=self.TIMEOUT) + self._device = serial.Serial(port=settings.MIXER_EXT_PORT, + baudrate=115200, timeout=self.TIMEOUT) self._get_device_model() def _set_device_to_known_state(self): From b67b57955606ec768ebdf8413e0fb625406a85e1 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 01:20:42 +0100 Subject: [PATCH 51/65] Spotify backend needs a reference to the output --- mopidy/backends/spotify/__init__.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mopidy/backends/spotify/__init__.py b/mopidy/backends/spotify/__init__.py index 021277f2..ff8e542c 100644 --- a/mopidy/backends/spotify/__init__.py +++ b/mopidy/backends/spotify/__init__.py @@ -1,10 +1,12 @@ import logging from pykka.actor import ThreadingActor +from pykka.registry import ActorRegistry from mopidy import settings from mopidy.backends.base import (Backend, CurrentPlaylistController, LibraryController, PlaybackController, StoredPlaylistsController) +from mopidy.outputs.base import BaseOutput logger = logging.getLogger('mopidy.backends.spotify') @@ -61,9 +63,14 @@ class SpotifyBackend(ThreadingActor, Backend): self.uri_handlers = [u'spotify:', u'http://open.spotify.com/'] + self.output = None self.spotify = None def post_start(self): + output_refs = ActorRegistry.get_by_class(BaseOutput) + assert len(output_refs) == 1, 'Expected exactly one running output.' + self.output = output_refs[0].proxy() + self.spotify = self._connect() def _connect(self): From b5da3c3404ab0d774a5d69b5ff4b25b95ce25c71 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 20 Mar 2011 01:37:06 +0100 Subject: [PATCH 52/65] GStreamerOutput need a reference to the backend for notifying it on end of track --- mopidy/outputs/gstreamer.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/mopidy/outputs/gstreamer.py b/mopidy/outputs/gstreamer.py index 2a3d9adc..29ffbecc 100644 --- a/mopidy/outputs/gstreamer.py +++ b/mopidy/outputs/gstreamer.py @@ -5,8 +5,10 @@ import gst import logging from pykka.actor import ThreadingActor +from pykka.registry import ActorRegistry from mopidy import settings +from mopidy.backends.base import Backend from mopidy.outputs.base import BaseOutput logger = logging.getLogger('mopidy.outputs.gstreamer') @@ -74,8 +76,8 @@ class GStreamerOutput(ThreadingActor, BaseOutput): """Process messages from GStreamer.""" if message.type == gst.MESSAGE_EOS: logger.debug(u'GStreamer signalled end-of-stream. ' - 'Sending end_of_track to core_queue ...') - self.core_queue.put({'command': 'end_of_track'}) + 'Telling backend ...') + self._get_backend().playback.on_end_of_track() elif message.type == gst.MESSAGE_ERROR: self.set_state('NULL') error, debug = message.parse_error() @@ -83,6 +85,11 @@ class GStreamerOutput(ThreadingActor, BaseOutput): # FIXME Should we send 'stop_playback' to the backend here? Can we # differentiate on how serious the error is? + def _get_backend(self): + backend_refs = ActorRegistry.get_by_class(Backend) + assert len(backend_refs) == 1, 'Expected exactly one running backend.' + return backend_refs[0].proxy() + def play_uri(self, uri): """Play audio at URI""" self.set_state('READY') From af118a3f256797c0976f049059df675750683aa6 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 21 Mar 2011 00:18:12 +0100 Subject: [PATCH 53/65] Fix future usage in LocalBackend --- mopidy/backends/local/__init__.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mopidy/backends/local/__init__.py b/mopidy/backends/local/__init__.py index 2a06ca61..b4a407f9 100644 --- a/mopidy/backends/local/__init__.py +++ b/mopidy/backends/local/__init__.py @@ -67,24 +67,24 @@ class LocalPlaybackController(PlaybackController): @property def time_position(self): - return self.backend.output.get_position() + return self.backend.output.get_position().get() class LocalPlaybackProvider(BasePlaybackProvider): def pause(self): - return self.backend.output.set_state('PAUSED') + return self.backend.output.set_state('PAUSED').get() def play(self, track): - return self.backend.output.play_uri(track.uri) + return self.backend.output.play_uri(track.uri).get() def resume(self): - return self.backend.output.set_state('PLAYING') + return self.backend.output.set_state('PLAYING').get() def seek(self, time_position): - return self.backend.output.set_position(time_position) + return self.backend.output.set_position(time_position).get() def stop(self): - return self.backend.output.set_state('READY') + return self.backend.output.set_state('READY').get() class LocalStoredPlaylistsProvider(BaseStoredPlaylistsProvider): From b83dad78457af09e012c79e334cbfb2066952a0b Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Mon, 21 Mar 2011 00:34:54 +0100 Subject: [PATCH 54/65] Update tests to match change in previous commit --- tests/backends/base/playback.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/backends/base/playback.py b/tests/backends/base/playback.py index aa200047..8ea48a3a 100644 --- a/tests/backends/base/playback.py +++ b/tests/backends/base/playback.py @@ -727,12 +727,18 @@ class PlaybackControllerTest(object): self.assertEqual(self.playback.stop(), None) def test_time_position_when_stopped(self): - self.backend.output.get_position = mock.Mock(return_value=0) + future = mock.Mock() + future.get = mock.Mock(return_value=0) + self.backend.output.get_position = mock.Mock(return_value=future) + self.assertEqual(self.playback.time_position, 0) @populate_playlist def test_time_position_when_stopped_with_playlist(self): - self.backend.output.get_position = mock.Mock(return_value=0) + future = mock.Mock() + future.get = mock.Mock(return_value=0) + self.backend.output.get_position = mock.Mock(return_value=future) + self.assertEqual(self.playback.time_position, 0) @SkipTest # Uses sleep and does not work with LocalBackend+DummyOutput From e79346b5c3aa9185ca21d0026c94675c456e3e09 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 23 Mar 2011 22:19:36 +0100 Subject: [PATCH 55/65] Remove unused import --- mopidy/core.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/mopidy/core.py b/mopidy/core.py index 78f0dd6c..b2361e59 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -2,8 +2,6 @@ import logging import optparse import sys -from pykka.actor import ThreadingActor - from mopidy import get_version, settings, OptionalDependencyError from mopidy.utils import get_class from mopidy.utils.log import setup_logging From 4f546246f835b6dc6f1a731939948af22c28fba6 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 23 Mar 2011 22:24:04 +0100 Subject: [PATCH 56/65] Fix sound with Spotify backend (YAY :-) ) --- mopidy/outputs/gstreamer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mopidy/outputs/gstreamer.py b/mopidy/outputs/gstreamer.py index 29ffbecc..0eb716ec 100644 --- a/mopidy/outputs/gstreamer.py +++ b/mopidy/outputs/gstreamer.py @@ -96,7 +96,7 @@ class GStreamerOutput(ThreadingActor, BaseOutput): self.gst_pipeline.get_by_name('uri').set_property('uri', uri) return self.set_state('PLAYING') - def deliver_data(self, capabilities, data): + def deliver_data(self, caps_string, data): """Deliver audio data to be played""" app_src = self.gst_pipeline.get_by_name('appsrc') caps = gst.caps_from_string(caps_string) From d7149d8ea09c897fb954652beeef3bf008448d9e Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 23 Mar 2011 22:37:20 +0100 Subject: [PATCH 57/65] Raise EnvironmentError instead of Exception to make pylint happy --- mopidy/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mopidy/__init__.py b/mopidy/__init__.py index 873ee182..e9ced3ae 100644 --- a/mopidy/__init__.py +++ b/mopidy/__init__.py @@ -9,7 +9,7 @@ VERSION = (0, 4, 0) def get_git_version(): process = Popen(['git', 'describe'], stdout=PIPE, stderr=PIPE) if process.wait() != 0: - raise Exception('Execution of "git describe" failed') + raise EnvironmentError('Execution of "git describe" failed') version = process.stdout.read().strip() if version.startswith('v'): version = version[1:] @@ -21,7 +21,7 @@ def get_plain_version(): def get_version(): try: return get_git_version() - except Exception: + except EnvironmentError: return get_plain_version() class MopidyException(Exception): From a0805ba80fa3d24ec59bd9e58c76fd0d043a179c Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 23 Mar 2011 22:37:36 +0100 Subject: [PATCH 58/65] Remove unused imports --- mopidy/core.py | 1 - mopidy/frontends/lastfm.py | 1 - mopidy/mixers/nad.py | 1 - 3 files changed, 3 deletions(-) diff --git a/mopidy/core.py b/mopidy/core.py index b2361e59..9c4d63d4 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -1,6 +1,5 @@ import logging import optparse -import sys from mopidy import get_version, settings, OptionalDependencyError from mopidy.utils import get_class diff --git a/mopidy/frontends/lastfm.py b/mopidy/frontends/lastfm.py index d723052e..84e612fa 100644 --- a/mopidy/frontends/lastfm.py +++ b/mopidy/frontends/lastfm.py @@ -11,7 +11,6 @@ from pykka.actor import ThreadingActor from mopidy import settings, SettingsError from mopidy.frontends.base import BaseFrontend -from mopidy.utils.process import BaseThread logger = logging.getLogger('mopidy.frontends.lastfm') diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index 3d279736..65eff58c 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -5,7 +5,6 @@ from pykka.actor import ThreadingActor from mopidy import settings from mopidy.mixers.base import BaseMixer -from mopidy.utils.process import BaseThread logger = logging.getLogger('mopidy.mixers.nad') From b07f37117f1edbbb3b2cb02a027b7d6d9e41cd9c Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 23 Mar 2011 22:43:32 +0100 Subject: [PATCH 59/65] Fix Pylint error --- mopidy/frontends/mpd/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index c7f469dd..608d9586 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -33,7 +33,7 @@ class MpdFrontend(ThreadingActor, BaseFrontend): class MpdThread(BaseThread): def __init__(self): - super(BaseThread, self).__init__() + super(MpdThread, self).__init__() self.name = u'MpdThread' def run_inside_try(self): From 168d6ea434852b1214c4c6b26985601955a6fc3f Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 23 Mar 2011 23:05:20 +0100 Subject: [PATCH 60/65] Replace last multiprocessing.Connection with Queue.Queue --- mopidy/backends/spotify/library.py | 10 ++++------ mopidy/backends/spotify/session_manager.py | 4 ++-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/mopidy/backends/spotify/library.py b/mopidy/backends/spotify/library.py index 5e2f66ae..2e7dbab1 100644 --- a/mopidy/backends/spotify/library.py +++ b/mopidy/backends/spotify/library.py @@ -1,5 +1,5 @@ import logging -import multiprocessing +import Queue from spotify import Link, SpotifyError @@ -54,8 +54,6 @@ class SpotifyLibraryProvider(BaseLibraryProvider): spotify_query.append(u'%s:"%s"' % (field, value)) spotify_query = u' '.join(spotify_query) logger.debug(u'Spotify search query: %s' % spotify_query) - my_end, other_end = multiprocessing.Pipe() - self.backend.spotify.search(spotify_query.encode(ENCODING), other_end) - my_end.poll(None) - playlist = my_end.recv() - return playlist + queue = Queue.Queue() + self.backend.spotify.search(spotify_query.encode(ENCODING), queue) + return queue.get() diff --git a/mopidy/backends/spotify/session_manager.py b/mopidy/backends/spotify/session_manager.py index ed4d665c..64d2b338 100644 --- a/mopidy/backends/spotify/session_manager.py +++ b/mopidy/backends/spotify/session_manager.py @@ -126,13 +126,13 @@ class SpotifySessionManager(BaseThread, PyspotifySessionManager): self.backend.stored_playlists = playlists logger.debug(u'Refreshed %d stored playlist(s)', len(playlists)) - def search(self, query, connection): + def search(self, query, queue): """Search method used by Mopidy backend""" def callback(results, userdata=None): # TODO Include results from results.albums(), etc. too playlist = Playlist(tracks=[ SpotifyTranslator.to_mopidy_track(t) for t in results.tracks()]) - connection.send(playlist) + queue.put(playlist) self.connected.wait() self.session.search(query, callback) From be42217d3bcd9e08c4c87c6f9978c0699996e4b6 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Thu, 24 Mar 2011 06:58:16 +0100 Subject: [PATCH 61/65] Fix 'stored_playlists does not have "playlists" attribute' error --- mopidy/backends/spotify/session_manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mopidy/backends/spotify/session_manager.py b/mopidy/backends/spotify/session_manager.py index 64d2b338..398e24fe 100644 --- a/mopidy/backends/spotify/session_manager.py +++ b/mopidy/backends/spotify/session_manager.py @@ -123,7 +123,7 @@ class SpotifySessionManager(BaseThread, PyspotifySessionManager): playlists.append( SpotifyTranslator.to_mopidy_playlist(spotify_playlist)) playlists = filter(None, playlists) - self.backend.stored_playlists = playlists + self.backend.stored_playlists.playlists = playlists logger.debug(u'Refreshed %d stored playlist(s)', len(playlists)) def search(self, query, queue): From 5d6fc7b092aba7bf95f98a80407b01dd0469fe1a Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Thu, 24 Mar 2011 13:52:41 +0100 Subject: [PATCH 62/65] Avoid blocking forever waiting on search query responses from Spotify --- mopidy/backends/spotify/library.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mopidy/backends/spotify/library.py b/mopidy/backends/spotify/library.py index 2e7dbab1..40d4a099 100644 --- a/mopidy/backends/spotify/library.py +++ b/mopidy/backends/spotify/library.py @@ -56,4 +56,7 @@ class SpotifyLibraryProvider(BaseLibraryProvider): logger.debug(u'Spotify search query: %s' % spotify_query) queue = Queue.Queue() self.backend.spotify.search(spotify_query.encode(ENCODING), queue) - return queue.get() + try: + return queue.get(timeout=3) # XXX What is an reasonable timeout? + except Queue.Empty: + return Playlist(tracks=[]) From 4452957c10d0a485b417cc06b4a83a96b549203d Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 30 Mar 2011 00:39:19 +0200 Subject: [PATCH 63/65] Require Pykka 0.12 (not released yet) --- docs/installation/index.rst | 2 +- mopidy/backends/local/__init__.py | 2 +- mopidy/backends/spotify/__init__.py | 2 +- mopidy/frontends/lastfm.py | 2 +- mopidy/frontends/mpd/__init__.py | 2 +- mopidy/mixers/alsa.py | 2 +- mopidy/mixers/denon.py | 2 +- mopidy/mixers/gstreamer_software.py | 2 +- mopidy/mixers/nad.py | 2 +- mopidy/outputs/gstreamer.py | 2 +- requirements/core.txt | 2 +- tests/outputs/gstreamer_test.py | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/installation/index.rst b/docs/installation/index.rst index 3ef5af99..d1fbd0f6 100644 --- a/docs/installation/index.rst +++ b/docs/installation/index.rst @@ -25,7 +25,7 @@ Otherwise, make sure you got the required dependencies installed. - Python >= 2.6, < 3 -- `Pykka `_ >= 0.11 +- `Pykka `_ >= 0.12 - GStreamer >= 0.10, with Python bindings. See :doc:`gstreamer`. diff --git a/mopidy/backends/local/__init__.py b/mopidy/backends/local/__init__.py index b4a407f9..58cb405d 100644 --- a/mopidy/backends/local/__init__.py +++ b/mopidy/backends/local/__init__.py @@ -52,7 +52,7 @@ class LocalBackend(ThreadingActor, Backend): self.output = None - def post_start(self): + def pre_start(self): output_refs = ActorRegistry.get_by_class(BaseOutput) assert len(output_refs) == 1, 'Expected exactly one running output.' self.output = output_refs[0].proxy() diff --git a/mopidy/backends/spotify/__init__.py b/mopidy/backends/spotify/__init__.py index ff8e542c..9f2cd99f 100644 --- a/mopidy/backends/spotify/__init__.py +++ b/mopidy/backends/spotify/__init__.py @@ -66,7 +66,7 @@ class SpotifyBackend(ThreadingActor, Backend): self.output = None self.spotify = None - def post_start(self): + def pre_start(self): output_refs = ActorRegistry.get_by_class(BaseOutput) assert len(output_refs) == 1, 'Expected exactly one running output.' self.output = output_refs[0].proxy() diff --git a/mopidy/frontends/lastfm.py b/mopidy/frontends/lastfm.py index 84e612fa..8d6cf2a8 100644 --- a/mopidy/frontends/lastfm.py +++ b/mopidy/frontends/lastfm.py @@ -40,7 +40,7 @@ class LastfmFrontend(ThreadingActor, BaseFrontend): self.lastfm = None self.last_start_time = None - def post_start(self): + def pre_start(self): try: username = settings.LASTFM_USERNAME password_hash = pylast.md5(settings.LASTFM_PASSWORD) diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index 608d9586..6c39a09b 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -23,7 +23,7 @@ class MpdFrontend(ThreadingActor, BaseFrontend): def __init__(self): self._thread = None - def post_start(self): + def pre_start(self): self._thread = MpdThread() self._thread.start() diff --git a/mopidy/mixers/alsa.py b/mopidy/mixers/alsa.py index f19819e8..a7f5431e 100644 --- a/mopidy/mixers/alsa.py +++ b/mopidy/mixers/alsa.py @@ -25,7 +25,7 @@ class AlsaMixer(ThreadingActor, BaseMixer): def __init__(self): self._mixer = None - def post_start(self): + def pre_start(self): self._mixer = alsaaudio.Mixer(self._get_mixer_control()) assert self._mixer is not None diff --git a/mopidy/mixers/denon.py b/mopidy/mixers/denon.py index 832e7d1a..966f804a 100644 --- a/mopidy/mixers/denon.py +++ b/mopidy/mixers/denon.py @@ -30,7 +30,7 @@ class DenonMixer(ThreadingActor, BaseMixer): self._levels = ['99'] + ["%(#)02d" % {'#': v} for v in range(0, 99)] self._volume = 0 - def post_start(self): + def pre_start(self): if self._device is None: from serial import Serial self._device = Serial(port=settings.MIXER_EXT_PORT, timeout=0.2) diff --git a/mopidy/mixers/gstreamer_software.py b/mopidy/mixers/gstreamer_software.py index 2125aab3..b93e1b52 100644 --- a/mopidy/mixers/gstreamer_software.py +++ b/mopidy/mixers/gstreamer_software.py @@ -10,7 +10,7 @@ class GStreamerSoftwareMixer(ThreadingActor, BaseMixer): def __init__(self): self.output = None - def post_start(self): + def pre_start(self): output_refs = ActorRegistry.get_by_class(BaseOutput) assert len(output_refs) == 1, 'Expected exactly one running output.' self.output = output_refs[0].proxy() diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index 65eff58c..db4b40c1 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -73,7 +73,7 @@ class NadTalker(ThreadingActor): def __init__(self): self._device = None - def post_start(self): + def pre_start(self): self._open_connection() self._set_device_to_known_state() diff --git a/mopidy/outputs/gstreamer.py b/mopidy/outputs/gstreamer.py index 0eb716ec..37bfb35c 100644 --- a/mopidy/outputs/gstreamer.py +++ b/mopidy/outputs/gstreamer.py @@ -26,7 +26,7 @@ class GStreamerOutput(ThreadingActor, BaseOutput): def __init__(self): self.gst_pipeline = None - def post_start(self): + def pre_start(self): self._setup_gstreamer() def _setup_gstreamer(self): diff --git a/requirements/core.txt b/requirements/core.txt index f0f0bd39..aaae84f8 100644 --- a/requirements/core.txt +++ b/requirements/core.txt @@ -1 +1 @@ -Pykka >= 0.11 +Pykka >= 0.12 diff --git a/tests/outputs/gstreamer_test.py b/tests/outputs/gstreamer_test.py index 801f476e..4e101319 100644 --- a/tests/outputs/gstreamer_test.py +++ b/tests/outputs/gstreamer_test.py @@ -19,7 +19,7 @@ class GStreamerOutputTest(unittest.TestCase): settings.BACKENDS = ('mopidy.backends.local.LocalBackend',) self.song_uri = path_to_uri(data_folder('song1.wav')) self.output = GStreamerOutput() - self.output.post_start() + self.output.pre_start() def tearDown(self): settings.runtime.clear() From 62f07cdd7ff08f7aa201504deeda12234be4d904 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 30 Mar 2011 23:08:36 +0200 Subject: [PATCH 64/65] Sleep forever when main() is done to be able to catch KeyboardInterrupt --- mopidy/core.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mopidy/core.py b/mopidy/core.py index 9c4d63d4..a1c6b361 100644 --- a/mopidy/core.py +++ b/mopidy/core.py @@ -1,5 +1,8 @@ import logging import optparse +import time + +from pykka.registry import ActorRegistry from mopidy import get_version, settings, OptionalDependencyError from mopidy.utils import get_class @@ -19,6 +22,11 @@ def main(): setup_mixer() setup_backend() setup_frontends() + try: + time.sleep(10000*24*60*60) + except KeyboardInterrupt: + logger.info(u'Exiting...') + ActorRegistry.stop_all() def parse_options(): parser = optparse.OptionParser(version='Mopidy %s' % get_version()) From 4703783eed3c20f39654a05496b310e2d34ef49f Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 30 Mar 2011 23:28:54 +0200 Subject: [PATCH 65/65] Upgrade to work with final release of Pykka 0.12 --- mopidy/backends/local/__init__.py | 2 +- mopidy/backends/spotify/__init__.py | 2 +- mopidy/frontends/lastfm.py | 4 ++-- mopidy/frontends/mpd/__init__.py | 4 ++-- mopidy/mixers/alsa.py | 2 +- mopidy/mixers/denon.py | 2 +- mopidy/mixers/gstreamer_software.py | 2 +- mopidy/mixers/nad.py | 2 +- mopidy/outputs/gstreamer.py | 2 +- tests/outputs/gstreamer_test.py | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/mopidy/backends/local/__init__.py b/mopidy/backends/local/__init__.py index 58cb405d..2fa96dab 100644 --- a/mopidy/backends/local/__init__.py +++ b/mopidy/backends/local/__init__.py @@ -52,7 +52,7 @@ class LocalBackend(ThreadingActor, Backend): self.output = None - def pre_start(self): + def on_start(self): output_refs = ActorRegistry.get_by_class(BaseOutput) assert len(output_refs) == 1, 'Expected exactly one running output.' self.output = output_refs[0].proxy() diff --git a/mopidy/backends/spotify/__init__.py b/mopidy/backends/spotify/__init__.py index 9f2cd99f..1ac5f0be 100644 --- a/mopidy/backends/spotify/__init__.py +++ b/mopidy/backends/spotify/__init__.py @@ -66,7 +66,7 @@ class SpotifyBackend(ThreadingActor, Backend): self.output = None self.spotify = None - def pre_start(self): + def on_start(self): output_refs = ActorRegistry.get_by_class(BaseOutput) assert len(output_refs) == 1, 'Expected exactly one running output.' self.output = output_refs[0].proxy() diff --git a/mopidy/frontends/lastfm.py b/mopidy/frontends/lastfm.py index 8d6cf2a8..04716c61 100644 --- a/mopidy/frontends/lastfm.py +++ b/mopidy/frontends/lastfm.py @@ -40,7 +40,7 @@ class LastfmFrontend(ThreadingActor, BaseFrontend): self.lastfm = None self.last_start_time = None - def pre_start(self): + def on_start(self): try: username = settings.LASTFM_USERNAME password_hash = pylast.md5(settings.LASTFM_PASSWORD) @@ -57,7 +57,7 @@ class LastfmFrontend(ThreadingActor, BaseFrontend): logger.error(u'Error during Last.fm setup: %s', e) self.stop() - def react(self, message): + def on_receive(self, message): if message.get('command') == 'started_playing': self.started_playing(message['track']) elif message.get('command') == 'stopped_playing': diff --git a/mopidy/frontends/mpd/__init__.py b/mopidy/frontends/mpd/__init__.py index 6c39a09b..24c21c38 100644 --- a/mopidy/frontends/mpd/__init__.py +++ b/mopidy/frontends/mpd/__init__.py @@ -23,11 +23,11 @@ class MpdFrontend(ThreadingActor, BaseFrontend): def __init__(self): self._thread = None - def pre_start(self): + def on_start(self): self._thread = MpdThread() self._thread.start() - def react(self, message): + def on_receive(self, message): pass # Ignore any messages diff --git a/mopidy/mixers/alsa.py b/mopidy/mixers/alsa.py index a7f5431e..6329bbbb 100644 --- a/mopidy/mixers/alsa.py +++ b/mopidy/mixers/alsa.py @@ -25,7 +25,7 @@ class AlsaMixer(ThreadingActor, BaseMixer): def __init__(self): self._mixer = None - def pre_start(self): + def on_start(self): self._mixer = alsaaudio.Mixer(self._get_mixer_control()) assert self._mixer is not None diff --git a/mopidy/mixers/denon.py b/mopidy/mixers/denon.py index 966f804a..3922d20a 100644 --- a/mopidy/mixers/denon.py +++ b/mopidy/mixers/denon.py @@ -30,7 +30,7 @@ class DenonMixer(ThreadingActor, BaseMixer): self._levels = ['99'] + ["%(#)02d" % {'#': v} for v in range(0, 99)] self._volume = 0 - def pre_start(self): + def on_start(self): if self._device is None: from serial import Serial self._device = Serial(port=settings.MIXER_EXT_PORT, timeout=0.2) diff --git a/mopidy/mixers/gstreamer_software.py b/mopidy/mixers/gstreamer_software.py index b93e1b52..d6365b4b 100644 --- a/mopidy/mixers/gstreamer_software.py +++ b/mopidy/mixers/gstreamer_software.py @@ -10,7 +10,7 @@ class GStreamerSoftwareMixer(ThreadingActor, BaseMixer): def __init__(self): self.output = None - def pre_start(self): + def on_start(self): output_refs = ActorRegistry.get_by_class(BaseOutput) assert len(output_refs) == 1, 'Expected exactly one running output.' self.output = output_refs[0].proxy() diff --git a/mopidy/mixers/nad.py b/mopidy/mixers/nad.py index db4b40c1..bd53376e 100644 --- a/mopidy/mixers/nad.py +++ b/mopidy/mixers/nad.py @@ -73,7 +73,7 @@ class NadTalker(ThreadingActor): def __init__(self): self._device = None - def pre_start(self): + def on_start(self): self._open_connection() self._set_device_to_known_state() diff --git a/mopidy/outputs/gstreamer.py b/mopidy/outputs/gstreamer.py index 37bfb35c..0596addb 100644 --- a/mopidy/outputs/gstreamer.py +++ b/mopidy/outputs/gstreamer.py @@ -26,7 +26,7 @@ class GStreamerOutput(ThreadingActor, BaseOutput): def __init__(self): self.gst_pipeline = None - def pre_start(self): + def on_start(self): self._setup_gstreamer() def _setup_gstreamer(self): diff --git a/tests/outputs/gstreamer_test.py b/tests/outputs/gstreamer_test.py index 4e101319..d2e3c263 100644 --- a/tests/outputs/gstreamer_test.py +++ b/tests/outputs/gstreamer_test.py @@ -19,7 +19,7 @@ class GStreamerOutputTest(unittest.TestCase): settings.BACKENDS = ('mopidy.backends.local.LocalBackend',) self.song_uri = path_to_uri(data_folder('song1.wav')) self.output = GStreamerOutput() - self.output.pre_start() + self.output.on_start() def tearDown(self): settings.runtime.clear()