Another round of review comments

This commit is contained in:
Lasse Bigum 2013-11-09 01:22:27 +01:00
parent 093c0400a9
commit c776565f65
2 changed files with 4 additions and 4 deletions

View File

@ -145,8 +145,8 @@ def audio_data_to_track(data):
track_kwargs['length'] = data[gst.TAG_DURATION] // gst.MSECOND
track_kwargs['album'] = Album(**album_kwargs)
if ('name' in artist_kwargs and
type(artist_kwargs['name']) is list):
if ('name' in artist_kwargs
and not isinstance(artist_kwargs['name'], basestring)):
track_kwargs['artists'] = [Artist(name=artist)
for artist in artist_kwargs['name']]
else:

View File

@ -79,8 +79,8 @@ class TranslatorTest(unittest.TestCase):
self.album['artists'] = [Artist(**self.albumartist)]
self.track['album'] = Album(**self.album)
if ('name' in self.artist and
type(self.artist['name']) is list):
if ('name' in self.artist
and not isinstance(self.artist['name'], basestring)):
self.track['artists'] = [Artist(name=artist)
for artist in self.artist['name']]
else: