From d2a51f712868372d51d30881437b0628fca35fa6 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sun, 6 Jan 2013 22:04:56 +0100 Subject: [PATCH] models: Add Album.num_discs (#286) --- docs/changes.rst | 2 ++ mopidy/models.py | 5 +++++ tests/models_test.py | 8 +++++++- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/docs/changes.rst b/docs/changes.rst index 475d30db..2f424cd7 100644 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -40,6 +40,8 @@ v0.11.2 (UNRELEASED) - Add :attr:`mopidy.models.Track.disc_no` field. (Partly fixes: :issue:`286`) +- Add :attr:`mopidy.models.Album.num_discs` field. (Partly fixes: :issue:`286`) + v0.11.1 (2012-12-24) ==================== diff --git a/mopidy/models.py b/mopidy/models.py index 1e9ad2c1..39d29fd3 100644 --- a/mopidy/models.py +++ b/mopidy/models.py @@ -163,6 +163,8 @@ class Album(ImmutableObject): :type artists: list of :class:`Artist` :param num_tracks: number of tracks in album :type num_tracks: integer + :param num_discs: number of discs in album + :type num_discs: integer or :class:`None` if unknown :param date: album release date (YYYY or YYYY-MM-DD) :type date: string :param musicbrainz_id: MusicBrainz ID @@ -183,6 +185,9 @@ class Album(ImmutableObject): #: The number of tracks in the album. Read-only. num_tracks = 0 + #: The number of discs in the album. Read-only. + num_discs = None + #: The album release date. Read-only. date = None diff --git a/tests/models_test.py b/tests/models_test.py index fdac575b..08a8c6f0 100644 --- a/tests/models_test.py +++ b/tests/models_test.py @@ -199,10 +199,16 @@ class AlbumTest(unittest.TestCase): def test_num_tracks(self): num_tracks = 11 - album = Album(num_tracks=11) + album = Album(num_tracks=num_tracks) self.assertEqual(album.num_tracks, num_tracks) self.assertRaises(AttributeError, setattr, album, 'num_tracks', None) + def test_num_discs(self): + num_discs = 2 + album = Album(num_discs=num_discs) + self.assertEqual(album.num_discs, num_discs) + self.assertRaises(AttributeError, setattr, album, 'num_discs', None) + def test_date(self): date = '1977-01-01' album = Album(date=date)