From db4f2d135f8259cd387c51836d50f27688452da1 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Wed, 27 Jul 2011 00:53:18 +0200 Subject: [PATCH] Add missing tests for default impl of listener methods --- mopidy/listeners.py | 4 ++-- tests/listeners_test.py | 20 ++++++++++++++++---- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/mopidy/listeners.py b/mopidy/listeners.py index cdf693de..bb855b4d 100644 --- a/mopidy/listeners.py +++ b/mopidy/listeners.py @@ -14,8 +14,8 @@ class BackendListener(object): @staticmethod def send(event, **kwargs): """Helper to allow calling of backend listener events""" - # FIXME this should be updated once pykka supports non-blocking calls - # on proxies or some similar solution + # FIXME this should be updated once Pykka supports non-blocking calls + # on proxies or some similar solution. registry.ActorRegistry.broadcast({ 'command': 'pykka_call', 'attr_path': (event,), diff --git a/tests/listeners_test.py b/tests/listeners_test.py index 72737a9d..f2156d05 100644 --- a/tests/listeners_test.py +++ b/tests/listeners_test.py @@ -7,14 +7,26 @@ class BackendListenerTest(unittest.TestCase): def setUp(self): self.listener = BackendListener() - def test_listener_has_default_impl_for_the_track_playback_paused_event(self): + def test_listener_has_default_impl_for_track_playback_paused(self): self.listener.track_playback_paused(Track(), 0) - def test_listener_has_default_impl_for_the_track_playback_resumed_event(self): + def test_listener_has_default_impl_for_track_playback_resumed(self): self.listener.track_playback_resumed(Track(), 0) - def test_listener_has_default_impl_for_the_track_playback_started(self): + def test_listener_has_default_impl_for_track_playback_started(self): self.listener.track_playback_started(Track()) - def test_listener_has_default_impl_for_the_track_playback_ended(self): + def test_listener_has_default_impl_for_track_playback_ended(self): self.listener.track_playback_ended(Track(), 0) + + def test_listener_has_default_impl_for_playback_state_changed(self): + self.listener.playback_state_changed() + + def test_listener_has_default_impl_for_playlist_changed(self): + self.listener.playlist_changed() + + def test_listener_has_default_impl_for_options_changed(self): + self.listener.options_changed() + + def test_listener_has_default_impl_for_volume_changed(self): + self.listener.volume_changed()