From dffea519a79977c068a97ea294e4de4aed313518 Mon Sep 17 00:00:00 2001 From: Stein Magnus Jodal Date: Sat, 23 Mar 2013 23:48:18 +0100 Subject: [PATCH] core: Warn if track isn't playable --- docs/changes.rst | 5 +++++ mopidy/core/playback.py | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/changes.rst b/docs/changes.rst index defe0033..a8012710 100644 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -10,6 +10,11 @@ v0.13.0 (in development) (in development) +**Core** + +- Log a warning if a track isn't playable to make it more obvious that backend + X needs backend Y to be present for playback to work. + **Spotify backend** - Let GStreamer handle time position tracking and seeks. (Fixes: :issue:`191`) diff --git a/mopidy/core/playback.py b/mopidy/core/playback.py index 21f09ad2..2e79827a 100644 --- a/mopidy/core/playback.py +++ b/mopidy/core/playback.py @@ -397,13 +397,14 @@ class PlaybackController(object): self.state = PlaybackState.PLAYING backend = self._get_backend() if not backend or not backend.playback.play(tl_track.track).get(): - # Track is not playable + logger.warning('Track is not playable: %s', tl_track.track.uri) if self.random and self._shuffled: self._shuffled.remove(tl_track) if on_error_step == 1: self.next() elif on_error_step == -1: self.previous() + return if self.random and self.current_tl_track in self._shuffled: self._shuffled.remove(self.current_tl_track)