andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make MPRIS frontend handle unknown volume

Browse Source
This commit is contained in:
Stein Magnus Jodal 2012-09-08 01:24:48 +02:00
parent ebead0d0d2
commit e3ba389996
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mopidy/frontends/mpris/objects.py
View File

@ -371,8 +371,9 @@ class MprisObject(dbus.service.Object):
def get_Volume(self):
volume = self.backend.playback.volume.get()
if volume is not None:
return volume / 100.0
if volume is None:
return 0
return volume / 100.0
def set_Volume(self, value):
if not self.get_CanControl():

4
tests/frontends/mpris/player_interface_test.py
View File

@ -205,6 +205,10 @@ class PlayerInterfaceTest(unittest.TestCase):
self.assertEquals(result['xesam:trackNumber'], 7)
def test_get_volume_should_return_volume_between_zero_and_one(self):
self.backend.playback.volume = None
result = self.mpris.Get(objects.PLAYER_IFACE, 'Volume')
self.assertEquals(result, 0)
self.backend.playback.volume = 0
result = self.mpris.Get(objects.PLAYER_IFACE, 'Volume')
self.assertEquals(result, 0)