From 522ae022f399cb8408f10a87f83ff527c16214a1 Mon Sep 17 00:00:00 2001 From: Btjones711 Date: Thu, 26 Jan 2017 16:28:58 -0600 Subject: [PATCH 1/3] -Changed Idle's list command to True to stay in convention with MPD --- mopidy/mpd/protocol/status.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mopidy/mpd/protocol/status.py b/mopidy/mpd/protocol/status.py index 3d76d35f..7eace9c7 100644 --- a/mopidy/mpd/protocol/status.py +++ b/mopidy/mpd/protocol/status.py @@ -42,7 +42,7 @@ def currentsong(context): tl_track, position=position, stream_title=stream_title) -@protocol.commands.add('idle', list_command=False) +@protocol.commands.add('idle', list_command=True) def idle(context, *subsystems): """ *musicpd.org, status section:* From 4fd86c37a760547a550f130efbef3930161b28b8 Mon Sep 17 00:00:00 2001 From: Btjones711 Date: Thu, 26 Jan 2017 21:02:28 -0600 Subject: [PATCH 2/3] -Changed Idle command by removing "list_command=False" to stay in convention with MPD -Edited change log to reflect the bugfix --- docs/changelog.rst | 7 +++++++ mopidy/mpd/protocol/status.py | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index e925db11..1e4b11aa 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -4,6 +4,13 @@ Changelog This changelog is used to track all major changes to Mopidy. +v2.1.1 (unreleased) +=================== + +Bug fix release. + +- MPD: Added Idle to the list of commands in Mopidy like the list in MPD (Fixes: :issue:`1593`, PR: :issue:`1597`) + v2.1.0 (2017-01-02) =================== diff --git a/mopidy/mpd/protocol/status.py b/mopidy/mpd/protocol/status.py index 7eace9c7..7a525647 100644 --- a/mopidy/mpd/protocol/status.py +++ b/mopidy/mpd/protocol/status.py @@ -42,7 +42,7 @@ def currentsong(context): tl_track, position=position, stream_title=stream_title) -@protocol.commands.add('idle', list_command=True) +@protocol.commands.add('idle') def idle(context, *subsystems): """ *musicpd.org, status section:* From 03b763172af9b5698a0dc1f06c19443e5580b101 Mon Sep 17 00:00:00 2001 From: Btjones711 Date: Thu, 26 Jan 2017 21:07:54 -0600 Subject: [PATCH 3/3] -Edited Test to reflect Idle bug fix --- tests/mpd/protocol/test_reflection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/mpd/protocol/test_reflection.py b/tests/mpd/protocol/test_reflection.py index 097c2e2a..43645c00 100644 --- a/tests/mpd/protocol/test_reflection.py +++ b/tests/mpd/protocol/test_reflection.py @@ -23,7 +23,7 @@ class ReflectionHandlerTest(protocol.BaseTestCase): self.assertNotInResponse('command: command_list_begin') self.assertNotInResponse('command: command_list_ok_begin') self.assertNotInResponse('command: command_list_end') - self.assertNotInResponse('command: idle') + self.assertInResponse('command: idle') self.assertNotInResponse('command: noidle') self.assertNotInResponse('command: sticker') self.assertInResponse('OK')