From f7f26403afc5215c204c710fbb459fc72e989a99 Mon Sep 17 00:00:00 2001 From: Thomas Adamcik Date: Mon, 16 May 2011 21:49:19 +0200 Subject: [PATCH] Move stop playback in error handler to after the error is logged to make cause and effect more obvious --- mopidy/gstreamer.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mopidy/gstreamer.py b/mopidy/gstreamer.py index 9b702b6b..7c12e579 100644 --- a/mopidy/gstreamer.py +++ b/mopidy/gstreamer.py @@ -96,11 +96,9 @@ class GStreamer(ThreadingActor): 'Telling backend ...') self._get_backend().playback.on_end_of_track() elif message.type == gst.MESSAGE_ERROR: - self.stop_playback() error, debug = message.parse_error() logger.error(u'%s %s', error, debug) - # FIXME Should we send 'stop_playback' to the backend here? Can we - # differentiate on how serious the error is? + self.stop_playback() elif message.type == gst.MESSAGE_WARNING: error, debug = message.parse_warning() logger.warning(u'%s %s', error, debug)