andpp/mopidy
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
7,741 Commits 1 Branch 0 Tags 24 MiB
release-2.2-my
Commit Graph

92 Commits

Author SHA1 Message Date
Nick Steel
5b32f87364 test: flake8 to ignore camelcase usage in our deps. 
Ignore N813 when importing the c version of xml.etree.ElementTree.

Ignore N815 when controlling failure diff length in unittest.
 2019-01-31 20:22:10 +00:00
Stein Magnus Jodal
1eb9e087c9 core: Remove redundant comments 2016-10-25 00:17:58 +02:00
Stein Magnus Jodal
b6c16750cf Merge pull request #1549 from alexjaw/fix/1512 
alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume
 2016-10-25 00:17:14 +02:00
Jens Lütjen
5057b8b31d Merge 'develop' and resolve conflict 
Conflicts:
	docs/changelog.rst
 2016-09-14 18:17:52 +02:00
Alexander Jaworowski
95deb77939 alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume 2016-08-21 21:59:10 +02:00
Alexander Jaworowski
bee9bd3d23 alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume 2016-08-21 21:40:17 +02:00
Jens Luetjen
c24380679f Test only events triggered after seek 2016-04-09 11:10:21 +02:00
Jens Luetjen
b55996da6a Changed wording export/restore to save/load 2016-04-02 16:28:04 +02:00
Jens Luetjen
ac47d254a3 Remove dead code for 'play-always' 2016-04-02 15:58:05 +02:00
Jens Luetjen
6e33bbcadd Replace restore/export with load/save 
Rename _restore_state to _load_state
Rename _export_state to _save_state
 2016-04-01 19:50:37 +02:00
Jens Luetjen
cf5dfccee2 Rename PlaybackState.position to time_position. 2016-04-01 19:13:26 +02:00
Jens Luetjen
2bb9e39ba6 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-03-31 19:04:45 +02:00
Jens Luetjen
bf4da7a627 Add tests to ensure that play, next will not busy-loop 
Test PlaybackController functions play(), next(), previous()
and _on_about_to_finish() that they will not loop forever
if all tracks are unplayable.
 2016-03-26 09:43:38 +01:00
Jens Luetjen
854357a295 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 
Conflicts:
	mopidy/core/playback.py
	tests/core/test_playback.py

revert _backend_error_handling
revert endless loop prevention
 2016-02-17 22:18:50 +01:00
Thomas Adamcik
79a4835e4e core: Add tests for change_track failing in about-to-finish 2016-02-14 17:23:20 +01:00
Thomas Adamcik
76ab5ffb04 core: Make sure exceptions from backend's change_track is handled 
Also adds TODOs for the rest of the backend calls in playback which all need to
assume backends can and will screw up.
 2016-02-14 17:16:31 +01:00
Stein Magnus Jodal
9b18ff07ee core: Readd regression test for #1352 
Fixes #1418

Based on test that was present in 1.1.2 but dropped in the #1400 merge.
 2016-02-14 16:12:45 +01:00
Stein Magnus Jodal
a42ce9f00e core: Test next/prev skips over unplayable tracks 
Fixes #1418

Based on tests that was present in 1.1.2 but dropped in the #1400 merge.
 2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
cc82e68a58 core: Remove unplayable track in consume mode 
Fixes #1418

This was previously fixed in 1.1.2, but the fix was skipped in when
release-1.1 was merged into develop in #1400, thus no changelog entry.
 2016-02-14 15:47:22 +01:00
Stein Magnus Jodal
0539e4e8fe Revert "core: Add TODO for testing unplayable-by-backend tracks" 
This reverts commit 3a8d896146.
 2016-02-14 15:47:18 +01:00
Stein Magnus Jodal
3a8d896146 core: Add TODO for testing unplayable-by-backend tracks 2016-02-14 12:49:15 +01:00
Jens Luetjen
bc981355bc Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 2016-02-08 18:45:58 +01:00
Stein Magnus Jodal
cd83084804 tests: Merge TestPlayUnknownHandling into TestUnplayableURI 2016-02-07 22:01:33 +01:00
Stein Magnus Jodal
1f4f0ab03b tests: Prefix some test classes with 'Test' 
We don't want to rely on them subclassing unittest.TestCase.
 2016-02-07 22:00:16 +01:00
Jens Luetjen
0a1e43c876 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 
Conflicts:
	mopidy/audio/scan.py
Fix conflicts.
 2016-02-03 22:01:51 +01:00
Stein Magnus Jodal
2232260d1b tests: Fix typo, don't use deprecated API 2016-01-31 07:50:43 +01:00
Jens Luetjen
e434556048 Merge branch 'develop' of https://github.com/mopidy/mopidy into fix/310-persist-mopidy-state-between-runs 
Conflicts:
	docs/changelog.rst
	mopidy/audio/scan.py

Resoved conflict.
 2016-01-21 19:33:58 +01:00
jcass
2fcbc691c0 fix:add changelog entry and fix line indentation. 2016-01-21 05:55:37 +02:00
jcass
dee7eb7e20 tests:fix pep8 violation. 2016-01-20 15:55:02 +02:00
jcass
239a7be708 fix: ensure that tl_track information is included in event trigger when consume mode is enabled. 2016-01-20 15:41:58 +02:00
Jens Luetjen
4869619bb9 New CoreState to hold all core states 
- Introduce a CoreState class that holds all core states
- Move xState classes to internal
- Use validation.check_instance for consistent error messages
- Store tlid instead of TlTrack to restore last played track
 2016-01-10 13:24:14 +01:00
Jens Luetjen
74344f2b19 Use tlid instead of full tl_track 
To export/restore the PlayState the tlid is enough.
 2016-01-09 12:52:01 +01:00
Jens Luetjen
0b0cbc87d4 Merge branch 'develop' into fix/310-persist-mopidy-state-between-runs 
Conflicts:
	docs/changelog.rst

Fixed conflict in doc/changelog.rst
 2016-01-05 08:16:51 +01:00
Jens Luetjen
d5a45516ef Adujst test code for testing auto-play 2016-01-05 07:53:45 +01:00
Jens Luetjen
e56c39ee78 Add unit tests for export/restore core state 
Fix issues shown by test code
 2016-01-03 18:29:35 +01:00
jcass
07a0f8ff3e test: Test case to ensure that unplayable tracks are skipped over in PAUSE state. 
Ensures that pause->next->resume handles unplayable tracks just like stop->next->play does.
 2015-12-29 07:54:49 +02:00
Thomas Adamcik
9f23757cc3 core: Return pending position during active seek. 
This covers over that audio will fail query position while a seek is in
progress. It also means that instead of returning zero we at least return
something which is much closer to the time that we will soon end up playing
from.
 2015-12-04 21:10:48 +01:00
Thomas Adamcik
454077afeb core: Make sure certain events are ignored when doing eot-seeks 2015-12-04 21:10:48 +01:00
Thomas Adamcik
aeb881896b core: Trigger position changed from audio events. 
Makes sure to only fire when the position changed to our intended seek target.
Otherwise we would also be triggering this when playback starts.
 2015-12-04 21:10:48 +01:00
Thomas Adamcik
e74eafb38a core: Switch back to correct track if seek happens before stream changed 
Technically the seek still needs to be postponed for this to work right, but
it's a step closer.
 2015-12-04 21:10:48 +01:00
Thomas Adamcik
3a57a5792b core: Make sure we always emit state_changed between tracks 
Gapless broke this, so this change makes sure that next/prev/play and gapless
track changes all correctly emit events.

Note that this only ensures we get PLAYING -> PLAYING events. Not the old
STOPPED -> PLAYING and then PLAYING -> STOPPED.
 2015-11-21 22:43:40 +01:00
Thomas Adamcik
216bd8e412 tests: Reorder listener_mock.send.mock_calls in assertEqual 2015-11-21 14:28:47 +01:00
Thomas Adamcik
da7ec9b202 core: Cleanup track ended event handling 
Trigger playback ended on:
- stream changed
- EOS
- stop via stream changed events

Old behavior was to manually trigger on:
- next
- prev
- play with other track and old state != STOPPED
- stop
 2015-11-19 22:45:55 +01:00
Thomas Adamcik
0169ce7cad core: Make sure the about-to-finish callback gets run in the actor. 
When about to finish gets called we are running in some GStreamer thread. Our
audio code then calls the shim core callback which is responsible for
transferring our execution to the core actor thread and waiting for the
response. From this point we do normal actor calls to the backend(s) which in
turn call into the audio actor. Since the initial audio code that was called is
outside the actor this should never deadlock due to this loop.
 2015-10-06 22:45:06 +02:00
Thomas Adamcik
1ca548ece7 core: Fix typos in comments 2015-10-05 21:41:15 +02:00
Thomas Adamcik
7f4e77f36f core: Update to using _change in play and fix playback ended event 2015-09-16 23:44:36 +02:00
Thomas Adamcik
592b728e32 core: Refactor previous() to use pending_track for state changes 2015-09-04 17:16:39 +02:00
Thomas Adamcik
2cd9903a54 core: Refactor next() to use pending_track for state changes 2015-09-04 16:08:54 +02:00
Thomas Adamcik
e12ea662da Merge branch 'develop' into feature/implement-gapless 2015-09-02 21:03:17 +02:00
Stein Magnus Jodal
a83d9836f9 core: Update test mock 2015-07-25 14:47:00 +02:00