Thomas Adamcik
19daa89e15
mpd: Add missing seeked event handling for idle
2015-12-04 22:11:55 +01:00
Thomas Adamcik
7d4da4ac8c
mpd: Add integration test for core events and idle
2015-12-04 22:10:27 +01:00
Thomas Adamcik
7ab2665292
mpd: Switch MpdSession to using on_event and re-use listener helper.
2015-12-04 21:20:24 +01:00
Thomas Adamcik
3a57a5792b
core: Make sure we always emit state_changed between tracks
...
Gapless broke this, so this change makes sure that next/prev/play and gapless
track changes all correctly emit events.
Note that this only ensures we get PLAYING -> PLAYING events. Not the old
STOPPED -> PLAYING and then PLAYING -> STOPPED.
2015-11-21 22:43:40 +01:00
Thomas Adamcik
e767cb3f41
tests: Convert local tracklist test to use core actor proxy.
2015-11-21 22:31:25 +01:00
Thomas Adamcik
216bd8e412
tests: Reorder listener_mock.send.mock_calls in assertEqual
2015-11-21 14:28:47 +01:00
Thomas Adamcik
da7ec9b202
core: Cleanup track ended event handling
...
Trigger playback ended on:
- stream changed
- EOS
- stop via stream changed events
Old behavior was to manually trigger on:
- next
- prev
- play with other track and old state != STOPPED
- stop
2015-11-19 22:45:55 +01:00
Stein Magnus Jodal
b29d5df9b8
compat: Avoid non-ASCII in byte literals
2015-10-29 22:57:06 +01:00
Stein Magnus Jodal
0c059b85b1
compat: Replace (int, long) with compat.integer_types
2015-10-29 22:21:48 +01:00
Stein Magnus Jodal
7e2d77ce0e
compat: Replace basestring with compat.string_types
2015-10-29 22:21:19 +01:00
Stein Magnus Jodal
8aeb9841c5
mpd: Final cleanup of PR #1187 , #1308 and #1322
...
Fixes #1014 , fixes #1322
2015-10-29 20:50:23 +01:00
Alex Malone
7aa8aa2967
mpd: fix flake8 errors
2015-10-29 15:03:41 +01:00
Jelle van der Waa
d6afcf0abf
mpd: playlist addition / creation
...
- Rename _playlist_create to _create_playlist
- Change short variables to abbreviations
- Use double quoting when a string contains a single quote
- Use playlist_deleted event
2015-10-29 15:03:41 +01:00
kozec
cb4c6909f9
mpd: Added default_playlist_scheme to configuration
2015-10-29 15:03:41 +01:00
kozec
3a13bc2358
mpd: Added tests for stored playlists modifying commands
2015-10-29 15:03:41 +01:00
Stein Magnus Jodal
93899c8599
Merge pull request #1288 from adamcik/feature/implement-gapless
...
Gapless part 1
2015-10-07 23:32:31 +02:00
Thomas Adamcik
0169ce7cad
core: Make sure the about-to-finish callback gets run in the actor.
...
When about to finish gets called we are running in some GStreamer thread. Our
audio code then calls the shim core callback which is responsible for
transferring our execution to the core actor thread and waiting for the
response. From this point we do normal actor calls to the backend(s) which in
turn call into the audio actor. Since the initial audio code that was called is
outside the actor this should never deadlock due to this loop.
2015-10-06 22:45:06 +02:00
Thomas Adamcik
1ca548ece7
core: Fix typos in comments
2015-10-05 21:41:15 +02:00
Thomas Adamcik
4c5e80a279
Merge pull request #1293 from jodal/feature/tlid-starts-at-1
...
core, mpd: Start tlid/songid counting at 1
2015-10-04 23:46:52 +02:00
Stein Magnus Jodal
0093eeffe2
Merge branch 'release-1.1' into develop
2015-10-04 23:44:48 +02:00
Stein Magnus Jodal
6f32bdc083
stream: Don't parse as playlist if playable
2015-10-04 23:08:07 +02:00
Stein Magnus Jodal
22264071e4
core, mpd: Start tlid/songid counting at 1
...
The original MPD server starts at 1. upmpdcli has issues with Mopidy
starting at 0 instead, as 0 is special in its context.
As noone should care exactly what core's TLIDs are, I opted to start
counting both core TLID and MPD songid from 1, instead of just
increasing TLID with 1 in the MPD frontend to get a valid songid. This
also keeps it easier to debug across the MPD/core boundary.
2015-09-24 22:35:59 +02:00
Thomas Adamcik
7f4e77f36f
core: Update to using _change in play and fix playback ended event
2015-09-16 23:44:36 +02:00
Thomas Adamcik
d6cfe0d1ae
tests: Update local playback tests to synchronize core state
2015-09-16 23:41:16 +02:00
Thomas Adamcik
f42a5423ab
tests: Add a TODO to the dummy audio helper
2015-09-16 23:41:03 +02:00
Thomas Adamcik
c1d21bd6c9
tests: Make sure mpd tests wait for core when changing state.
2015-09-16 23:38:15 +02:00
Stein Magnus Jodal
729249fffd
Merge branch 'release-1.1' into develop
2015-09-14 10:41:32 +02:00
Stein Magnus Jodal
9fb92139ec
tests: Remove version ordering test
...
I believe we're able to choose proper version numbers without the
busy-work of updating this test.
2015-09-14 10:40:48 +02:00
Stein Magnus Jodal
ffdf4bf691
Merge branch 'release-1.1' into develop
...
Conflicts:
docs/changelog.rst
2015-09-14 10:36:34 +02:00
Stein Magnus Jodal
6e126ee850
stream: Abort unwrap if visiting same URI twice
2015-09-14 10:12:31 +02:00
Stein Magnus Jodal
2d10eef0b1
stream: Expand nested stream playlists
...
Fixes #1250
2015-09-13 23:26:45 +02:00
Stein Magnus Jodal
9de96a81f8
http: Move tests from stream to http util
2015-09-13 11:56:16 +02:00
Thomas Adamcik
5c46b83f81
stream: Switch to using http download helper
2015-09-13 11:56:16 +02:00
Thomas Adamcik
592b728e32
core: Refactor previous() to use pending_track for state changes
2015-09-04 17:16:39 +02:00
Thomas Adamcik
2cd9903a54
core: Refactor next() to use pending_track for state changes
2015-09-04 16:08:54 +02:00
Thomas Adamcik
7201f2cb10
tests: Make dummy backend use real playback provider if audio is passed in
...
This is needed in order to make audio events propagate, to core and trigger
async state changes in tests.
2015-09-04 15:34:40 +02:00
Thomas Adamcik
d8986e6cc1
audio: Tell dummy_audio what urls to fail on
2015-09-04 15:28:32 +02:00
Thomas Adamcik
d8ce171b9a
Merge branch 'develop' into feature/implement-gapless
...
Conflicts:
tests/local/test_playback.py
2015-09-04 14:15:32 +02:00
Stein Magnus Jodal
f6f65dd3dc
Merge pull request #1276 from adamcik/feature/make-local-playback-test-use-core-proxy
...
local: Update playback test to use core as a running actor
2015-09-04 13:45:36 +02:00
Thomas Adamcik
0aeafa714b
local: Update playback test to use core as a running actor
2015-09-04 11:41:10 +02:00
Stein Magnus Jodal
f655fc7009
ext: Make get_{cache,config,data}_dir() class methods
...
Fixes #1275
2015-09-04 10:20:04 +02:00
Thomas Adamcik
1acc5aa557
audio: Update tests to reflect send_async being gone
2015-09-03 23:01:19 +02:00
Thomas Adamcik
71b04213ff
audio: Update dummy and tests to correctly emit stream changed
2015-09-03 21:39:30 +02:00
Thomas Adamcik
e12ea662da
Merge branch 'develop' into feature/implement-gapless
2015-09-02 21:03:17 +02:00
Stein Magnus Jodal
e0a028291a
local: Replace local/data_dir with core/data_dir
...
Partly fixes #1259
2015-08-23 00:37:38 +02:00
Stein Magnus Jodal
c48b6515f9
core: library.refresh() should check if backend has library
...
...and not playlists.
Fixes #1257
2015-08-23 00:35:54 +02:00
Stein Magnus Jodal
78ffaeb8d2
playlists: Fix crash on urilist comment with non-ASCII chars
...
Fixes #1265
2015-08-22 23:52:19 +02:00
Thomas Adamcik
3e75d5cf06
audio: Update missing plugins check in scanner tests
2015-08-19 00:40:46 +02:00
Thomas Adamcik
e77a4afaf4
audio: Make scanner report MIME for missing plugins
2015-08-18 23:56:42 +02:00
Stein Magnus Jodal
9f08bce6cd
core: Update test
2015-08-11 10:06:58 +02:00