jcass
239a7be708
fix: ensure that tl_track information is included in event trigger when consume mode is enabled.
2016-01-20 15:41:58 +02:00
Thomas Kemmer
b2d1e1b4f7
m3u: Major refactoring, add default_encoding and default_extension settings.
2016-01-04 14:19:49 +01:00
Stein Magnus Jodal
811131f716
Merge pull request #1371 from jcass77/enhance/format_proxy
...
Handle missing or empty 'port' configuration parameter.
2015-12-29 14:41:58 +01:00
Stein Magnus Jodal
4fba994441
Merge pull request #1377 from jcass77/test/pr_1356_resume_unplayable_track
...
test: Test case for skipping unplayable tracks when paused.
2015-12-29 08:53:12 +01:00
jcass
07a0f8ff3e
test: Test case to ensure that unplayable tracks are skipped over in PAUSE state.
...
Ensures that pause->next->resume handles unplayable tracks just like stop->next->play does.
2015-12-29 07:54:49 +02:00
Stein Magnus Jodal
5462f0e319
Merge pull request #1369 from tkem/m3u-fix-1364
...
m3u: Derive track name from file name for non-extended M3U playlists.
2015-12-29 02:02:48 +01:00
jcass
3488e6442d
Handle missing or empty 'port' configuration parameter.
2015-12-26 15:28:07 +02:00
Thomas Kemmer
22690ee5a9
m3u: Derive track name from file name for non-extended M3U playlists.
2015-12-23 18:14:19 +01:00
Thomas Kemmer
ef1468d8d6
core: Add PlaylistsController.get_uri_schemes().
2015-12-13 19:02:33 +01:00
Stein Magnus Jodal
3e259f1c00
Merge pull request #1347 from adamcik/feature/mpd-idle-cleanup
...
MPD idle cleanup
2015-12-05 21:36:11 +01:00
Stein Magnus Jodal
23cdeb208b
Merge pull request #1346 from adamcik/feature/eot-seek-handling
...
Gapless aware seek handling
2015-12-05 21:34:51 +01:00
Stein Magnus Jodal
23d83a833f
Merge pull request #1349 from adamcik/feature/mpd-playlists-error-handling
...
MPD playlist editing error handling
2015-12-05 21:14:55 +01:00
Thomas Adamcik
00b52da6ab
mpd: Make sure rename error handling is correct
2015-12-05 14:30:18 +01:00
Thomas Adamcik
9ac1760dd1
mpd: Update playlistmove to check names and indexes
2015-12-05 14:11:27 +01:00
Thomas Adamcik
5de9495eaa
mpd: Update playlistdelete to handle unknown names and indexes
2015-12-05 14:01:43 +01:00
Thomas Adamcik
b21debf6ee
mpd: Sanity check stored playlist names
2015-12-05 13:51:36 +01:00
Thomas Adamcik
c3393d3d85
mpd: Refresh mapping when name is not present ( Fixes #1348 )
2015-12-05 12:49:45 +01:00
Thomas Adamcik
98e19e803b
mpd: Deleting unkown playlist should return not found
2015-12-05 12:48:14 +01:00
Thomas Adamcik
07328e7dd2
mpd: Map playlists_loaded to idle event stored_playlist
2015-12-05 11:08:33 +01:00
Stein Magnus Jodal
28224cef8c
audio: Fix tests not exiting normally
2015-12-05 00:34:33 +01:00
Thomas Adamcik
19daa89e15
mpd: Add missing seeked event handling for idle
2015-12-04 22:11:55 +01:00
Thomas Adamcik
7d4da4ac8c
mpd: Add integration test for core events and idle
2015-12-04 22:10:27 +01:00
Thomas Adamcik
7ab2665292
mpd: Switch MpdSession to using on_event and re-use listener helper.
2015-12-04 21:20:24 +01:00
Thomas Adamcik
9f23757cc3
core: Return pending position during active seek.
...
This covers over that audio will fail query position while a seek is in
progress. It also means that instead of returning zero we at least return
something which is much closer to the time that we will soon end up playing
from.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
454077afeb
core: Make sure certain events are ignored when doing eot-seeks
2015-12-04 21:10:48 +01:00
Thomas Adamcik
aeb881896b
core: Trigger position changed from audio events.
...
Makes sure to only fire when the position changed to our intended seek target.
Otherwise we would also be triggering this when playback starts.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
e74eafb38a
core: Switch back to correct track if seek happens before stream changed
...
Technically the seek still needs to be postponed for this to work right, but
it's a step closer.
2015-12-04 21:10:48 +01:00
Thomas Adamcik
3a57a5792b
core: Make sure we always emit state_changed between tracks
...
Gapless broke this, so this change makes sure that next/prev/play and gapless
track changes all correctly emit events.
Note that this only ensures we get PLAYING -> PLAYING events. Not the old
STOPPED -> PLAYING and then PLAYING -> STOPPED.
2015-11-21 22:43:40 +01:00
Thomas Adamcik
e767cb3f41
tests: Convert local tracklist test to use core actor proxy.
2015-11-21 22:31:25 +01:00
Thomas Adamcik
216bd8e412
tests: Reorder listener_mock.send.mock_calls in assertEqual
2015-11-21 14:28:47 +01:00
Thomas Adamcik
da7ec9b202
core: Cleanup track ended event handling
...
Trigger playback ended on:
- stream changed
- EOS
- stop via stream changed events
Old behavior was to manually trigger on:
- next
- prev
- play with other track and old state != STOPPED
- stop
2015-11-19 22:45:55 +01:00
Stein Magnus Jodal
b29d5df9b8
compat: Avoid non-ASCII in byte literals
2015-10-29 22:57:06 +01:00
Stein Magnus Jodal
0c059b85b1
compat: Replace (int, long) with compat.integer_types
2015-10-29 22:21:48 +01:00
Stein Magnus Jodal
7e2d77ce0e
compat: Replace basestring with compat.string_types
2015-10-29 22:21:19 +01:00
Stein Magnus Jodal
8aeb9841c5
mpd: Final cleanup of PR #1187 , #1308 and #1322
...
Fixes #1014 , fixes #1322
2015-10-29 20:50:23 +01:00
Alex Malone
7aa8aa2967
mpd: fix flake8 errors
2015-10-29 15:03:41 +01:00
Jelle van der Waa
d6afcf0abf
mpd: playlist addition / creation
...
- Rename _playlist_create to _create_playlist
- Change short variables to abbreviations
- Use double quoting when a string contains a single quote
- Use playlist_deleted event
2015-10-29 15:03:41 +01:00
kozec
cb4c6909f9
mpd: Added default_playlist_scheme to configuration
2015-10-29 15:03:41 +01:00
kozec
3a13bc2358
mpd: Added tests for stored playlists modifying commands
2015-10-29 15:03:41 +01:00
Stein Magnus Jodal
93899c8599
Merge pull request #1288 from adamcik/feature/implement-gapless
...
Gapless part 1
2015-10-07 23:32:31 +02:00
Thomas Adamcik
0169ce7cad
core: Make sure the about-to-finish callback gets run in the actor.
...
When about to finish gets called we are running in some GStreamer thread. Our
audio code then calls the shim core callback which is responsible for
transferring our execution to the core actor thread and waiting for the
response. From this point we do normal actor calls to the backend(s) which in
turn call into the audio actor. Since the initial audio code that was called is
outside the actor this should never deadlock due to this loop.
2015-10-06 22:45:06 +02:00
Thomas Adamcik
1ca548ece7
core: Fix typos in comments
2015-10-05 21:41:15 +02:00
Thomas Adamcik
4c5e80a279
Merge pull request #1293 from jodal/feature/tlid-starts-at-1
...
core, mpd: Start tlid/songid counting at 1
2015-10-04 23:46:52 +02:00
Stein Magnus Jodal
0093eeffe2
Merge branch 'release-1.1' into develop
2015-10-04 23:44:48 +02:00
Stein Magnus Jodal
6f32bdc083
stream: Don't parse as playlist if playable
2015-10-04 23:08:07 +02:00
Stein Magnus Jodal
22264071e4
core, mpd: Start tlid/songid counting at 1
...
The original MPD server starts at 1. upmpdcli has issues with Mopidy
starting at 0 instead, as 0 is special in its context.
As noone should care exactly what core's TLIDs are, I opted to start
counting both core TLID and MPD songid from 1, instead of just
increasing TLID with 1 in the MPD frontend to get a valid songid. This
also keeps it easier to debug across the MPD/core boundary.
2015-09-24 22:35:59 +02:00
Thomas Adamcik
7f4e77f36f
core: Update to using _change in play and fix playback ended event
2015-09-16 23:44:36 +02:00
Thomas Adamcik
d6cfe0d1ae
tests: Update local playback tests to synchronize core state
2015-09-16 23:41:16 +02:00
Thomas Adamcik
f42a5423ab
tests: Add a TODO to the dummy audio helper
2015-09-16 23:41:03 +02:00
Thomas Adamcik
c1d21bd6c9
tests: Make sure mpd tests wait for core when changing state.
2015-09-16 23:38:15 +02:00