Commit Graph

7683 Commits

Author SHA1 Message Date
Thomas Adamcik
44ff669744 Merge pull request #1534 from edran/fix-scrobbling
Get correct track position on change events
2016-07-25 22:08:41 +02:00
Thomas Adamcik
5b6632e886 Merge pull request #1534 from edran/fix-scrobbling
Get correct track position on change events
2016-07-25 22:05:34 +02:00
Thomas Adamcik
692138a51e Merge pull request #1525 from palfrey/dodgy-date-tags
If the date in a tag is invalid, skip it
2016-07-25 22:01:12 +02:00
Thomas Adamcik
57b8b8435d Merge pull request #1525 from palfrey/dodgy-date-tags
If the date in a tag is invalid, skip it
2016-07-25 22:00:51 +02:00
Thomas Adamcik
0c6be281df doc: Add changelog entry for PR#1496 and PR#1522 2016-07-25 21:53:21 +02:00
Thomas Adamcik
5e2b44ab44 Merge pull request #1522 from SeppSTA/fix/1521-download-timeout-sec
fix/1521 download timeout sec
2016-07-25 21:52:38 +02:00
Thomas Adamcik
3ee91240a0 Merge pull request #1496 from dublok/fix/1462-flac-seek-freeze
audio: Ignore position of _on_position_changed callback (fixes #1462)
2016-07-25 21:43:31 +02:00
Thomas Adamcik
c199fb1c81 lint: Workaround and fix to account for new version of flake8 2016-07-25 21:16:30 +02:00
Thomas Adamcik
fb823d1a7c lint: Workaround and fix to account for new version of flake8 2016-07-25 21:09:38 +02:00
Nantas Nardelli
6e603a183b Add TODO about checking length of track when null 2016-07-24 22:26:59 +01:00
Nantas Nardelli
500ff70b87 Add changelog entry for #1534, and fix #1523 typo 2016-07-24 21:52:15 +01:00
Nantas Nardelli
d1449bcb6f Properly get track position before change events
In particular, this allows to send the right information when:

1. the track finishes and switches to the next one in the list;
2. user presses next / previous

The cases of EOS and stop event were already handled properly.

Note: we only have GStreamer's `about-to-finish` event to deal with the
end of a track, which usually happens a few seconds before the end of
the track. We set the position to the length of the track, which is not
overridden unless the user generates a relevant callback.
2016-07-24 20:30:48 +01:00
Thomas Adamcik
068800c699 Merge pull request #1523 from ismailof/fix/1133-mpd-nextsongid
mpd: Add nextsong and nextsongid to mpd status command (Fixes #1133)
2016-06-26 11:52:24 +02:00
ismailof
65498485fe Add changelog entry 2016-06-26 11:19:08 +02:00
ismailof
95ac2714ff Add changelog entry 2016-06-26 11:18:34 +02:00
Tom Parker
ffe32ab7c7 Use logger.debug, not logging.log(logging.DEBUG 2016-06-13 22:03:51 +01:00
Thomas Adamcik
431984d103 Merge pull request #1496 from dublok/fix/1462-flac-seek-freeze
audio: Ignore position of _on_position_changed callback (fixes #1462)
2016-06-13 22:44:03 +02:00
Thomas Adamcik
099c17ac07 Merge pull request #1518 from sumpfralle/doc-track-model-update
docs: update 'composers' and 'performers' type
2016-06-13 22:40:17 +02:00
Thomas Adamcik
d02f8416de Merge pull request #1522 from SeppSTA/fix/1521-download-timeout-sec
fix/1521 download timeout sec
2016-06-13 22:12:56 +02:00
Tom Parker
c3eb9b60c0 If tags date isn't a valid value for Python, skip the tag 2016-06-10 12:41:02 +01:00
ismailof
fc26b7304c chmod correction 2016-06-06 23:22:40 +02:00
ismailof
6787a044fc Add MPD nextsong/nextsongid test case 2016-06-06 23:20:49 +02:00
ismailof
19818d3f68 Add MPD nextsong/nextsongid test case 2016-06-06 23:20:13 +02:00
ismailof
a1c219e25d Add nextsong/nextsongid to mpd status 2016-06-06 22:59:59 +02:00
ismailof
ac92069dd5 Add nextsong/nextsongid to mpd status 2016-06-06 21:45:18 +02:00
SeppSTA
18f4c1fa38 insert missing whitespace 2016-06-01 14:05:58 +02:00
SeppSTA
f06e5adfa9 http: fix timeout value to seconds 2016-06-01 13:36:52 +02:00
Nick Steel
2fe9fbb9af Merge pull request #1520 from bchretien/topic/fix-mpd-protocol
mpd: fix protocol for replay_gain_status
2016-05-31 17:10:54 +01:00
Benjamin Chrétien
37cd296552 mpd: fix protocol for replay_gain_status 2016-05-31 16:36:37 +02:00
Lars Kruse
d87de65f9a model documentation: update 'composers' and 'performers' type 2016-05-28 04:57:32 +02:00
Jens Luetjen
c24380679f Test only events triggered after seek 2016-04-09 11:10:21 +02:00
Jens Luetjen
7757d306ea Include _pending_position 0 (zero) as valid target 2016-04-04 21:45:02 +02:00
Jens Luetjen
c2c64620b1 Ignore position of _on_position_changed callback 2016-04-04 20:40:56 +02:00
Jens Luetjen
100d7dba7b Reworked if conditions in _load_state 2016-04-02 17:12:31 +02:00
Jens Luetjen
4693fa7f8e Correct wrong docstring 2016-04-02 16:55:18 +02:00
Jens Luetjen
b55996da6a Changed wording export/restore to save/load 2016-04-02 16:28:04 +02:00
Jens Luetjen
00c47117d5 Test models.MixerState.mute 2016-04-02 16:11:47 +02:00
Jens Luetjen
d93cc1b44d Remove unnecessary array initialzation 2016-04-02 16:04:45 +02:00
Jens Luetjen
a6e33e537f Correct wrong docstring 2016-04-02 16:01:09 +02:00
Jens Luetjen
ac47d254a3 Remove dead code for 'play-always' 2016-04-02 15:58:05 +02:00
Jens Luetjen
6ee36752bd Test whole save/load state. 2016-04-01 22:16:05 +02:00
Jens Luetjen
6e33bbcadd Replace restore/export with load/save
Rename _restore_state to _load_state
Rename _export_state to _save_state
2016-04-01 19:50:37 +02:00
Jens Luetjen
e9db19a352 Handle all path- and file-names as bytestings 2016-04-01 19:39:48 +02:00
Jens Luetjen
cf5dfccee2 Rename PlaybackState.position to time_position. 2016-04-01 19:13:26 +02:00
Stein Magnus Jodal
df0d534a56 docs: Depend on sphinx_rtd_theme
As of Sphinx 1.4, it is no longer a transitive dependency, so we need
to depend on it explicitly.
2016-04-01 08:12:29 +02:00
Jens Luetjen
eb930a1679 Catch exception when deleting persistent file. 2016-03-31 23:34:57 +02:00
Jens Luetjen
e9e9646d61 Removed unnecessary docstrings. 2016-03-31 23:24:25 +02:00
Jens Luetjen
44b7974f79 Restore mixer.volume/mute before starting playback 2016-03-31 23:20:26 +02:00
Jens Luetjen
01201d142c Renamed member in HistoryController
- add 'play-always' and 'play-last' to docstring for _load_state.
- renamed _start_at_pos to _start_at_position
- changed 'if const == value:' to 'if value == const:'
- changed info text to 'Limiting history'
2016-03-31 23:17:29 +02:00
Jens Luetjen
67044cecab Remove 'TODO: check if playable'
We don't need to as each backend a title is still playable.
The backend must be able to handle unplayable title.

Replace for loop with arrar.extend()
2016-03-31 22:07:53 +02:00