Commit Graph

4679 Commits

Author SHA1 Message Date
Nick Steel
e87599a2d3 Explicitly check for None (core playlists API future proofing). 2018-04-15 21:21:59 +01:00
Nick Steel
627684ec7b Updated playlistclear to use playlist lookup helper and added save failure tests. 2018-04-15 21:19:01 +01:00
nsteel
52a90a5a06 MPD's load and listplaylistinfo lookup track metadata. Fixes #1511.
Includes tests and refactored all playlist lookups to use helper.
2018-04-15 21:19:01 +01:00
Nick Steel
51741a7cbc HTTP: Apply allowed_origins to Websocket requests also. 2018-04-15 17:14:13 +01:00
Nick Steel
7caba4a05d docs: improved http/allowed_origins description. 2018-04-15 17:12:16 +01:00
Nick Steel
94ba9b6642 HTTP: Content-Type other than application/json is a 415 client error.
Also Fixed up formatting following code review.
2018-04-15 17:12:16 +01:00
Nick Steel
cd829c7042 HTTP: CSRF protection for RPC endpoint.
By now enforcing the Content-Type header is set to 'application/json', we force browsers attempting a cross-domain
request to first perform a CORS preflight OPTIONS request. This request always includes an Origin header which we
check against our whitelist. The whitelist contains the current Host as well as anything specified in the new optional
allowed_origins config value. Any non-browser tools must also now set the Context-type header.
2018-04-15 17:12:16 +01:00
matt LLVW
2e6c0049a4 config: remove 10000 tracks limitation in playlists 2018-04-04 19:20:17 +02:00
Stein Magnus Jodal
e215484c75 encoding: Never crash if unknown bytes in OS errors
Fixes #1599
2018-03-30 11:25:31 +02:00
Stein Magnus Jodal
cd2bbaba07 docs: Add PR#1611 to changelog 2018-03-30 10:44:08 +02:00
Stein Magnus Jodal
87ff8d9269
Merge pull request #1611 from BernhardGehl/patch-1
remove leftover utf-8 encode from path handling
2018-03-30 10:41:05 +02:00
Stein Magnus Jodal
95577206a0 Require tornado >= 4.4 2018-03-29 20:51:01 +02:00
Stein Magnus Jodal
2e32b5c8bf audio: Explicitly convert long to int 2018-03-29 17:06:08 +02:00
Stein Magnus Jodal
f46c290ec1 Merge branch 'release-2.1' into develop 2018-03-29 16:30:17 +02:00
Stein Magnus Jodal
7d02870f79 Merge branch 'master' into release-2.1 2018-03-29 16:25:41 +02:00
Stein Magnus Jodal
99d8a2124e Fix new flake8 warnings 2018-03-29 10:21:50 +02:00
Jarryd Tilbrook
b4c98ec4a5 Fix/1531 add unix domain socket (#1629)
mpd: add functionality for unix domain socket (Fixes #1531)

The Hostname config type now supports a Unix socket path prefixed with `unix:`
2018-02-13 12:58:39 +00:00
jradtilbrook
f00fd8e1df
flake8: fix import order violations 2017-11-04 20:34:05 +08:00
jradtilbrook
257c42e111
flake8: fix bare except clause 2017-11-04 19:58:04 +08:00
Nick Steel
9554a3bd20 Merge pull request #1620 from kingosticks/fix/library_lookup_empty_uris
Fix library.lookup with an empty uri list
2017-06-15 21:19:38 +01:00
Nick Steel
d6eff50597 core: Fix library.lookup with an empty uri list. Fixes #1619. 2017-06-15 00:10:06 +01:00
Thomas Adamcik
d0ef2c425a Merge pull request #1595 from Caysho/develop
File: Add feature to file module for sorting files vs directories.
2017-06-14 23:12:58 +02:00
Piotr Dobrowolski
2124c66d11 Set GLib prgname and application name
This makes Mopidy properly show up in pulseaudio as "Mopidy" instead of
"python*"
2017-06-13 17:20:16 +02:00
BernhardGehl
daa4e0b54f remove leftover utf-8 encode from path handling
Reaving the .encode in the code causes folders with non-ASCII symbols (tested with some German umlauts) to show up empty in "browse".
After removing, the folder contents show up fine.
2017-04-04 21:43:05 +02:00
Btjones711
fb9f2198bd -Changed Idle command by removing "list_command=False" to stay in convention with MPD
-Edited change log to reflect the bugfix

(cherry picked from commit 4fd86c37a7)
2017-02-11 13:41:33 +01:00
Btjones711
44d744fc5a -Changed Idle's list command to True to stay in convention with MPD
(cherry picked from commit 522ae022f3)
2017-02-11 13:37:16 +01:00
Caysho
3f77f03057 mopidy/file/library.py
Improve sort efficiency with tkem's suggestion in PR 1595.

Remove
import operator
because operator.attrgetter() not used now.

mopidy/file/ext.conf
Remove errant new line character introduced in
commit 0e1e703cbe.

Signed-off-by: Caysho <caysho@internode.on.net>
2017-02-03 18:58:08 +08:00
Caysho
0e1e703cbe Discussion in mopidy PR 1595: remove sort order configuration item.
Browse/File sort order to be directories first, otherwise all items
alphabetically.
Final sort order to be left to clients.

Change mopidy/file/library.py to sort as described.

Remove changes to:
1. docs/ext/file.rst
2. mopidy/file/__init__.py
3. mopidy/file/ext.conf

Thanks go to sumpfralle for providing the base code for the sort lambda
and stable sort suggestion.

Signed-off-by: Caysho <caysho@internode.on.net>
2017-02-01 20:35:41 +08:00
Btjones711
4fd86c37a7 -Changed Idle command by removing "list_command=False" to stay in convention with MPD
-Edited change log to reflect the bugfix
2017-01-26 21:02:28 -06:00
Btjones711
522ae022f3 -Changed Idle's list command to True to stay in convention with MPD 2017-01-26 16:28:58 -06:00
mopidy-dev
84992bf80e File: Add feature to file module for sorting files vs directories.
Add configuration option in [file] section of mopidy.conf
Add documentation for feature with the valid options.

Signed-off-by: caysho@internode.on.net
2017-01-23 21:24:39 +08:00
Stein Magnus Jodal
b9f2cf0b5e Bump version number to 2.1.0 2017-01-02 23:54:43 +01:00
Stein Magnus Jodal
fe762bb20e flake8: Fix new warning 2016-11-15 13:46:56 +01:00
Thomas Adamcik
3f46311291 audio: Do not try duration workaround for non-seekable sources 2016-10-26 23:40:33 +02:00
Thomas Adamcik
58d1e0fbee audio: Make missing duration workaround more robust. 2016-10-26 23:40:33 +02:00
Thomas Adamcik
26e50882e6 audio: Place upper limit on length of log lines for scanner 2016-10-26 23:40:33 +02:00
Thomas Adamcik
7ecc6e5af7 audio: Revert MMS related changes.
This reverts commit 74cf673171.
"audio: Wait for state change instead of async done in scanner."

This reverts commit 4adea37e97.
"audio: Give up getting duration for MMS (Fixes: #1553)"
2016-10-26 23:40:25 +02:00
Stein Magnus Jodal
bbeb5c03aa Require Tornado >= 3.2
Survey of version available in the oldest distros we care about:

- Debian 8, squeeze: 3.2.2
- Debian 8, squeeze-backports: 4.2.0
- Ubuntu 16.04 LTS: 4.2.1
- Arch Linux: 4.4.2
2016-10-26 00:39:42 +02:00
Thomas Adamcik
74cf673171 audio: Wait for state change instead of async done in scanner.
This increases the robustness by quite a bit, we no longer:
- Fail on elements such as mmssrc that can't go to playing ASYNC.
- Try going to playing if we've already tried before.
2016-10-25 22:48:03 +02:00
Thomas Adamcik
4adea37e97 audio: Give up getting duration for MMS (Fixes: #1553) 2016-10-25 22:00:42 +02:00
Thomas Adamcik
914afb37f8 audio: Improve and enable trace logging for scanner 2016-10-25 22:00:42 +02:00
Stein Magnus Jodal
1eb9e087c9 core: Remove redundant comments 2016-10-25 00:17:58 +02:00
Stein Magnus Jodal
b6c16750cf Merge pull request #1549 from alexjaw/fix/1512
alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume
2016-10-25 00:17:14 +02:00
Stein Magnus Jodal
1841ca2177 file: Fix minor style issues 2016-10-24 23:41:42 +02:00
Stein Magnus Jodal
3d60acd8b2 Merge pull request #1568 into feature/file-excluded-file-exts 2016-10-24 23:28:38 +02:00
Thomas Adamcik
e161e9b26c Merge branch 'develop' into fix/1479-cant-play-rtsp 2016-10-24 23:20:52 +02:00
Thomas Adamcik
3d477e1eb9 Merge branch 'develop' into fix/1479-cant-play-rtsp 2016-10-24 23:07:34 +02:00
Aleksandar Benic
cd6bfeb681 Fix formatting 2016-10-23 13:33:07 +02:00
Aleksandar Benic
4ddb225955 Lapsus calami 2016-10-23 12:55:05 +02:00
Aleksandar Benic
0c6a5d5823 Change error wording 2016-10-14 05:12:28 +02:00