Commit Graph

794 Commits

Author SHA1 Message Date
Stein Magnus Jodal
6c68b17b45 Fix 'commands' and 'notcommands' for unauthenticated users
Use newly gained access to the current user's authentication state and
the command handler's auth_required flag to give correct 'commands' and
'notcommands' output to unauthenticated users when password
authentication is activated.
2011-06-04 19:44:16 +02:00
Stein Magnus Jodal
601a0f0a45 You are always authenticated when MPD_SERVER_PASSWORD==None 2011-06-04 19:02:20 +02:00
Stein Magnus Jodal
e68d715d3e Rename handle_pattern decorator to handle_request 2011-06-04 18:51:18 +02:00
Stein Magnus Jodal
08f085fd8d Refactor MpdDispatcher to use a filter model, like Java Servlets. Password authentication handling becomes much cleaner. 2011-06-04 02:21:14 +02:00
Thomas Adamcik
89104bd326 Add skipped test case for date missing in scanner tests 2011-06-04 01:52:11 +02:00
Thomas Adamcik
f091433a53 Cleanup error feedback 2011-06-04 01:51:44 +02:00
Stein Magnus Jodal
a68bdae751 Move MPD authentication check from MpdSession to MpdDispatcher 2011-06-04 00:42:51 +02:00
Stein Magnus Jodal
1db84dccca Refactor MpdDispatcher.handle_request 2011-06-04 00:33:57 +02:00
Stein Magnus Jodal
bf175a3dce Rename one letter variable in tests 2011-06-03 23:58:24 +02:00
Stein Magnus Jodal
c9506ca7e1 List 'kill' MPD command in 'notcommands' instead of 'commands' 2011-06-03 23:32:19 +02:00
Stein Magnus Jodal
7f7d79b21f Return permission error on use of MPD command 'kill' 2011-06-03 23:31:52 +02:00
Stein Magnus Jodal
c84639b197 Add MpdPermissionError exception 2011-06-03 23:25:00 +02:00
Stein Magnus Jodal
9545da4b4e Refactor MPD dispatcher 2011-06-03 22:37:05 +02:00
Stein Magnus Jodal
52ee117153 Merge branch 'feature/clean-shutdown' into feature/mpd-improvements 2011-06-03 22:35:48 +02:00
Stein Magnus Jodal
30d6d6f29e Close client connection on MPD command 'close' 2011-06-03 17:18:38 +02:00
Stein Magnus Jodal
cbdc37a24d Replace all single letter instance variables in MPD protocol tests 2011-06-03 16:52:52 +02:00
Stein Magnus Jodal
d57727282e Create new MpdContext object which is passed to command handlers 2011-06-03 16:34:47 +02:00
Stein Magnus Jodal
86e90f14c6 Add MpdSystemError exception 2011-05-25 21:58:34 +02:00
Stein Magnus Jodal
0b2b0c5c3c Show current setting value on same line as setting name 2011-05-19 22:37:09 +02:00
Stein Magnus Jodal
a760a7fdb4 Use pprint to format long setting values 2011-05-19 22:31:04 +02:00
Stein Magnus Jodal
7074b4928c Add some tests for --list-settings formatting 2011-05-19 22:30:09 +02:00
Stein Magnus Jodal
b796661dc1 List --help-gst in Mopidy's --help listing 2011-05-09 23:16:45 +02:00
Stein Magnus Jodal
f035ea31ef Allow GStreamer to process --help-gst 2011-05-09 23:13:06 +02:00
Stein Magnus Jodal
ebee962020 Test that --help returns the options we expect it to 2011-05-08 01:38:04 +02:00
Stein Magnus Jodal
254d955385 Merge branch 'hotfix/0.4.1' into develop
Conflicts:
	docs/changes.rst
	mopidy/__init__.py
	tests/version_test.py
2011-05-06 00:25:06 +02:00
Thomas Adamcik
e1cc1dfe48 Rename prepare_playback to prepare_change 2011-05-05 20:17:28 +02:00
Thomas Adamcik
76a33f37db Add some more tests 2011-05-04 23:42:14 +02:00
Thomas Adamcik
9998a0e80f Update gstreamer test 2011-05-04 23:35:50 +02:00
Thomas Adamcik
42547563ea Convert set_state to internal method 2011-05-03 23:08:31 +02:00
Thomas Adamcik
865d62e6e1 Merge branch 'develop' into feature/modularised-output
Conflicts:
	mopidy/gstreamer.py
2011-05-01 23:51:33 +02:00
Stein Magnus Jodal
9f130f4dfc Bump version number to 0.4.1 2011-04-29 21:44:57 +02:00
Stein Magnus Jodal
50aef50989 Ready for 0.5.0 development 2011-04-27 00:20:08 +02:00
Thomas Adamcik
472e4d2790 Rename output to gstreamer in backends 2011-04-25 21:30:01 +02:00
Thomas Adamcik
e1ef4171b5 Merge branch 'develop' of http://github.com/mopidy/mopidy into develop 2011-04-25 20:37:50 +02:00
Thomas Adamcik
a4c526774b Kill off stale shoutcast tests 2011-04-25 17:44:21 +02:00
Stein Magnus Jodal
043338d3af Revert "Merge branch 'feature/multi-backend' into develop"
This reverts commit c8639f48da, reversing
changes made to 3e0a04ab91.
2011-04-25 15:14:00 +02:00
Stein Magnus Jodal
5f7988d974 Merge branch 'develop' into feature/multi-backend
Conflicts:
	mopidy/backends/local/__init__.py
	mopidy/outputs/gstreamer.py
	tests/frontends/mpd/audio_output_test.py
	tests/frontends/mpd/command_list_test.py
	tests/frontends/mpd/connection_test.py
	tests/frontends/mpd/current_playlist_test.py
	tests/frontends/mpd/dispatcher_test.py
	tests/frontends/mpd/music_db_test.py
	tests/frontends/mpd/playback_test.py
	tests/frontends/mpd/reflection_test.py
	tests/frontends/mpd/regression_test.py
	tests/frontends/mpd/status_test.py
	tests/frontends/mpd/stickers_test.py
	tests/frontends/mpd/stored_playlists_test.py
2011-04-25 15:05:33 +02:00
Thomas Adamcik
4a1df118fb Move GStreamerOutput up one level to mopidy.gstreamer and rename to GStreamer 2011-04-25 01:31:28 +02:00
Thomas Adamcik
7016a20811 Kill of BaseOutput 2011-04-25 01:31:28 +02:00
Thomas Adamcik
3a44f130aa Refactor shoutcast tests 2011-04-25 01:30:48 +02:00
Thomas Adamcik
b58436aaf3 Use audioconvert to ensure that volume element is handeled 2011-04-25 01:30:47 +02:00
Thomas Adamcik
a81113e1a7 Add _build_shoutcast_description to construct shoutcast bin 2011-04-25 01:30:47 +02:00
Thomas Adamcik
0b91b26910 Check if creation of IPv6 sockets works before using it (fixes #75) 2011-04-23 18:15:28 +02:00
Thomas Adamcik
f20b3b26f6 Add platform and python information to startup logging (fixes #73) 2011-04-23 15:08:03 +02:00
Stein Magnus Jodal
2a3b6f2133 Replace symlinks with real files (fixes #68) 2011-04-11 22:47:49 +02:00
Stein Magnus Jodal
79771d6e2c Rename data_folder() to path_to_data_dir() 2011-04-07 15:55:03 +02:00
Stein Magnus Jodal
342c13f811 Fix 'song: None' in 'status' response 2011-04-06 22:40:50 +02:00
Stein Magnus Jodal
ba738b5c1e Add missing tests for eq/ne of Playlist 2011-04-06 18:36:14 +02:00
Stein Magnus Jodal
005260eb9c Add __repr__ to ImmutableObject to get better output from failed model comparisions in tests 2011-04-06 18:18:00 +02:00
Stein Magnus Jodal
037da6f460 Remove Playlist._tracks workaround 2011-04-06 18:01:33 +02:00
Stein Magnus Jodal
fce5964395 Remove Track._artists workaround 2011-04-06 17:54:12 +02:00
Stein Magnus Jodal
9499250a7f Remove Album._artists workaround 2011-04-06 17:51:36 +02:00
Stein Magnus Jodal
dec1643e7f Merge remote-tracking branch 'grunskis/develop' into develop 2011-04-05 21:37:21 +02:00
Stein Magnus Jodal
4703783eed Upgrade to work with final release of Pykka 0.12 2011-03-30 23:28:54 +02:00
Stein Magnus Jodal
4452957c10 Require Pykka 0.12 (not released yet) 2011-03-30 00:39:19 +02:00
Stein Magnus Jodal
b83dad7845 Update tests to match change in previous commit 2011-03-21 00:34:54 +01:00
Stein Magnus Jodal
20e55873e9 Update MPD/command list 2011-03-20 01:10:32 +01:00
Stein Magnus Jodal
f0ebc24234 Update MPD/stored playlists 2011-03-20 01:04:18 +01:00
Stein Magnus Jodal
289cefc53a Update MPD/stickers 2011-03-20 00:58:13 +01:00
Stein Magnus Jodal
0de8d1b4b8 Update MPD/status 2011-03-20 00:56:43 +01:00
Stein Magnus Jodal
f73268c332 Update MPD/server 2011-03-20 00:38:09 +01:00
Stein Magnus Jodal
21153dd52b Update MPD/regression tests 2011-03-20 00:29:43 +01:00
Stein Magnus Jodal
2e1ea8080e Update MPD/reflection 2011-03-20 00:21:43 +01:00
Stein Magnus Jodal
cbe727d2bd Update MPD/playback 2011-03-20 00:19:30 +01:00
Stein Magnus Jodal
1048795f2b Update working MPD tests to start mixer actor 2011-03-20 00:17:31 +01:00
Stein Magnus Jodal
517a2a9356 Update MPD/music_db 2011-03-19 18:05:09 +01:00
Stein Magnus Jodal
4e82730732 Update MPD/dispatcher 2011-03-19 17:57:06 +01:00
Stein Magnus Jodal
0d57a74cb3 Update MPD/current_playlist 2011-03-19 17:55:05 +01:00
Stein Magnus Jodal
88780c717b Update MPD/connection 2011-03-19 17:55:00 +01:00
Stein Magnus Jodal
a4a015af1d Update MPD/audio_output 2011-03-19 17:54:57 +01:00
Stein Magnus Jodal
122e13be85 Fix mixer tests 2011-03-10 23:23:46 +01:00
Stein Magnus Jodal
0c6ad8e8f0 Fix output tests 2011-03-10 23:23:06 +01:00
Stein Magnus Jodal
46c6ee68df Fix ~200 backend tests 2011-03-10 23:19:44 +01:00
Stein Magnus Jodal
b89150f5d2 Skip tests instead of commenting them out 2011-02-12 02:21:38 +01:00
Stein Magnus Jodal
163ead53da Add 'play -1' support when playing 2011-02-12 02:03:18 +01:00
Stein Magnus Jodal
15c992e06a Add 'play -1' support, which fixes resume in MPoD 2011-02-12 01:45:36 +01:00
Stein Magnus Jodal
2463fdd945 Fix test that was declared twice 2011-02-12 01:38:44 +01:00
Martins Grunskis
159831c6e7 mopidy-scan fails if track has no artist name
stack trace:

    Traceback (most recent call last):
      File ./scan, line 27, in <module>
        for a in tracks_to_tag_cache_format(tracks):
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 138, in tracks_to_tag_cache_format
        _add_to_tag_cache(result, *tracks_to_directory_tree(tracks))
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 151, in _add_to_tag_cache
        _add_to_tag_cache(result, *entry)
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 156, in _add_to_tag_cache
        track_result = dict(track_to_mpd_format(track))
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 28, in track_to_mpd_format
        ('Artist', artists_to_mpd_format(track.artists)),
      File /home/martins/source/mopidy/mopidy/frontends/mpd/translator.py, line 88, in artists_to_mpd_format
        return u', '.join([a.name for a in artists if a])
    TypeError: sequence item 0: expected string or Unicode, NoneType found
2011-02-09 18:48:15 +02:00
Stein Magnus Jodal
e150a24dfe Review patch for GH-63
- Moved mask_value_if_secret til after the method using it. Most
  important/interesting method first, lower level/more detailed later.
- Made the logic in mask_value_if_secret simpler to understand, I think,
  by making the two different cases more obvious.
- Split the test in two, as it actually tested two different cases.
- Changed the test names to explain what should happen, and not just
  what is tested.
- Add a new test that tests the case which caused the crash: a setting
  being None.
2011-02-09 17:08:40 +01:00
Martins Grunskis
f33c65ddfe mopidy --list-settings fails on fresh install 2011-02-09 17:05:29 +02:00
Stein Magnus Jodal
5e87dcbfff Add 'date' query support to 'find' and 'search' to improve ncmpcpp media library browsing 2011-01-28 11:52:18 +01:00
Stein Magnus Jodal
11edbc160b Special case get_version() to include git revision id if we're running from a git repo 2011-01-25 22:03:28 +01:00
Stein Magnus Jodal
c097af1a83 Fix a bunch of pylint errors/warnings in test suite 2011-01-23 18:39:05 +01:00
Stein Magnus Jodal
a8c43d057f Merge branch 'master' into develop
Conflicts:
	docs/changes.rst
	mopidy/__init__.py
	tests/version_test.py
2011-01-22 14:39:15 +01:00
Stein Magnus Jodal
2512f468f4 Bump version number to 0.3.1 2011-01-22 14:33:39 +01:00
Stein Magnus Jodal
2bef4f2e49 Ready for v0.4.0 development 2011-01-22 14:03:13 +01:00
Stein Magnus Jodal
e1197ed84c Change default value of MPD_SERVER_PASSWORD from False to None 2011-01-21 16:31:35 +01:00
Stein Magnus Jodal
7f4ce3be8a Fix SettingsProxy.__getattr__ to support settings that are None or 0. 2011-01-21 16:29:04 +01:00
Stein Magnus Jodal
bf46b73b64 Fix typo in variable name 2011-01-21 16:05:04 +01:00
Stein Magnus Jodal
775ec64976 Test and improve password handling in MpdSession 2011-01-21 02:15:27 +01:00
Stein Magnus Jodal
8f0e00e1d7 Implement 'password' command which will be reached post-auth 2011-01-21 00:17:01 +01:00
Stein Magnus Jodal
a9461df4a0 Merge branch 'develop' into feature/multi-backend 2011-01-11 22:10:40 +01:00
Stein Magnus Jodal
3eb1d47765 Fix seek for Droid MPD 2011-01-09 23:46:03 +01:00
Stein Magnus Jodal
469e5fa189 Fix volume setting for Droid MPD 2011-01-09 23:38:46 +01:00
Stein Magnus Jodal
827940a977 Update Git repo references in tests 2010-11-23 09:39:40 +01:00
Stein Magnus Jodal
be225c23f1 Simplify DummyBackend instantiation 2010-11-03 23:31:11 +01:00
Stein Magnus Jodal
b7a0d75372 Merge branch 'feature/split-controllers-and-providers' into develop 2010-11-03 00:09:36 +01:00
Stein Magnus Jodal
fc9daa5a5a Rename {Base => }PlaybackController 2010-11-03 00:06:32 +01:00
Stein Magnus Jodal
76ce2a6345 Rename {Base => }StoredPlaylistController 2010-11-02 23:58:10 +01:00
Stein Magnus Jodal
5ada4709bd Rename {Base => }LibraryController 2010-11-02 23:54:02 +01:00