Commit Graph

2283 Commits

Author SHA1 Message Date
Nick Steel
531c090da9 test: Skips scanner tags test when there's no mp3 support.
The file order returned by .find is not deterministic which made
testing the first scanner result fail when it happened to be an unsupported
media format (e.g. mp3).
2019-01-31 22:56:36 +00:00
Nick Steel
5b32f87364 test: flake8 to ignore camelcase usage in our deps.
Ignore N813 when importing the c version of xml.etree.ElementTree.

Ignore N815 when controlling failure diff length in unittest.
2019-01-31 20:22:10 +00:00
Stein Magnus Jodal
52a035d217 flake8: Fix new warnings from flake8 2.4.0 2018-12-02 00:28:25 +01:00
Stein Magnus Jodal
c94b9d5fd2 xdg: Read paths from user-dirs.dirs as bytes
Fixes #1676, #1725
2018-11-27 23:22:50 +01:00
Nick Steel
10fafc0228 http: Add config option to control CSRF protection (Fixes: #1713)
Allows users to disable CSRF protection and revert to the HTTP server's
previous (less secure) behaviour. Users are advised to leave this config
value enabled if possible. However, if disabled this will:
  * Remove the requirement to set a ``Content-Type: application/json``
    header for JSON-RPC POST requests.
  * Disable all same-origin checks, effectively ignoring the ``allowed_origins``
    config since requests from any origin will be allowed.
  * Suppress all ``Access-Control-Allow-*`` response headers.
2018-10-15 17:24:45 +01:00
Nick Steel
6e9ed9e8a9 http: allow local files to access websocket (Fixes #1711)
check_origin() still ensures the Origin header is set but now only blocks
when missing from the allowed list *if* a network location was extracted
from the header. This prevents websocket connections originating from
local files (common in Apache Cordova apps such as Mopidy-Mobile) from
being blocked; these files don't really have a sensible value for Origin
so the client browser sets the header to something like 'file://' or
'null'.

Also added some tests for check_origin().
2018-10-08 23:39:47 +01:00
Stein Magnus Jodal
58e75b2b7a m3u: Ignore paths outside the playlist_dir
Fixes #1659
2018-09-19 22:27:18 +02:00
Stein Magnus Jodal
23e73d962b core: Define playlists.delete() return type 2018-09-19 22:27:18 +02:00
Stein Magnus Jodal
60546c595a m3u: Avoid using deprecated methods in tests 2018-09-19 22:27:18 +02:00
Nick Steel
e87599a2d3 Explicitly check for None (core playlists API future proofing). 2018-04-15 21:21:59 +01:00
Nick Steel
627684ec7b Updated playlistclear to use playlist lookup helper and added save failure tests. 2018-04-15 21:19:01 +01:00
nsteel
52a90a5a06 MPD's load and listplaylistinfo lookup track metadata. Fixes #1511.
Includes tests and refactored all playlist lookups to use helper.
2018-04-15 21:19:01 +01:00
Nick Steel
51741a7cbc HTTP: Apply allowed_origins to Websocket requests also. 2018-04-15 17:14:13 +01:00
Nick Steel
1b863b417b HTTP: New RPC CORS tests and fixed existing. 2018-04-15 17:12:16 +01:00
Stein Magnus Jodal
41882c6395 http: Remove conditional only needed for Tornado < 3.2 2018-04-13 13:05:23 +02:00
Stein Magnus Jodal
3e91f9819d tests: Make DummyAudio reset position when URI changes 2018-04-09 23:46:30 +02:00
matt LLVW
2e6c0049a4 config: remove 10000 tracks limitation in playlists 2018-04-04 19:20:17 +02:00
Stein Magnus Jodal
2471e5d269 Upgrade pytest from <3.3 to >=3.3
Remove dependency on pytest-capturelog, which is included in pytest 3.3.
2018-04-01 01:23:10 +02:00
Stein Magnus Jodal
e215484c75 encoding: Never crash if unknown bytes in OS errors
Fixes #1599
2018-03-30 11:25:31 +02:00
Stein Magnus Jodal
f3c9387219 encoding: Fix assert to match test intention 2018-03-30 11:08:23 +02:00
Stein Magnus Jodal
c59eccb06c stream: Don't compare entire track object
On Ubuntu 16.04 with GStreamer 1.2, we don't get a bitrate.

On Ubuntu 18.04 or macOS with GStreamer 1.12, we get a bitrate.
2018-03-29 17:16:22 +02:00
Stein Magnus Jodal
5112985cc7 m3u: Fix tests on macOS 10.13 2018-03-29 16:59:14 +02:00
Jarryd Tilbrook
b4c98ec4a5 Fix/1531 add unix domain socket (#1629)
mpd: add functionality for unix domain socket (Fixes #1531)

The Hostname config type now supports a Unix socket path prefixed with `unix:`
2018-02-13 12:58:39 +00:00
Nick Steel
d6eff50597 core: Fix library.lookup with an empty uri list. Fixes #1619. 2017-06-15 00:10:06 +01:00
Btjones711
03b763172a -Edited Test to reflect Idle bug fix 2017-01-26 21:07:54 -06:00
Stein Magnus Jodal
1eb9e087c9 core: Remove redundant comments 2016-10-25 00:17:58 +02:00
Stein Magnus Jodal
b6c16750cf Merge pull request #1549 from alexjaw/fix/1512
alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume
2016-10-25 00:17:14 +02:00
Jens Luetjen
1c8b5eeeaa Make test code more readable 2016-10-04 10:48:31 +02:00
dublok
18a3f6801c Scanner: set date to track and album 2016-09-19 20:09:02 +02:00
Jens Lütjen
92767e49f9 Fix typos and formatting 2016-09-16 21:01:10 +02:00
Jens Lütjen
5057b8b31d Merge 'develop' and resolve conflict
Conflicts:
	docs/changelog.rst
2016-09-14 18:17:52 +02:00
Alexander Jaworowski
95deb77939 alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume 2016-08-21 21:59:10 +02:00
Alexander Jaworowski
bee9bd3d23 alexjaw/fix/1512-inconsistent-playlist-state-with-repeat-and-consume 2016-08-21 21:40:17 +02:00
Stein Magnus Jodal
c0ce188451 Merge branch 'release-2.0' into develop 2016-08-12 01:17:31 +02:00
Stein Magnus Jodal
3346778c41 models: Fix encoding error in Identifier field
Fixes #1508
2016-08-11 23:55:31 +02:00
Stein Magnus Jodal
6a01a2e906 models: Test Identifier field type 2016-08-07 21:30:56 +02:00
Thomas Adamcik
692138a51e Merge pull request #1525 from palfrey/dodgy-date-tags
If the date in a tag is invalid, skip it
2016-07-25 22:01:12 +02:00
Thomas Adamcik
57b8b8435d Merge pull request #1525 from palfrey/dodgy-date-tags
If the date in a tag is invalid, skip it
2016-07-25 22:00:51 +02:00
Thomas Adamcik
3ee91240a0 Merge pull request #1496 from dublok/fix/1462-flac-seek-freeze
audio: Ignore position of _on_position_changed callback (fixes #1462)
2016-07-25 21:43:31 +02:00
Thomas Adamcik
c199fb1c81 lint: Workaround and fix to account for new version of flake8 2016-07-25 21:16:30 +02:00
Thomas Adamcik
fb823d1a7c lint: Workaround and fix to account for new version of flake8 2016-07-25 21:09:38 +02:00
Thomas Adamcik
068800c699 Merge pull request #1523 from ismailof/fix/1133-mpd-nextsongid
mpd: Add nextsong and nextsongid to mpd status command (Fixes #1133)
2016-06-26 11:52:24 +02:00
Thomas Adamcik
431984d103 Merge pull request #1496 from dublok/fix/1462-flac-seek-freeze
audio: Ignore position of _on_position_changed callback (fixes #1462)
2016-06-13 22:44:03 +02:00
Tom Parker
c3eb9b60c0 If tags date isn't a valid value for Python, skip the tag 2016-06-10 12:41:02 +01:00
ismailof
fc26b7304c chmod correction 2016-06-06 23:22:40 +02:00
ismailof
19818d3f68 Add MPD nextsong/nextsongid test case 2016-06-06 23:20:13 +02:00
Benjamin Chrétien
37cd296552 mpd: fix protocol for replay_gain_status 2016-05-31 16:36:37 +02:00
Jens Luetjen
c24380679f Test only events triggered after seek 2016-04-09 11:10:21 +02:00
Jens Luetjen
b55996da6a Changed wording export/restore to save/load 2016-04-02 16:28:04 +02:00
Jens Luetjen
00c47117d5 Test models.MixerState.mute 2016-04-02 16:11:47 +02:00